+1 here too. It's easy to revert by downgrading the rpm if it blows up.
On Fri, Apr 20, 2018 at 11:42:33AM +0200, Mikolaj Izdebski wrote:
On 04/20/2018 08:36 AM, Jan Kaluža wrote:
> this is FBR to fix MBS traceback which prevents builds of modules in situation when
new build-require is added to a module Foo. Currently, MBS tries to check what was the
commit hash ("ref") of such buildrequired module in previous build of Foo, but
it fails with KeyError, because the previous Foo module build did not build-required this
newly added build-required module.
> Full traceback is here:
> Traceback (most recent call last):
line 240, in process_message
> further_work = handler(conf, session, msg) or 
line 292, in wait
> if attempt_to_reuse_all_components(builder, session, build):
140, in attempt_to_reuse_all_components
> previous_module_build = _get_reusable_module(session, module)
123, in _get_reusable_module
> ref2 =
> KeyError: 'platform'
> Fixed patch  addresses this by catching the KeyError in this code block. It has
been tested on staging and I verified it fixes this issue.
> Jan Kaluza
> infrastructure mailing list -- infrastructure(a)lists.fedoraproject.org
> To unsubscribe send an email to infrastructure-leave(a)lists.fedoraproject.org
Senior Software Engineer, Red Hat
infrastructure mailing list -- infrastructure(a)lists.fedoraproject.org
To unsubscribe send an email to infrastructure-leave(a)lists.fedoraproject.org