[PATCH] OSTree: Force to create new ostree commit during updates compose run

[Sinny Kumari]

This patch (available in email attachment) is to create new ostree
commit when there is no content changes since last commit during
updates compose run. By passing force_new_commit as True, pungi
runs rpm-ostree command with option --force-nocache .

More details are in releng ticket - https://pagure.io/releng/issue/7585

Thanks,
Sinny

[Dusty Mabe]

On 06/29/2018 11:14 AM, Sinny Kumari wrote:
>  This patch (available in email attachment) is to create new ostree
>  commit when there is no content changes since last commit during
>  updates compose run. By passing force_new_commit as True, pungi
>  runs rpm-ostree command with option --force-nocache .
>  
>  More details are in releng ticket - https://pagure.io/releng/issue/7585
>  
>  Thanks,
>  Sinny 

Thanks Sinny. Can I ask for one change? We actually want "force_new_commit"
only for Atomic Host. For Atomic Workstation/Silverblue we actually don't
want "force_new_commit" because we don't do any formal releases (i.e. 2
week releases) for them and "force_new_commit" actually causes them to get
empty updates.

WDYT?

Dusty

[Sinny Kumari]

On Fri, Jun 29, 2018 at 9:48 PM, Dusty Mabe <dusty(a)dustymabe.com&gt; wrote:

>  On 06/29/2018 11:14 AM, Sinny Kumari wrote:
>  > This patch (available in email attachment) is to create new ostree
>  > commit when there is no content changes since last commit during
>  > updates compose run. By passing force_new_commit as True, pungi
>  > runs rpm-ostree command with option --force-nocache .
>  >
>  > More details are in releng ticket - https://pagure.io/releng/issue/7585
>  >
>  > Thanks,
>  > Sinny
>
>
>  Thanks Sinny. Can I ask for one change? We actually want "force_new_commit"
>  only for Atomic Host. For Atomic Workstation/Silverblue we actually don't
>  want "force_new_commit" because we don't do any formal releases (i.e. 2
>  week releases) for them and "force_new_commit" actually causes them to get
>  empty updates.
>
>  WDYT?
>
>  Yes, makes sense, updated the patch . 
Can you please commit this patch to ansible
repo and run the required
playbook?
Also for my info, it will be nice if you can let me know what playbook you
exactly ran.


-- 
http://sinny.io/

[Dusty Mabe]

On 06/29/2018 01:05 PM, Sinny Kumari wrote:

>  Yes, makes sense, updated the patch .
>  Can you please commit this patch to ansible repo and run the required playbook?
>  Also for my info, it will be nice if you can let me know what playbook you
>  exactly ran. 
LGTM. Will merge this after 1 day if no one responds here with an
objection.

The playbook I will run after git merge is:

$ ssh batcave01.phx2.fedoraproject.org
$ sudo rbac-playbook -t bodhi/pungi groups/bodhi-backend.yml

Dusty

[Sinny Kumari]

On Sat, Jun 30, 2018 at 12:04 AM, Dusty Mabe <dusty(a)dustymabe.com&gt; wrote:

>  On 06/29/2018 01:05 PM, Sinny Kumari wrote:
>
>  > Yes, makes sense, updated the patch .
>  > Can you please commit this patch to ansible repo and run the required
>  playbook?
>  > Also for my info, it will be nice if you can let me know what playbook
>  you
>  > exactly ran.
>
>  LGTM. Will merge this after 1 day if no one responds here with an
>  objection.
>
>  The playbook I will run after git merge is:
>
>  $ ssh batcave01.phx2.fedoraproject.org
>  $ sudo rbac-playbook -t bodhi/pungi groups/bodhi-backend.yml
>  
Thanks!



-- 
http://sinny.io/

[Dusty Mabe]

On 07/02/2018 02:48 AM, Sinny Kumari wrote:
>  
>  
>  On Sat, Jun 30, 2018 at 12:04 AM, Dusty Mabe <dusty(a)dustymabe.com
> <mailto:[e-mail]>> wrote:
>  
>  
>  
>      On 06/29/2018 01:05 PM, Sinny Kumari wrote:
>  
>      > Yes, makes sense, updated the patch .
>      > Can you please commit this patch to ansible repo and run the required playbook?
>      > Also for my info, it will be nice if you can let me know what playbook you
>      > exactly ran.
>  
>      LGTM. Will merge this after 1 day if no one responds here with an
>      objection.
>  
>      The playbook I will run after git merge is:
>  
>      $ ssh batcave01.phx2.fedoraproject.org
> <http://batcave01.phx2.fedoraproject.org>
>      $ sudo rbac-playbook -t bodhi/pungi groups/bodhi-backend.yml
>  
>  
>  Thanks!
>   
Sorry forgot to do this before. Just applied and ran the playbook.

Dusty

[Sinny Kumari]

On Tue, Jul 3, 2018 at 6:56 PM, Dusty Mabe <dusty(a)dustymabe.com&gt; wrote:

>  On 07/02/2018 02:48 AM, Sinny Kumari wrote:
>  >
>  >
>  > On Sat, Jun 30, 2018 at 12:04 AM, Dusty Mabe <dusty(a)dustymabe.com
>  <mailto:[e-mail]>> wrote:
>  >
>  >
>  >
>  >     On 06/29/2018 01:05 PM, Sinny Kumari wrote:
>  >
>  >     > Yes, makes sense, updated the patch .
>  >     > Can you please commit this patch to ansible repo and run the
>  required playbook?
>  >     > Also for my info, it will be nice if you can let me know what
>  playbook you
>  >     > exactly ran.
>  >
>  >     LGTM. Will merge this after 1 day if no one responds here with an
>  >     objection.
>  >
>  >     The playbook I will run after git merge is:
>  >
>  >     $ ssh batcave01.phx2.fedoraproject.org <http://batcave01.phx2.
>  fedoraproject.org>
>  >     $ sudo rbac-playbook -t bodhi/pungi groups/bodhi-backend.yml
>  >
>  >
>  > Thanks!
>  >
>
>  Sorry forgot to do this before. Just applied and ran the playbook.
>  
dustymabe++


-- 
http://sinny.io/