FBR: fix hooks for new packages on src.fedoraproject.org

[Kevin Fenzi]

Greetings.

It was reported to me that a number of new packages were not showing up
in grokmirror on src.fedoraproject.org. On looking I noted that new
packages did not have the chained post-receive hook we normally put in
place. The cause seems to be a typo in the command.

I'd like to:

* Apply the attached git patch
* run the pkgs ansible playbook.
* Manually run the check-git processes to fix all existing packages.
* Manually update grokmirror for all existing packages.

Note that without this we are not backing up any of the new packages, as
we are using grokmirror to back them up now.

+1s?

kevin
--
Subject: [PATCH] fix invocation of git-check-perms. This is needed to setup
 hooks on new packages as they are added

Signed-off-by: Kevin Fenzi <kevin(a)scrye.com&gt;
---
 roles/distgit/tasks/main.yml                     | 2 +-
 roles/gitolite/check_fedmsg_hooks/tasks/main.yml | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/roles/distgit/tasks/main.yml b/roles/distgit/tasks/main.yml
index 7d1f280..40c8a84 100644
--- a/roles/distgit/tasks/main.yml
+++ b/roles/distgit/tasks/main.yml
@@ -150,7 +150,7 @@
     name="check-update-hooks" cron_file="ansible-check-update-hooks"
     minute=0 hour=0 weekday=3
     user=nobody
-    job="MAILTO=root PATH=/usr/bin:/usr/local/bin/git-check-perms
--check=update-hook /srv/git/repositories"
+    job="/usr/local/bin/git-check-perms --check=update-hook
/srv/git/repositories"
   tags:
   - distgit

diff --git a/roles/gitolite/check_fedmsg_hooks/tasks/main.yml
b/roles/gitolite/check_fedmsg_hooks/tasks/main.yml
index 8766c8e..a22018e 100644
--- a/roles/gitolite/check_fedmsg_hooks/tasks/main.yml
+++ b/roles/gitolite/check_fedmsg_hooks/tasks/main.yml
@@ -8,7 +8,7 @@
     minute=10
     hour="0, 12"
     user=nobody
-    job="MAILTO=root PATH=/usr/bin:/usr/local/bin/git-check-perms
/srv/git/repositories --check=fedmsg-hook -f"
+    job="MAILTO=root /usr/local/bin/git-check-perms
/srv/git/repositories --check=fedmsg-hook -f"
   tags:
   - git
   - gitolite
-- 
1.8.3.1

[Patrick マルタインアンドレアス Uiterwijk]

>  Greetings.
>  
>  It was reported to me that a number of new packages were not showing up
>  in grokmirror on src.fedoraproject.org. On looking I noted that new
>  packages did not have the chained post-receive hook we normally put in
>  place. The cause seems to be a typo in the command.
>  
>  I'd like to:
>  
>  * Apply the attached git patch
>  * run the pkgs ansible playbook.
>  * Manually run the check-git processes to fix all existing packages.
>  * Manually update grokmirror for all existing packages.
>  
>  Note that without this we are not backing up any of the new packages, as
>  we are using grokmirror to back them up now.
>  
>  +1s? 
+1

> 
> kevin
> --
> Subject: [PATCH] fix invocation of git-check-perms. This is needed to setup
>  hooks on new packages as they are added
> 
> Signed-off-by: Kevin Fenzi <kevin(a)scrye.com&gt;
> ---
>  roles/distgit/tasks/main.yml                     | 2 +-
>  roles/gitolite/check_fedmsg_hooks/tasks/main.yml | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/roles/distgit/tasks/main.yml b/roles/distgit/tasks/main.yml
> index 7d1f280..40c8a84 100644
> --- a/roles/distgit/tasks/main.yml
> +++ b/roles/distgit/tasks/main.yml
> @@ -150,7 +150,7 @@
>      name="check-update-hooks"
cron_file="ansible-check-update-hooks"
>      minute=0 hour=0 weekday=3
>      user=nobody
> -    job="MAILTO=root PATH=/usr/bin:/usr/local/bin/git-check-perms
> --check=update-hook /srv/git/repositories"
> +    job="/usr/local/bin/git-check-perms --check=update-hook
> /srv/git/repositories"
>    tags:
>    - distgit
> 
> diff --git a/roles/gitolite/check_fedmsg_hooks/tasks/main.yml
> b/roles/gitolite/check_fedmsg_hooks/tasks/main.yml
> index 8766c8e..a22018e 100644
> --- a/roles/gitolite/check_fedmsg_hooks/tasks/main.yml
> +++ b/roles/gitolite/check_fedmsg_hooks/tasks/main.yml
> @@ -8,7 +8,7 @@
>      minute=10
>      hour="0, 12"
>      user=nobody
> -    job="MAILTO=root PATH=/usr/bin:/usr/local/bin/git-check-perms
> /srv/git/repositories --check=fedmsg-hook -f"
> +    job="MAILTO=root /usr/local/bin/git-check-perms
> /srv/git/repositories --check=fedmsg-hook -f"
>    tags:
>    - git
>    - gitolite

[Stephen John Smoogen]

+1 please do.

On 9 March 2018 at 14:07, Patrick  マルタインアンドレアス  Uiterwijk
<puiterwijk(a)redhat.com&gt; wrote:
> > Greetings.
> >
> > It was reported to me that a number of new packages were not showing up
> > in grokmirror on src.fedoraproject.org. On looking I noted that new
> > packages did not have the chained post-receive hook we normally put in
> > place. The cause seems to be a typo in the command.
> >
> > I'd like to:
> >
> > * Apply the attached git patch
> > * run the pkgs ansible playbook.
> > * Manually run the check-git processes to fix all existing packages.
> > * Manually update grokmirror for all existing packages.
> >
> > Note that without this we are not backing up any of the new packages, as
> > we are using grokmirror to back them up now.
> >
> > +1s?
>
>  +1
>
> >
> > kevin
> > --
> > Subject: [PATCH] fix invocation of git-check-perms. This is needed to setup
> >  hooks on new packages as they are added
> >
> > Signed-off-by: Kevin Fenzi <kevin(a)scrye.com&gt;
> > ---
> >  roles/distgit/tasks/main.yml                     | 2 +-
> >  roles/gitolite/check_fedmsg_hooks/tasks/main.yml | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/roles/distgit/tasks/main.yml b/roles/distgit/tasks/main.yml
> > index 7d1f280..40c8a84 100644
> > --- a/roles/distgit/tasks/main.yml
> > +++ b/roles/distgit/tasks/main.yml
> > @@ -150,7 +150,7 @@
> >      name="check-update-hooks"
> cron_file="ansible-check-update-hooks"
> >      minute=0 hour=0 weekday=3
> >      user=nobody
> > -    job="MAILTO=root PATH=/usr/bin:/usr/local/bin/git-check-perms
> > --check=update-hook /srv/git/repositories"
> > +    job="/usr/local/bin/git-check-perms --check=update-hook
> > /srv/git/repositories"
> >    tags:
> >    - distgit
> >
> > diff --git a/roles/gitolite/check_fedmsg_hooks/tasks/main.yml
> > b/roles/gitolite/check_fedmsg_hooks/tasks/main.yml
> > index 8766c8e..a22018e 100644
> > --- a/roles/gitolite/check_fedmsg_hooks/tasks/main.yml
> > +++ b/roles/gitolite/check_fedmsg_hooks/tasks/main.yml
> > @@ -8,7 +8,7 @@
> >      minute=10
> >      hour="0, 12"
> >      user=nobody
> > -    job="MAILTO=root PATH=/usr/bin:/usr/local/bin/git-check-perms
> > /srv/git/repositories --check=fedmsg-hook -f"
> > +    job="MAILTO=root /usr/local/bin/git-check-perms
> > /srv/git/repositories --check=fedmsg-hook -f"
> >    tags:
> >    - git
> >    - gitolite
>  _______________________________________________
>  infrastructure mailing list -- infrastructure(a)lists.fedoraproject.org
>  To unsubscribe send an email to infrastructure-leave(a)lists.fedoraproject.org 


-- 
Stephen J Smoogen.

[Igor Gnatenko]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On Fri, 2018-03-09 at 11:03 -0800, Kevin Fenzi wrote:
>  Greetings.
>  
>  It was reported to me that a number of new packages were not showing
>  up
>  in grokmirror on src.fedoraproject.org. On looking I noted that new
>  packages did not have the chained post-receive hook we normally put
>  in
>  place. The cause seems to be a typo in the command.
>  
>  I'd like to:
>  
>  * Apply the attached git patch
>  * run the pkgs ansible playbook.
>  * Manually run the check-git processes to fix all existing packages.
>  * Manually update grokmirror for all existing packages. 
Not sure if this all done, but my observation so far is that once I
push something into rust-* repos, it appears in grok-mirror. But rest
of packages (untouched) is still not there.
[brain@dell-per930-01 ~]$ ll src.fedoraproject.org/rpms/rust-* -d | wc
- -l                                
29                                                  
- -- 
- -Igor Gnatenko
> -----BEGIN PGP SIGNATURE-----
>
> iQIzBAEBCAAdFiEEhLFO09aHZVqO+CM6aVcUvRu8X0wFAlqmYq0ACgkQaVcUvRu8
> X0ztnA//fFyVDIJ8TmXvMX6CkZC22g4bwcCJG46gDGh59k+63TvEHfR6e0yI7tsx
> Qe6w2xVoubNuEZBwLSZ5tDaat8nfeSt0mqjACdsoKjxCgzC5+cjuiVXJoO73PEt2
> 9jACXCD5FBMQD+Yaa3GeI9rE9wt6QoAiIzuKd+cEtHNIBZ+woE/ychdlS+exysIo
> YP3Qgnc+QrdAKS3IReZK4vPjXKxjWsWKFd5qCERFBasESzD+iQInbntgIe/PHW2G
> O5QYHjksogkaJ/QbpCwUQFMoNCaS0OK9PQyY5usuNwY23LKhVTm9QogAnG++zy3M
> XcojWFbvlBxAsORLmmmv/HsjHAecPbpVXOjjcSbcEdL9GFXT+Lmiy7CjBw9PMC3X
> /XMWcPT8vDna4IH6fP5KjSTwcXOgDKiTRfopC/8soFGci5SLnWGaQeVAqgmR75rD
> Rjsj/8Wq01BN6bwQ3Iq/Hj2K0abKy3evihzF8MhHd5y6MeomYcKlKB035a7Otdio
> kom0tiV58D1qTwBf+2/0+HWDBRgEFSt46UkC2GPjAHHOLAWCkMbTWYKHxmAp1WPx
> zxnpQgnBiJ+bGSF1qYeTmRJCGdyUFZtP9xAXdZj6zghxDsSwvkTfCKBuBfbdwNpQ
> FuhgLMN0d1W60MkG0D8OeMpJo7fKlE4bNy82PM4peoEyVeCXVK0=
> =p6ZD
> -----END PGP SIGNATURE-----

[Kevin Fenzi]

On 03/12/2018 04:21 AM, Igor Gnatenko wrote:
>  On Fri, 2018-03-09 at 11:03 -0800, Kevin Fenzi wrote:
> > Greetings.
>  
> > It was reported to me that a number of new packages were not showing
> > up
> > in grokmirror on src.fedoraproject.org. On looking I noted that new
> > packages did not have the chained post-receive hook we normally put
> > in
> > place. The cause seems to be a typo in the command.
>  
> > I'd like to:
>  
> > * Apply the attached git patch
> > * run the pkgs ansible playbook.
> > * Manually run the check-git processes to fix all existing packages.
> > * Manually update grokmirror for all existing packages.
>  
>  Not sure if this all done,  
It's not.

I have been having trouble getting grockmirror to generate a new
manifest with all the git repos in it without running out of memory or
files. Hopefully I'll have something soon.

>  but my observation so far is that once I
>  push something into rust-* repos, it appears in grok-mirror. But rest
>  of packages (untouched) is still not there.
>  [brain@dell-per930-01 ~]$ ll src.fedoraproject.org/rpms/rust-* -d | wc
>  -l                                
>  29                                                   
Thats correct. They will not be until I make the new manifest live, or
some commit is pushed in them (updating the existing manifest)

kevin