[PATCH] - fallback to local FontAwesome fonts in apps.fp.org/global

[Ryan Lerch]

This patch adds a final-level fallback to the FontAwesome font declaration
to use the local version of the FontAwesome font.

This is mainly for when devs are hacking on a local instance of apps that
are using this font, as the CORS settings will resctrict them from
downloading the fonts.

[Ryan Lerch]

Just wondering is someone is able to review this one for me!

thanks,
ryanlerch

On Thu, Dec 15, 2016 at 2:14 PM, Ryan Lerch <rlerch(a)redhat.com&gt; wrote:

>  This patch adds a final-level fallback to the FontAwesome font
> declaration
>  to use the local version of the FontAwesome font.
>
>  This is mainly for when devs are hacking on a local instance of apps that
>  are using this font, as the CORS settings will resctrict them from
>  downloading the fonts.
>
>
>

[Chaoyi Zha]

Hi Ryan,

I was able to reproduce a scenario in which the FontAwesome fonts were
blocked due to CORS rules, but my browser seemed to automatically detect my
font locally and used that font instead. It was able to display all
FontAwesome glyphs without a problem. Is local('FontAwesome') redundant or
is there a scenario in which it is necessary to use the local font?


On Thu, 23 Feb 2017 at 05:26 Ryan Lerch <rlerch(a)redhat.com&gt; wrote:

>  Just wondering is someone is able to review this one for me!
>
>  thanks,
>  ryanlerch
>
>  On Thu, Dec 15, 2016 at 2:14 PM, Ryan Lerch <rlerch(a)redhat.com&gt; wrote:
>
>  This patch adds a final-level fallback to the FontAwesome font declaration
>  to use the local version of the FontAwesome font.
>
>  This is mainly for when devs are hacking on a local instance of apps that
>  are using this font, as the CORS settings will resctrict them from
>  downloading the fonts.
>
>
>
>  _______________________________________________
>  infrastructure mailing list -- infrastructure(a)lists.fedoraproject.org
>  To unsubscribe send an email to
>  infrastructure-leave(a)lists.fedoraproject.org
>

[Ryan Lerch]

What browser are you using? This is still happening for me on Firefox

On Fri, Feb 24, 2017 at 8:04 AM, Chaoyi Zha <cydrobolt(a)fedoraproject.org&gt;
wrote:

>  Hi Ryan,
>
>  I was able to reproduce a scenario in which the FontAwesome fonts were
>  blocked due to CORS rules, but my browser seemed to automatically detect my
>  font locally and used that font instead. It was able to display all
>  FontAwesome glyphs without a problem. Is local('FontAwesome') redundant or
>  is there a scenario in which it is necessary to use the local font?
>
>
>  On Thu, 23 Feb 2017 at 05:26 Ryan Lerch <rlerch(a)redhat.com&gt; wrote:
>
> > Just wondering is someone is able to review this one for me!
> >
> > thanks,
> > ryanlerch
> >
> > On Thu, Dec 15, 2016 at 2:14 PM, Ryan Lerch <rlerch(a)redhat.com&gt; wrote:
> >
> > This patch adds a final-level fallback to the FontAwesome font
> > declaration to use the local version of the FontAwesome font.
> >
> > This is mainly for when devs are hacking on a local instance of apps that
> > are using this font, as the CORS settings will resctrict them from
> > downloading the fonts.
> >
> >
> >
> > _______________________________________________
> > infrastructure mailing list -- infrastructure(a)lists.fedoraproject.org
> > To unsubscribe send an email to infrastructure-leave@lists.
> > fedoraproject.org
> >
>
>  _______________________________________________
>  infrastructure mailing list -- infrastructure(a)lists.fedoraproject.org
>  To unsubscribe send an email to infrastructure-leave@lists.
>  fedoraproject.org
>
>

[Ryan Lerch]

On Fri, Feb 24, 2017 at 8:04 AM, Chaoyi Zha <cydrobolt(a)fedoraproject.org&gt;
wrote:

>  Hi Ryan,
>
>  I was able to reproduce a scenario in which the FontAwesome fonts were
>  blocked due to CORS rules, but my browser seemed to automatically detect my
>  font locally and used that font instead. It was able to display all
>  FontAwesome glyphs without a problem. Is local('FontAwesome') redundant or
>  is there a scenario in which it is necessary to use the local font?
>  
Were you using the font-definition here?

https://apps.fedoraproject.org/global/fedora-bootstrap-fonts/font-awesome...

If you use this file to load the fonts, say on localhost you should hit the
CORS resctrictions, and the font not load. This change is primarily for the
scenario where developers are testing on a local system, and will hit the
CORS restrictions that we have in place for the font files on
https://apps.fedoraproject.org/global/ . It is a last-level fallback, so on
the prod systems where the CORS restrictions do not apply, the non-local
font file should never be used.

cheers,
ryanlerch


>  On Thu, 23 Feb 2017 at 05:26 Ryan Lerch <rlerch(a)redhat.com&gt; wrote:
>
> > Just wondering is someone is able to review this one for me!
> >
> > thanks,
> > ryanlerch
> >
> > On Thu, Dec 15, 2016 at 2:14 PM, Ryan Lerch <rlerch(a)redhat.com&gt; wrote:
> >
> > This patch adds a final-level fallback to the FontAwesome font
> > declaration to use the local version of the FontAwesome font.
> >
> > This is mainly for when devs are hacking on a local instance of apps that
> > are using this font, as the CORS settings will resctrict them from
> > downloading the fonts.
> >
> >
> >
> > _______________________________________________
> > infrastructure mailing list -- infrastructure(a)lists.fedoraproject.org
> > To unsubscribe send an email to infrastructure-leave@lists.
> > fedoraproject.org
> >
>
>  _______________________________________________
>  infrastructure mailing list -- infrastructure(a)lists.fedoraproject.org
>  To unsubscribe send an email to infrastructure-leave@lists.
>  fedoraproject.org
>
>

[Chaoyi Zha]

I was testing this issue on Chrome. I can try again in Firefox to see if I
encounter your issue.

On Mon, Mar 6, 2017, 9:17 PM Ryan Lerch <rlerch(a)redhat.com&gt; wrote:

>  On Fri, Feb 24, 2017 at 8:04 AM, Chaoyi Zha
> <cydrobolt(a)fedoraproject.org&gt;
>  wrote:
>
>  Hi Ryan,
>
>  I was able to reproduce a scenario in which the FontAwesome fonts were
>  blocked due to CORS rules, but my browser seemed to automatically detect my
>  font locally and used that font instead. It was able to display all
>  FontAwesome glyphs without a problem. Is local('FontAwesome') redundant or
>  is there a scenario in which it is necessary to use the local font?
>
>
>  Were you using the font-definition here?
>
>
>  https://apps.fedoraproject.org/global/fedora-bootstrap-fonts/font-awesome...
>
>  If you use this file to load the fonts, say on localhost you should hit
>  the CORS resctrictions, and the font not load. This change is primarily for
>  the scenario where developers are testing on a local system, and will hit
>  the CORS restrictions that we have in place for the font files on
>  https://apps.fedoraproject.org/global/ . It is a last-level fallback, so
>  on the prod systems where the CORS restrictions do not apply, the non-local
>  font file should never be used.
>
>  cheers,
>  ryanlerch
>
>
>
>
>  On Thu, 23 Feb 2017 at 05:26 Ryan Lerch <rlerch(a)redhat.com&gt; wrote:
>
>  Just wondering is someone is able to review this one for me!
>
>  thanks,
>  ryanlerch
>
>  On Thu, Dec 15, 2016 at 2:14 PM, Ryan Lerch <rlerch(a)redhat.com&gt; wrote:
>
>  This patch adds a final-level fallback to the FontAwesome font declaration
>  to use the local version of the FontAwesome font.
>
>  This is mainly for when devs are hacking on a local instance of apps that
>  are using this font, as the CORS settings will resctrict them from
>  downloading the fonts.
>
>
>
>  _______________________________________________
>  infrastructure mailing list -- infrastructure(a)lists.fedoraproject.org
>  To unsubscribe send an email to
>  infrastructure-leave(a)lists.fedoraproject.org
>
>
>  _______________________________________________
>  infrastructure mailing list -- infrastructure(a)lists.fedoraproject.org
>  To unsubscribe send an email to
>  infrastructure-leave(a)lists.fedoraproject.org
>
>  _______________________________________________
>  infrastructure mailing list -- infrastructure(a)lists.fedoraproject.org
>  To unsubscribe send an email to
>  infrastructure-leave(a)lists.fedoraproject.org
>