Hi all,
I have updated the theme on the staging wiki, and just asking everyone to give it a quick test out before pushing it to production.
The only change is that i have bumped to a newer version of Fedora Bootstrap, which required some reformatting of a bunch of elements, but it all should be working ok.
https://stg.fedoraproject.org/wiki/
cheers, Ryanlerch
Dne 29. 01. 25 v 4:50 dop. Ryan Lerch via infrastructure napsal(a):
Hi all,
I have updated the theme on the staging wiki, and just asking everyone to give it a quick test out before pushing it to production.
The only change is that i have bumped to a newer version of Fedora Bootstrap, which required some reformatting of a bunch of elements, but it all should be working ok.
The images are missing. E.g., https://stg.fedoraproject.org/w/uploads/6/60/Overview-docs-icon.png
The anchors (
🔗 https://stg.fedoraproject.org/wiki/Fedora_Project_Wiki#Looking_for_documentation?
) has underscore, because it is a link. It would look better if you remove the underscore
This is how "Join Fedora" page looks on my screen: https://k00.fr/2k3e7gkc (4k rotated by 90˚)
Notice that the main page has wide margins. I consider this waste of space.
Notice the odd formating of bullet list in the cards in the middle.
Otherwise LGTM. It is definitelly improvement. Thank you.
On Wed, Jan 29, 2025 at 4:52 PM Miroslav Suchý via infrastructure infrastructure@lists.fedoraproject.org wrote:
Dne 29. 01. 25 v 4:50 dop. Ryan Lerch via infrastructure napsal(a):
Hi all,
I have updated the theme on the staging wiki, and just asking everyone to give it a quick test out before pushing it to production.
The only change is that i have bumped to a newer version of Fedora Bootstrap, which required some reformatting of a bunch of elements, but it all should be working ok.
https://stg.fedoraproject.org/wiki/
The images are missing. E.g., https://stg.fedoraproject.org/w/uploads/6/60/Overview-docs-icon.png
This is purely a stg thing sadly -- the images aren't imported into the staging wiki -- and i haven't figured out how to do a bulk import into staging. The images will be there still on prod.
The anchors (
🔗
) has underscore, because it is a link. It would look better if you remove the underscore
This one is definitely a regression -- the current theme does not have any text decoration on links.
This is how "Join Fedora" page looks on my screen: https://k00.fr/2k3e7gkc (4k rotated by 90˚)
Notice that the main page has wide margins. I consider this waste of space.
This is not really a regression -- the main body container is the same width on the current site. The only difference here is that I have accidentally made the top bar full-width which it was not previously -- so I'm going to make it match the body container. It doesn't fix your waste of space comment, but it is the same as what we currently have.
Notice the odd formating of bullet list in the cards in the middle.
That page is actaully currently not in use on the main wiki page -- the weird bullet point formatting is because that page uses tables to layout content, so i its a wiki content issue rather than the theme (but we dont use that page in prod anymore either)
Otherwise LGTM. It is definitelly improvement. Thank you.
Thanks so much for taking the time to review!
cheers, Ryanlerch
-- Miroslav Suchy, RHCA Red Hat, Manager, Packit and CPT, #brno, #fedora-buildsys
-- _______________________________________________ infrastructure mailing list -- infrastructure@lists.fedoraproject.org To unsubscribe send an email to infrastructure-leave@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/infrastructure@lists.fedorapro... Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
On Wed, Jan 29, 2025 at 01:50:49PM +1000, Ryan Lerch via infrastructure wrote:
Hi all,
I have updated the theme on the staging wiki, and just asking everyone to give it a quick test out before pushing it to production.
The only change is that i have bumped to a newer version of Fedora Bootstrap, which required some reformatting of a bunch of elements, but it all should be working ok.
Yeah, aside the items noted in this thread already, thanks for doing this.
We will need to sort out upgrading the wiki next cycle (when 40 goes eol), but we can burn that bridge when we come to it. :)
kevin
infrastructure@lists.fedoraproject.org