Re: FBR: update prod tag name in WaiverDB

[Clement Verna]

On Mon, 25 Mar 2019 at 10:49, Yuxiang Zhu  wrote:
> Currently the prod-fedora tag points to the same image as prod tag.
>
> I just checked `quay.io/factory2/waiverdb:prod-fedora` (sha256:726a6c6465e066bc1056c17b71c16117150266490fed8fa2b096e7bb249eba8e) from quay.io's Web UI.  It is built from https://pagure.io/waiverdb/tree/d4ea9bffd9da52efbef147b0e2d42cc726c1d7c6 so the change of messaging is not included.

Great Thanks :)

It would be +1 for me, but my vote does not count :)
> On Mon, Mar 25, 2019 at 5:39 PM Clement Verna  wrote:
> > On Mon, 25 Mar 2019 at 10:22, Giulia Naponiello  wrote:
> > > Hello,
> > > we would like to change the name of the tag in quay.io for WaiverDB. Could you make this change?
> >
> > Does that contains the change to use fedora-messaging instead of fedmsg ?
> > > Here's the patch:
> > > diff --git a/roles/openshift-apps/waiverdb/templates/imagestream.yml b/roles/openshift-apps/waiverdb/templates/imagestream.yml
> > > index 3fe37a481..7758ea5c6 100644
> > > --- a/roles/openshift-apps/waiverdb/templates/imagestream.yml
> > > +++ b/roles/openshift-apps/waiverdb/templates/imagestream.yml
> > > @@ -20,5 +20,5 @@ spec:
> > >        name: quay.io/factory2/waiverdb:latest
> > >  {% else %}
> > >        # This is 'prod' tag is maintained by hand.
> > >  name: quay.io/factory2/waiverdb:prod
> > >  name: quay.io/factory2/waiverdb:prod-fedora
> > >
> > > {% endif %}
> > >
> > > Thank you!
> > > Cheers
> > >
> > > Giulia
> > > _______________________________________________
> > > infrastructure mailing list -- [e-mail]
> > > To unsubscribe send an email to [e-mail]
> > > Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
> > > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> > > List Archives: https://lists.fedoraproject.org/archives/list/[e-mail]...
>
> --
> Thanks,
> Yuxiang

FBR: update prod tag name in WaiverDB

[Pierre-Yves Chibon]

On Mon, Mar 25, 2019 at 10:57:38AM +0100, Clement Verna wrote:
> On Mon, 25 Mar 2019 at 10:49, Yuxiang Zhu  wrote:
> > Currently the prod-fedora tag points to the same image as prod tag.
> >
> > I just checked `quay.io/factory2/waiverdb:prod-fedora` (sha256:726a6c6465e066bc1056c17b71c16117150266490fed8fa2b096e7bb249eba8e) from quay.io's Web UI.  It is built from https://pagure.io/waiverdb/tree/d4ea9bffd9da52efbef147b0e2d42cc726c1d7c6 so the change of messaging is not included.

If they point to the same image, what is the need for this FBR?
(in other words, why should we change a frozen system during an infra freeze if
it doesn't change anything? :))

If it is harmless, I don't want to block it, but I'd argue there is a bit of
context missing :)

Thanks,
Pierre