Review app for Fedora

[Pierre-Yves Chibon]

Hi,

With the work recently done on fedora-review [1], I started to wonder if
it would be interesting to work on an app dedicated to review RPM
package for Fedora.

I got myself day dreaming about:
- One goes to this new website
- Login using FAS credential
- Click on the "create new review"
- Provide name/summary/source rpm
- Upload source rpm (check that it is a source rpm)
- The ticket gets created
- Unpack the source rpm
  - Put the tarball/zip into the dedicated directory
  - Create a Git repo
  - Add all the other files from the source rpm into the git repository
- fedora-review runs against this new package.

- Reporter adapts his spec file in the git repo
- fedora-review runs for each new version and print out the changes (?
or not)

- Reviewer works from the git
- Reviewer declares the review:
  - approve
    - git gets move and rename to become the official git repository
  - invalid (for license/bundled lib...)
    - git get removed from the filesystem
  - close (stalled reporter/any other reason)
    - git get removed from the filesystem

I was wondering if it could rely on a similar infrastructure than what
we are using via fedpkg/pyrpkg (a reviewpkg ?).

I was curious if that would be interesting and since an example is worth
many words, I tried to work on a small proof of concept [2]. The
README.txt contains the information on how to set it up for testing.
It needs still a lot of changes:
- All parts regarding the review itself (changing the status, adding one
in cc, mail comments added...) is to be done
- The design needs to be done (this has to be done, what's there atm is
just good enough for testing :-))
but as I said, it's more a PoC for the moment to collect
ideas/feedback/critics.

I am starting the conversation here on the infra list to get the first
reactions, it'll be opened to the devel list later on if worth it.

So please shoot :-)

Thanks,
Pierre

[1] https://fedorahosted.org/FedoraReview/
[2] http://ambre.pingoured.fr/cgit/review_srv.git/

[Kevin Fenzi]

On Tue, 29 Nov 2011 14:51:39 +0100
Pierre-Yves Chibon  wrote:
> Hi,
>
> With the work recently done on fedora-review [1], I started to wonder
> if it would be interesting to work on an app dedicated to review RPM
> package for Fedora.
>
> I got myself day dreaming about:

...snip...

So, the advantages would be:

- Could run the review tool on the package whenever it updated. 
- git history could be kept. 
- Could possibly require some level of completness before filing the
  review.

Disadvantages would be:

- Another service/code we need to maintain. 
- Possibly having to deal with junk uploads unless we filter things
  well.

Any others?
> I was wondering if it could rely on a similar infrastructure than what
> we are using via fedpkg/pyrpkg (a reviewpkg ?).

Possibly. I would personally not want to see this on the same
server/setup as real packages, just to be sure there would be no
leakage from these into real packages somehow.

But some kind of similar instance could be setup I suppose.
> I was curious if that would be interesting and since an example is
> worth many words, I tried to work on a small proof of concept [2]. The
> README.txt contains the information on how to set it up for testing.
> It needs still a lot of changes:
> All parts regarding the review itself (changing the status, adding
>
> one in cc, mail comments added...) is to be done

It makes me wonder if we couldn't just ditch bugzilla entirely if we
move to this? have comments and such in the app...
> The design needs to be done (this has to be done, what's there atm
>
> is just good enough for testing :-))
> but as I said, it's more a PoC for the moment to collect
> ideas/feedback/critics.
>
> I am starting the conversation here on the infra list to get the first
> reactions, it'll be opened to the devel list later on if worth it.
>
> So please shoot :-)

Above are my 2cents. ;)

[Pierre-Yves Chibon]

On Tue, 2011-11-29 at 13:18 -0700, Kevin Fenzi wrote:
> On Tue, 29 Nov 2011 14:51:39 +0100
> Pierre-Yves Chibon  wrote:
> > Hi,
> >
> > With the work recently done on fedora-review [1], I started to wonder
> > if it would be interesting to work on an app dedicated to review RPM
> > package for Fedora.
> >
> > I got myself day dreaming about:
>
> ...snip...
>
> So, the advantages would be:
> Could run the review tool on the package whenever it updated.
> git history could be kept.
> Could possibly require some level of completness before filing the
> review.
>
> Disadvantages would be:
> Another service/code we need to maintain.
> Possibly having to deal with junk uploads unless we filter things
> well.
>
> Any others?

What's your overall feeling? Positive/negative ?
> > I was wondering if it could rely on a similar infrastructure than what
> > we are using via fedpkg/pyrpkg (a reviewpkg ?).
>
> Possibly. I would personally not want to see this on the same
> server/setup as real packages, just to be sure there would be no
> leakage from these into real packages somehow.
>
> But some kind of similar instance could be setup I suppose.

That was my idea yes.
> > I was curious if that would be interesting and since an example is
> > worth many words, I tried to work on a small proof of concept [2]. The
> > README.txt contains the information on how to set it up for testing.
> > It needs still a lot of changes:
> > All parts regarding the review itself (changing the status, adding
> >
> > one in cc, mail comments added...) is to be done
>
> It makes me wonder if we couldn't just ditch bugzilla entirely if we
> move to this? have comments and such in the app...

That was also my idea, move all package review to this.

Thanks for your feedback.

Pierre

[Pierre-Yves Chibon]

On Tue, 2011-11-29 at 13:18 -0700, Kevin Fenzi wrote:
> Possibly having to deal with junk uploads unless we filter things
> well.

Also, regarding this what it's doing for the moment is:
- you upload one file
- it checks if the file is a rpm package using the python version of
rpm2cpio
  - if it is not: return to user (so the file is never actually written
to disk)
  - if it is, the source rpm is extracted, all the compressed file
(.gz, .tar, .zip) are moved to a set place, the other are added to the
git repository.

So hopefully we would not have too much junk stored.

Pierre

[Toshio Kuratomi]

On Tue, Nov 29, 2011 at 01:18:27PM -0700, Kevin Fenzi wrote:
> On Tue, 29 Nov 2011 14:51:39 +0100
> Pierre-Yves Chibon  wrote:
> > Hi,
> >
> > With the work recently done on fedora-review [1], I started to wonder
> > if it would be interesting to work on an app dedicated to review RPM
> > package for Fedora.
> >
> > I got myself day dreaming about:
>
> ...snip...
>
> So, the advantages would be:
> Could run the review tool on the package whenever it updated.
> git history could be kept.
> Could possibly require some level of completness before filing the
> review.

- We could have tighter integration with pkgdb/pkgs.fedoraproject.org/koji
  (for instance, automating the creation of package branches when a review
  is marked approved).
> Disadvantages would be:
> Another service/code we need to maintain.
> Possibly having to deal with junk uploads unless we filter things
> well.

Documentation updates and workflow changes (Not so much a disadvantage as
one-time work to perform).

I know having a dedicated web app for this sort of thing was discussed when
Fedora Extras was new.  I think that it was just not implemented because we
didn't have time and bugzilla worked well enough to get us what we
absolutely needed.

-Toshio