Re: [PATCH 0/5] iptraf-ng: make "struct OPTIONS options" global
On Fri, Aug 24, 2012 at 02:27:58PM +0200, Nikola Pajkovsky wrote:
Vitezslav Samel <vitezslav(a)samel.cz> writes:
> There's no point in passing the struct OPTIONS pointer to every
> other function; this patch make the "struct OPTIONS options" variable
> global and fixes every reference to it. Entire patch series also makes
> iptraf-ng code size by 1,5 kB smaller.
>
> Vitezslav Samel (5):
> make struct OPTIONS options global
> move options.actmode variable passing one layer down
> push options.actmode variable passing one more layer down
> push options.servnames variable down ...
> push options.mac variable down ...
>
> src/detstats.c | 44 ++++++++++-----------
> src/detstats.h | 4 +-
> src/hostmon.c | 48 ++++++++++-------------
> src/hostmon.h | 4 +-
> src/ifstats.c | 39 +++++++++----------
> src/ifstats.h | 4 +-
> src/iptraf.c | 39 +++++++++----------
> src/itrafmon.c | 98 +++++++++++++++++++++--------------------------
> src/itrafmon.h | 4 +-
> src/options.c | 114 ++++++++++++++++++++++++++++---------------------------
> src/options.h | 8 ++-
> src/othptab.c | 29 +++++---------
> src/othptab.h | 6 +--
> src/pktsize.c | 18 ++++----
> src/pktsize.h | 5 +-
> src/rate.c | 9 ++--
> src/rate.h | 4 +-
> src/serv.c | 74 +++++++++++++++++-------------------
> src/serv.h | 4 +-
> src/servname.c | 6 +-
> src/servname.h | 3 +-
> src/tcptable.c | 57 ++++++++++++----------------
> src/tcptable.h | 13 +++---
> 23 files changed, 290 insertions(+), 344 deletions(-)
honestly, I will squash them into one.
Honestly, I didn't sent you the squashed patch, so you can't put my
Signed-off-by: line on it (From: is possible, but not Signed-off-by:)
Vita