Re: [PATCH 1/4] build: replace ancient prototypes by modern equivalents

[Nikola Pajkovsky]

Jan Engelhardt <jengelh(a)medozas.de&gt; writes:

>  Resolves these warnings:
>
>  itrafmon.c: In function "ipmon":
>  itrafmon.c:1004:17: warning: call to function "show_sort_statwin"
>  without a real prototype
>  deskman.h:22:6: note: "show_sort_statwin" was declared here
>
>  Signed-off-by: Jan Engelhardt <jengelh(a)medozas.de&gt;
>  ---
>   src/deskman.h |   10 +++++-----
>   src/fltmgr.h  |    4 ++--
>   src/iptraf.c  |    2 +-
>   src/revname.h |    4 ++--
>   src/strbuf.h  |    2 +-
>   5 files changed, 11 insertions(+), 11 deletions(-)
>
>  diff --git a/src/deskman.h b/src/deskman.h
>  index bfd2e30..a7b560a 100644
>  --- a/src/deskman.h
>  +++ b/src/deskman.h
>  @@ -6,17 +6,17 @@
>    */
>   
>   void draw_desktop(void);
>  -void printnomem();
>  -void printipcerr();
>  +void printnomem(void);
>  +void printipcerr(void);
>   void printkeyhelp(char *keytext, char *desc, WINDOW * win,
>                     int highattr, int textattr);
>   void stdkeyhelp(WINDOW * win);
>   void sortkeyhelp(void);
>   void tabkeyhelp(WINDOW * win);
>  -void scrollkeyhelp();
>  -void stdexitkeyhelp();
>  +void scrollkeyhelp(void);
>  +void stdexitkeyhelp(void);
>   void indicate(char *message);
>   void printlargenum(unsigned long long i, WINDOW * win);
>   void infobox(char *text, char *prompt);
>   void standardcolors(int color);
>  -void show_sort_statwin();
>  +void show_sort_statwin(WINDOW **, PANEL **);
>  diff --git a/src/fltmgr.h b/src/fltmgr.h
>  index da20329..d3696f4 100644
>  --- a/src/fltmgr.h
>  +++ b/src/fltmgr.h
>  @@ -32,6 +32,6 @@ void get_filter_description(char *description, int *aborted,
>   void genname(unsigned long n, char *m);
>   unsigned long int nametoaddr(char *ascname, int *err);
>   void listfileerr(int code);
>  -int mark_filter_change();
>  -void clear_flt_tag();
>  +int mark_filter_change(void);
>  +void clear_flt_tag(void);
>   #endif
>  diff --git a/src/iptraf.c b/src/iptraf.c
>  index 3c1281a..ed75aef 100644
>  --- a/src/iptraf.c
>  +++ b/src/iptraf.c
>  @@ -60,7 +60,7 @@ char active_facility_countfile[64];
>   int accept_unsupported_interfaces = 0;
>   char graphing_filter[80];
>   
>  -extern void about();
>  +extern void about(void); 
about(void) function is pretty annoying and I'm going to remove it or
move it about() somewhere into menu. I haven't decided yet. Ideas are
more then welcome ;)

>   void press_enter_to_continue(void)
>   {
>  diff --git a/src/revname.h b/src/revname.h
>  index 04f52cf..a5c0243 100644
>  --- a/src/revname.h
>  +++ b/src/revname.h
>  @@ -4,8 +4,8 @@ revname.h - public declarations related to reverse name resolution
>   
>   ***/
>   
>  -int rvnamedactive();
>  -int killrvnamed();
>  +int rvnamedactive(void);
>  +int killrvnamed(void);
>   void open_rvn_socket(int *fd);
>   void close_rvn_socket(int fd);
>   
>  diff --git a/src/strbuf.h b/src/strbuf.h
>  index 48564b5..809164d 100644
>  --- a/src/strbuf.h
>  +++ b/src/strbuf.h
>  @@ -35,7 +35,7 @@ struct strbuf
>    * It never returns NULL. The returned pointer must be released by
>    * calling the function strbuf_free().
>    */
>  -struct strbuf *strbuf_new();
>  +struct strbuf *strbuf_new(void);
>   
>   /**
>    * Releases the memory held by the string buffer. 
Taken

-- 
Nikola