Bug report: window resize and ncursesw support

[Ricardo Catalinas Jiménez]

1. Using iptraf-ng 1.1.2 on Arch Linux x86_64, window resize seems
   broken. A segmentation fault happens when the terminal size changes.
   But probably you are aware of this bug :-/


2. Arch Linux uses ncurses compiled with wide character support by
   default but with symlinks from libncursesw.so to libncurses.so for
   compatibility. But only `ncursesw5-config' is installed. Would be
   great to improve configure.ac:

---8<-- configure.ac ---------------------------------------------------
dnl checks for libraries ncurses[5,6]
dnl removed ncursesw[5,6]; iptraf-ng does not use it
AC_CHECK_PROG([ncurses5_config], [ncurses5-config], [yes])
AC_CHECK_PROG([ncurses6_config], [ncurses6-config], [yes])

if test "x$ncurses6_config" = "xyes"; then
    libncurses_CFLAGS=$("ncurses6-config" --cflags)
    libncurses_LIBS=$("ncurses6-config" --libs)
elif test "x$ncurses5_config" = "xyes"; then
    libncurses_CFLAGS=$("ncurses5-config" --cflags)
    libncurses_LIBS=$("ncurses5-config" --libs)
else
    AC_MSG_ERROR([Install ncurses5-dev or ncurses6-dev])
fi
---8<-------------------------------------------------------------------

Basically, Arch Linux have only `ncursesw5-config' so check for its
presence and use it. So, could be possible to add?:

AC_CHECK_PROG([ncursesw5_config], [ncursesw5-config], [yes])
AC_CHECK_PROG([ncursesw6_config], [ncursesw6-config], [yes])

And adding the elif branches using it in the same way would suffice.

Just suggesting..., any feedback will be welcomed :-)


Best regards and thanks for such a great project!
-- 
Ricardo (http://r.untroubled.be/)

[Nikola Pajkovsky]

Ricardo Catalinas Jiménez <jimenezrick(a)gmail.com&gt; writes:

>  1. Using iptraf-ng 1.1.2 on Arch Linux x86_64, window resize seems
>     broken. A segmentation fault happens when the terminal size changes.
>     But probably you are aware of this bug :-/ 
I'm aware of this bug, but I cannot reproduce it on my machine. What
size are you using?

Could you please try patch

diff --git a/src/tui/winops.c b/src/tui/winops.c
index 139e8ce..a0c0e6b 100644
--- a/src/tui/winops.c
+++ b/src/tui/winops.c
@@ -31,16 +31,16 @@ void tx_colorwin(WINDOW * win)
 {
        int ctr;
        char *blankpad;
-       blankpad = (char *) malloc(sizeof(char) * (COLS + 1));
+       blankpad = (char *) xmalloc(sizeof(char) * (getmaxx(win) + 1));
 
        strcpy(blankpad, "");
 
-       for (ctr = 0; ctr <= getmaxx(win); ctr++) {
+       for (ctr = 0; ctr < getmaxx(win); ctr++) {
                strcat(blankpad, " ");
        }
 
        scrollok(win, 0);
-       for (ctr = 0; ctr <= getmaxy(win); ctr++) {
+       for (ctr = 0; ctr < getmaxy(win); ctr++) {
                wmove(win, ctr, 0);
                wprintw(win, "%s", blankpad);
        }


>  2. Arch Linux uses ncurses compiled with wide character support by
>     default but with symlinks from libncursesw.so to libncurses.so for
>     compatibility. But only `ncursesw5-config' is installed. Would be
>     great to improve configure.ac: 
we drop autotools and using only handmade Makefile. I'm going to prepare
patch for that. It will show up in next release.

>  Best regards and thanks for such a great project! 
you are welcome ;)

-- 
Nikola

[Vitezslav Samel]

On Mon, May 21, 2012 at 12:00:18PM +0200, Nikola Pajkovsky wrote:
>  Ricardo Catalinas Jiménez <jimenezrick(a)gmail.com&gt; writes:
>  
>  > 1. Using iptraf-ng 1.1.2 on Arch Linux x86_64, window resize seems
>  >    broken. A segmentation fault happens when the terminal size changes.
>  >    But probably you are aware of this bug :-/
>  
>  I'm aware of this bug, but I cannot reproduce it on my machine. What
>  size are you using? 
  For me it segfaults for these widths: 83, 91, 99, 107, 115, 123, ...

>  Could you please try patch 
  Yes, this one cures it.

Signed-off-by: Vitezslav Samel <vitezslav(a)samel.cz&gt;

>  diff --git a/src/tui/winops.c b/src/tui/winops.c
>  index 139e8ce..a0c0e6b 100644
>  --- a/src/tui/winops.c
>  +++ b/src/tui/winops.c
>  @@ -31,16 +31,16 @@ void tx_colorwin(WINDOW * win)
>   {
>          int ctr;
>          char *blankpad;
>  -       blankpad = (char *) malloc(sizeof(char) * (COLS + 1));
>  +       blankpad = (char *) xmalloc(sizeof(char) * (getmaxx(win) + 1));
>   
>          strcpy(blankpad, "");
>   
>  -       for (ctr = 0; ctr <= getmaxx(win); ctr++) {
>  +       for (ctr = 0; ctr < getmaxx(win); ctr++) {
>                  strcat(blankpad, " ");
>          }
>   
>          scrollok(win, 0);
>  -       for (ctr = 0; ctr <= getmaxy(win); ctr++) {
>  +       for (ctr = 0; ctr < getmaxy(win); ctr++) {
>                  wmove(win, ctr, 0);
>                  wprintw(win, "%s", blankpad);
>          } 
	Cheers,
		Vita

[Nikola Pajkovsky]

Vitezslav Samel <vitezslav(a)samel.cz&gt; writes:

>  On Mon, May 21, 2012 at 12:00:18PM +0200, Nikola Pajkovsky wrote:
> > Ricardo Catalinas Jiménez <jimenezrick(a)gmail.com&gt; writes:
> > 
> > > 1. Using iptraf-ng 1.1.2 on Arch Linux x86_64, window resize seems
> > >    broken. A segmentation fault happens when the terminal size changes.
> > >    But probably you are aware of this bug :-/
> > 
> > I'm aware of this bug, but I cannot reproduce it on my machine. What
> > size are you using?
>
>    For me it segfaults for these widths: 83, 91, 99, 107, 115, 123, ...
>
> > Could you please try patch
>
>    Yes, this one cures it.
>
>  Signed-off-by: Vitezslav Samel <vitezslav(a)samel.cz&gt; 
nice, applied.

-- 
Nikola