On 06/04/2015 10:19 AM, Noa Resare wrote:
First off I would like to say that I'm very impressed by the
effort you
have put into java packaging over the last few years. Getting a usable
environment for offline maven execution is no small feat.
Thank you.
One thing I noted, however, was that the unit tests for the guava
library
was not run on package build. Which seems like a reasonable compromise but
not ideal. I decided to look into what would be needed dependency wise for
that to happen, and I came up with the following:
* updates-testing needs to be activated for the auto-value dependency.
Buildroot overrides are useful in such cases. See:
https://fedoraproject.org/wiki/Bodhi/BuildRootOverrides
* packages truth, allocation-instrumenter and caliper needs to be
introduced. I have created those packages and built them with guidance from
the Java Packaging HOWTO
<
https://fedorahosted.org/released/javapackages/doc/>, the packages (SRPMS
and mock built noarch.rpms) are available from
https://resare.com/noa-fedora-playground/repo/22 but please beware of
newbie packaging mistakes :)
Great. We will review them once you submit review requests.
* With the dependencies handled I updated guava.spec to re-enable
guava-testlib and guava-tests. One test was consistently failing due to new
java8 behaviour, and I back ported a fix from guava master. The changes
needed can be viewed in my fork of
git://pkgs.fedoraproject.org/guava.git
at
https://github.com/nresare/fedora-guava in the testlib-tests branch. The
actual commit can be viewed here:
https://github.com/nresare/fedora-guava/commit/c1a8a831b1ef0ec91509fea806...
Overally it looks good. I've added a few comments at Github. I'll be
happy to merge this into Fedora once all dependencies are available in
rawhide.
I would love for my work to be of use in the fedora project and
I'm willing
to spend some time to land my contributions at this time. I will now read
up on what I need to to contribute more formally.
It's really good to see a new contributor. Don't hesitate to ask if you
have any questions or need help.
--
Mikolaj Izdebski
Software Engineer, Red Hat
IRC: mizdebsk