check-buildroot script and unpacked eclipse bundles

[alcapcom]

Hi *,

The build of eclipse packages that contain unpacked bundles seems to 
give problem when build with mock on rawhide. This error occur because 
check-buildroot script try to find the buildroot path in installed 
files. From what I understand of that script only *.jar.so.debug files 
are not checked in this case. The strange think is that the debuginfo 
package build with rpmbuild have the same .so.debug (unpacked eclipse 
bundles) that contain the buildroot too but the build finish with 
sucess. I have check if the check-buildroot script have been modified 
between F-7 and rawhide but the problem is not there. I would like to 
report that in bugzilla but I don't know witch package is incriminate.

Any idea guys?

Thanks
Alphonse

En of error.log file contain:
+ /usr/lib/rpm/check-buildroot
Binary file
/var/tmp/eclipse-rse-2.0.0.1-1.fc8-root-mockbuild/usr/lib/debug/usr/lib/gcj/eclipse-rse/org.eclipse.rse.services.dstore_2.0.0.200708141456.so.debug


matches
Binary file
/var/tmp/eclipse-rse-2.0.0.1-1.fc8-root-mockbuild/usr/lib/debug/usr/lib/gcj/eclipse-rse/org.eclipse.rse.services.telnet_1.0.0.200708141456.so.debug


matches
Binary file
/var/tmp/eclipse-rse-2.0.0.1-1.fc8-root-mockbuild/usr/lib/debug/usr/lib/gcj/eclipse-rse/org.eclipse.dstore.extra_2.0.0.200708141456.so.debug


matches
Binary file
/var/tmp/eclipse-rse-2.0.0.1-1.fc8-root-mockbuild/usr/lib/debug/usr/lib/gcj/eclipse-rse/org.eclipse.rse.services_2.0.0.200708141456.so.debug


matches
Binary file
/var/tmp/eclipse-rse-2.0.0.1-1.fc8-root-mockbuild/usr/lib/debug/usr/lib/gcj/eclipse-rse/org.eclipse.rse.services.files.ftp_2.0.0.200708141456.so.debug


matches
Found '/var/tmp/eclipse-rse-2.0.0.1-1.fc8-root-mockbuild' in installed
files; aborting

[alcapcom]

eclipse-rse review request: 
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=252223

[David Walluck]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Alphonse Van Assche wrote:
>  eclipse-rse review request: 
>  https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=252223 
Why do you hard-code the oro and commons-net versions in the spec file
instead of just using /usr/share/java/oro.jar and
/usr/share/java/commons-net.jar, respectively?

Even if they have to be versioned in the destination links, the source
links should not be versioned since it would force an unnecessary change
to the spec and a rebuild any time either oro or commons-net versions
are updated.

- --
Sincerely,

David Walluck
<david(a)zarb.org&gt;
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2.0.5 (GNU/Linux)
> Comment: Using GnuPG with Mandriva - http://enigmail.mozdev.org
>
> iD8DBQFGwrLqN5thZBYlTwkRAvPEAJ9BhbbzO+HvOsY1M8f5i554s+mndwCbBLxg
> qbDPjN/QHrrUwuandWbzu6k=
> =n/cN
> -----END PGP SIGNATURE-----

[alcapcom]

David Walluck a écrit :
>  Even if they have to be versioned in the destination links, the
> source
>  links should not be versioned since it would force an unnecessary change
>  to the spec and a rebuild any time either oro or commons-net versions
>  are updated. 
+1

The idea was that changes in both of these API can break some things 
without be warned but yes, these API should probably not change 
drastically in the future and there is many chance that new versions 
don't break anything. I modified the specfile according with that, thank 
you.

Alphonse

[Andrew Overholt]

Hi,

On Tue, 2007-08-14 at 21:47 +0200, Alphonse Van Assche wrote:
>  
>  The build of eclipse packages that contain unpacked bundles seems to 
>  give problem when build with mock on rawhide. This error occur because 
>  check-buildroot script try to find the buildroot path in installed 
>  files. 
Ben was working through a similar issue with the SDK AFAIK.  I don't
know if he finished it before he went on vacation the other day but
he'll be back on Monday so maybe he'll be able to help then.

>  From what I understand of that script only *.jar.so.debug files 
>  are not checked in this case.
>  [...]
>  En of error.log file contain:
>  + /usr/lib/rpm/check-buildroot
>  Binary file
>
> /var/tmp/eclipse-rse-2.0.0.1-1.fc8-root-mockbuild/usr/lib/debug/usr/lib/gcj/eclipse-rse/org.eclipse.rse.services.dstore_2.0.0.200708141456.so.debug
>  
You don't have BuildArch: noarch, do you?

Andrew

[alcapcom]

Andrew Overholt a écrit :
>  Hi, 
Hi,

>  Ben was working through a similar issue with the SDK AFAIK.  I
> don't
>  know if he finished it before he went on vacation the other day but
>  he'll be back on Monday so maybe he'll be able to help then. 
Thanks, I
should then wait that Ben is back from vacation to work on that.

>  You don't have BuildArch: noarch, do you? 
The package is
noarch only when it's build without gcj support, if the 
package is build as noarch, normally mock build should not fails (I have 
not test that)

Good week end guys,
Alphonse

[Benjamin Konrath]

On Fri, 2007-08-17 at 15:08 -0400, Andrew Overholt wrote:
>  Hi,
>  
>  On Tue, 2007-08-14 at 21:47 +0200, Alphonse Van Assche wrote:
>  > 
>  > The build of eclipse packages that contain unpacked bundles seems to 
>  > give problem when build with mock on rawhide. This error occur because 
>  > check-buildroot script try to find the buildroot path in installed 
>  > files.
>  
>  Ben was working through a similar issue with the SDK AFAIK.  I don't
>  know if he finished it before he went on vacation the other day but
>  he'll be back on Monday so maybe he'll be able to help then. 
The problem I had with the SDK package was that the build-id was not set
in the eclipse binary launcher so this is not the same problem. I
briefly looked into this but didn't find the problem. Sorry.

Ben

>  > From what I understand of that script only *.jar.so.debug files
>
>  > are not checked in this case.
>  > [...]
>  > En of error.log file contain:
>  > + /usr/lib/rpm/check-buildroot
>  > Binary file
>  >
> /var/tmp/eclipse-rse-2.0.0.1-1.fc8-root-mockbuild/usr/lib/debug/usr/lib/gcj/eclipse-rse/org.eclipse.rse.services.dstore_2.0.0.200708141456.so.debug
>
>  
>  You don't have BuildArch: noarch, do you?
>  
>  Andrew
>  --
>  fedora-devel-java-list mailing list
>  fedora-devel-java-list(a)redhat.com
>  https://www.redhat.com/mailman/listinfo/fedora-devel-java-list