java specfile reviewfest

[Andrew Overholt]

Hi,

Some of us have decided to get together on Monday 12 February to grind
through reviews for both the new packages required for maven2 and those
for the existing core packages.

It'd be great if people could help out with this.  We hang out on
#fedora-java on Freenode and will make a point of being there on Monday
all day.

Those of us meeting in the flesh are in EST but I hope that doesn't stop
others in different timezones from participating.

Deepak:  can you send out some URLs to the review requests.  Potentially
also that list we came up with for order of review?

Thanks,

Andrew

[Petteri Räty]

Andrew Overholt wrote:
> Hi,
>
> Some of us have decided to get together on Monday 12 February to grind
> through reviews for both the new packages required for maven2 and those
> for the existing core packages.

Do you have notes somewhere on how you are able to build maven2 or work
around it downloading dependencies from the network repository while
building? This has been a long time obstacle in packaging maven2 from
sources in Gentoo.

http://overlays.gentoo.org/proj/java/wiki/Maven_Notes

Regards,
Petteri

[Andrew Overholt]

* Petteri Räty  [2007-02-09 17:49]:
> Do you have notes somewhere on how you are able to build maven2 or work
> around it downloading dependencies from the network repository while
> building?

Deepak Bhole will be able to explain this.  Perhaps he'll have some time
this weekend to respond.  If not, check out the JPackage package of it -
that's what we'll be importing into Fedora.

Andrew

[Michael Koch]

On Fri, Feb 09, 2007 at 09:41:05PM -0500, Andrew Overholt wrote:
> Petteri Räty  [2007-02-09 17:49]:
> > Do you have notes somewhere on how you are able to build maven2 or work
> > around it downloading dependencies from the network repository while
> > building?
>
> Deepak Bhole will be able to explain this.  Perhaps he'll have some time
> this weekend to respond.  If not, check out the JPackage package of it -
> that's what we'll be importing into Fedora.

Good to know, I'm interested too. I will come to the irc session too.
Hopefully I get the time right this time....

Michael

[Petteri Räty]

Andrew Overholt wrote:
> Petteri Räty  [2007-02-09 17:49]:
> > Do you have notes somewhere on how you are able to build maven2 or work
> > around it downloading dependencies from the network repository while
> > building?
>
> Deepak Bhole will be able to explain this.  Perhaps he'll have some time
> this weekend to respond.  If not, check out the JPackage package of it -
> that's what we'll be importing into Fedora.
>
> Andrew

I found maven-1.0 in jpackage and took a quick look. At least that one
seemed to be faking a repository.

Regards,
Petteri

[David Walluck]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Petteri Räty wrote:
> I found maven-1.0 in jpackage and took a quick look. At least that one
> seemed to be faking a repository.

http://www.jpackage.org/cgi-bin/viewvc.cgi/rpms/free/maven2/?root=jpackage&a...

- --
Sincerely,

David Walluck
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.5 (GNU/Linux)
> Comment: Using GnuPG with Mandriva - http://enigmail.mozdev.org
>
> iD8DBQFFzaPaN5thZBYlTwkRAkJbAJwJnfABhkX1h+iMM+7IW2S34056UACfdNPm
> 7t8k3xkiqUHKR5WhxCV0tzw=
> =bRhm
> -----END PGP SIGNATURE-----

[Deepak Bhole]

On Sat, 2007-02-10 at 12:42 +0200, Petteri Räty wrote:
> Andrew Overholt wrote:
> > Petteri Räty  [2007-02-09 17:49]:
> > > Do you have notes somewhere on how you are able to build maven2 or work
> > > around it downloading dependencies from the network repository while
> > > building?
> >
> > Deepak Bhole will be able to explain this.  Perhaps he'll have some time
> > this weekend to respond.  If not, check out the JPackage package of it -
> > that's what we'll be importing into Fedora.
> >
> > Andrew
>
> I found maven-1.0 in jpackage and took a quick look. At least that one
> seemed to be faking a repository.

Hi Petteri,

Maven2 does does something similar. The JPackage (and soon to be in
Fedora) maven2 has code ammendments made to it to:

1) Allow complete offline behavior
2) Allow it to use /usr/share/java as a repository

A mapping subsystem is added to maven2 (via patches during rpmbuild)
that allows the user to tell maven2 where the jar is in /usr/share/java
based on the original groupid/artifactid.

All of the changes have been made such that they are optional i.e.
unless specific properties are defined at run time, maven2 will behave
exactly like upstream maven, bypassing all changes made by rpm patches.

Let me know if you need specific details on any of the changes.

Cheers,
Deepak
> Regards,
> Petteri

[Petteri Räty]

Deepak Bhole wrote:
> On Sat, 2007-02-10 at 12:42 +0200, Petteri Räty wrote:
> > Andrew Overholt wrote:
> > > Petteri Räty  [2007-02-09 17:49]:
> > > > Do you have notes somewhere on how you are able to build maven2 or work
> > > > around it downloading dependencies from the network repository while
> > > > building?
> > >
> > > Deepak Bhole will be able to explain this.  Perhaps he'll have some time
> > > this weekend to respond.  If not, check out the JPackage package of it -
> > > that's what we'll be importing into Fedora.
> > >
> > > Andrew
> >
> > I found maven-1.0 in jpackage and took a quick look. At least that one
> > seemed to be faking a repository.
>
> Hi Petteri,
>
> Maven2 does does something similar. The JPackage (and soon to be in
> Fedora) maven2 has code ammendments made to it to:
> Allow complete offline behavior
> Allow it to use /usr/share/java as a repository
>
> A mapping subsystem is added to maven2 (via patches during rpmbuild)
> that allows the user to tell maven2 where the jar is in /usr/share/java
> based on the original groupid/artifactid.
>
> All of the changes have been made such that they are optional i.e.
> unless specific properties are defined at run time, maven2 will behave
> exactly like upstream maven, bypassing all changes made by rpm patches.
>
> Let me know if you need specific details on any of the changes.
>
> Cheers,
> Deepak

Thanks. We should be able to do a similar integration between maven and
the way we package jars using that code as a template.

Regards,
Petteri

[Andrew Overholt]

Hi,

* Andrew Overholt  [2007-02-09 17:35]:
> Some of us have decided to get together on Monday 12 February to grind
> through reviews for both the new packages required for maven2 and those
> for the existing core packages.

The maven2 review requests are here:

https://bugzilla.redhat.com/bugzilla/buglist.cgi?short_desc_type=allwordssub...

Deepak made a graph of build dependencies and we think these ones can be
done without depending on something that isn't currently in core:

jtidy
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227075

gnu-regexp
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227057

bea-stax
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227041

xmldb-api
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227123

ant-contrib
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227027

dom2-core-tests
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227048

isorelax
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227061

relagxngDatatype
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227112

objectweb-anttask
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227091

tagsoup
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227117

classpathx-jaxp
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227046

icu4j
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199592

xpp2
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227126

xpp3
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227127

junitperf
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227077

piccolo
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227092

javassist
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227067

gnu-trove
(I can't find the review request for this one ... Rafael?  Deepak?)

jrexx
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227074

jflex
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227070

servletapi4
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227116

jython
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193898
This has already been approved but we need to investigate the inclusion
of python 2.2.  Is it just a BR?  If not, I'm concerned about shipping
another python version in the distro.  We're also not sure if it's
completely necessary ... supposedly batik needs it but we're hoping we
can avoid that dependency.

plexus-utils
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227106

dtdparser
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227050

emma
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227052

jakarta-commons-cli
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227063

nekohtml
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227090

jakarta-commons-io
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227064

maven2-common-poms (need to remove erroneous saxon BR)
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227079

Andrew

[Petteri Räty]

Andrew Overholt wrote:
> Hi,
>
> jython
> https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193898
> This has already been approved but we need to investigate the inclusion
> of python 2.2.  Is it just a BR?  If not, I'm concerned about shipping
> another python version in the distro.  We're also not sure if it's
> completely necessary ... supposedly batik needs it but we're hoping we
> can avoid that dependency.

This is probably useful:
http://dev.gentoo.org/~betelgeuse/jython-reverse-deps.txt

Regards,
Petteri

[Deepak Bhole]

On Sat, 2007-02-10 at 12:25 -0500, Andrew Overholt wrote:
> Hi,
> Andrew Overholt  [2007-02-09 17:35]:
> > Some of us have decided to get together on Monday 12 February to grind
> > through reviews for both the new packages required for maven2 and those
> > for the existing core packages.
>
> The maven2 review requests are here:
>
> https://bugzilla.redhat.com/bugzilla/buglist.cgi?short_desc_type=allwordssub...
>
> Deepak made a graph of build dependencies and we think these ones can be
> done without depending on something that isn't currently in core:

Thanks for sending the list Andrew.
> jtidy
> https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227075

<snip>
> gnu-trove
> (I can't find the review request for this one ... Rafael?  Deepak?)

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227058

That package is currently names gnu.trove in JPackage. A name change is
required to comply with Fedora guidelines. Fernando Nasser has already
made a comment there accordingly.

Cheers,
Deepak

[Deepak Bhole]

On Sat, 2007-02-10 at 12:25 -0500, Andrew Overholt wrote:
> Hi,
> Andrew Overholt  [2007-02-09 17:35]:
> > Some of us have decided to get together on Monday 12 February to grind
> > through reviews for both the new packages required for maven2 and those
> > for the existing core packages.
>
> The maven2 review requests are here:
>
> https://bugzilla.redhat.com/bugzilla/buglist.cgi?short_desc_type=allwordssub...
>
> Deepak made a graph of build dependencies and we think these ones can be
> done without depending on something that isn't currently in core:

Hi All,

I need all the built rpms for the packages mentioned in the parent
message. Those rpms are the level 1 dependencies and are needed to build
the rest of the stack. The next level is specified below. Items from
here on must be built in the specified order. As you build them, please
send me the built rpms.

ws-jaxme -- Taken. I am doing it.
checkstyle (Needs to be built between fop and jaxen -- I will take this)
asm -- Being done by Nuno.

-- Items below are up for grabs --

asm2
jarjar
saxon (needs to be built with a pre-built fop.jar (which needs nothing
at build-time))
xom
saxon8
msv
jaxon-bootstrap (needs to be ant-ified)
dom4j
xmlbeans (disable maven plugin)
rhino
httpunit
excalibur-avalon-logkit (needs conversion from maven)
byaccj
qdox (need to be built with jmock.jar initially)
aspectwerkz
cglib
jmock
excalibur-avalon-framework (needs conversion from maven)
batik (hack out jython dep)
fop
jaxen (can it be ant-ified?)
pmd
jline (needs maven2 for bootstrapping)
classworlds
plexus-container-default
plexus-archiver
plexus-velocity
jakarta-commons-net (needs ant-ification)
aspectj
plexus-interactivity
maven-wagon (spec shows more deps than graph!)
plexus-compiler
plexus-i18n
plexus-xmlrpc

--- Items below may *not* be in proper order. I will investigate these
    later today ---
plexus-appserver
modello (supposedly needs velocity and dtdparser which aren't in list)
--- these have circular deps with maven2 ---
plexus-cdc
plexus-runtime-builder
plexus-bsh-factory
plexus-ant-factory
maven-surefire (buildable with ant)
maven-shared
maven-jxr (buildable with ant)
maven-scm (buildable with ant)  
maven2
--- question marks ---
plexus-maven-plugin
maven-doxia

Deepak

[Andrew Overholt]

* Deepak Bhole  [2007-02-13 10:16]:
> I need all the built rpms for the packages mentioned in the parent
> message.

I've uploaded the ones I built here:

http://overholt.ca/fedora

Specifically:

isorelax:

http://www.overholt.ca/fedora/isorelax-0-0.1.release20050331.1jpp.1.noarch.r...
http://www.overholt.ca/fedora/isorelax-javadoc-0-0.1.release20050331.1jpp.1....

relaxngDatatype:

http://www.overholt.ca/fedora/relaxngDatatype-1.0-3jpp.1.noarch.rpm
http://www.overholt.ca/fedora/relaxngDatatype-javadoc-1.0-3jpp.1.noarch.rpm

Andrew

[Anthony Green]

On Tue, 2007-02-13 at 10:58 -0500, Andrew Overholt wrote:
> I've uploaded the ones I built here:
>
> http://overholt.ca/fedora

I was about to start looking at the java packages up for review when I
noticed that they all still have "jpp" in the name, which, from what I
recall, violates the Fedora package naming guidelines...

http://fedoraproject.org/wiki/PackagingDrafts/JavaPackageNaming

I've been removing "jpp" from the package name for packages I've moved
into FE (except for an early one, jakarta-commons-cli, which I'll clean
up for F7).  Did you guys discuss this when you started submitting these
packages?

AG

[Andrew Overholt]

CCing Fernando

* Anthony Green  [2007-02-20 09:34]:
> I was about to start looking at the java packages up for review

Ooh, please do :)  The status of the ones in the maven2 stack are here:

http://fedoraproject.org/wiki/JavaPackagingStatus

(the wiki page should probably be renamed)
> I've been removing "jpp" from the package name for packages I've moved
> into FE (except for an early one, jakarta-commons-cli, which I'll clean
> up for F7).  Did you guys discuss this when you started submitting these
> packages?

Apparently it's okay.  There was an exception proposed by spot and voted
in on fedora-packaging, I believe.  Fernando would know, though.

Andrew

[Deepak Bhole]

On Tue, 2007-02-20 at 06:33 -0800, Anthony Green wrote:
> On Tue, 2007-02-13 at 10:58 -0500, Andrew Overholt wrote:
> > I've uploaded the ones I built here:
> >
> > http://overholt.ca/fedora
>
> I was about to start looking at the java packages up for review when I
> noticed that they all still have "jpp" in the name, which, from what I
> recall, violates the Fedora package naming guidelines...
>
> http://fedoraproject.org/wiki/PackagingDrafts/JavaPackageNaming
>
> I've been removing "jpp" from the package name for packages I've moved
> into FE (except for an early one, jakarta-commons-cli, which I'll clean
> up for F7).  Did you guys discuss this when you started submitting these
> packages?

Actually, that is an older draft. Here is what we are supposed to
follow:

http://fedoraproject.org/wiki/Packaging/JPackagePolicy

Deepak
> AG

[Anthony Green]

On Tue, 2007-02-20 at 09:40 -0500, Deepak Bhole wrote:
> Actually, that is an older draft. Here is what we are supposed to
> follow:
>
> http://fedoraproject.org/wiki/Packaging/JPackagePolicy

That's great.  I've added a link to this policy page from the old draft
in the wiki.

Thanks,

AG

[Fernando Nasser]

Hi Anthony,

Anthony Green wrote:
> On Tue, 2007-02-13 at 10:58 -0500, Andrew Overholt wrote:
> > I've uploaded the ones I built here:
> >
> > http://overholt.ca/fedora
>
> I was about to start looking at the java packages up for review when I
> noticed that they all still have "jpp" in the name, which, from what I
> recall, violates the Fedora package naming guidelines...
>
> http://fedoraproject.org/wiki/PackagingDrafts/JavaPackageNaming
>
> I've been removing "jpp" from the package name for packages I've moved
> into FE (except for an early one, jakarta-commons-cli, which I'll clean
> up for F7).  Did you guys discuss this when you started submitting these
> packages?

Actually, _now_ they are in violation of the guidelines :-)

(they will indeed be removed when the new rpm with Categories are in and 
yum is changed accordingly).

Will you guys be able to add it back?

Cheers,
Fernando

[Petteri Räty]

Deepak Bhole wrote:
> pmd
> jline (needs maven2 for bootstrapping)
> classworlds

A trick the Gentoo people have been using is to use maven-ant-plugin to
generate build.xml files for things like jline. Hope this helps.

Regards,
Petteri

[Thomas Fitzsimmons]

Deepak Bhole wrote:
> On Sat, 2007-02-10 at 12:25 -0500, Andrew Overholt wrote:
> > Hi,
> > Andrew Overholt  [2007-02-09 17:35]:
> > > Some of us have decided to get together on Monday 12 February to grind
> > > through reviews for both the new packages required for maven2 and those
> > > for the existing core packages.
> >
> > The maven2 review requests are here:
> >
> > https://bugzilla.redhat.com/bugzilla/buglist.cgi?short_desc_type=allwordssub...
> >
> > Deepak made a graph of build dependencies and we think these ones can be
> > done without depending on something that isn't currently in core:
>
> Hi All,
>
> I need all the built rpms for the packages mentioned in the parent
> message. Those rpms are the level 1 dependencies and are needed to build
> the rest of the stack. The next level is specified below. Items from
> here on must be built in the specified order. As you build them, please
> send me the built rpms.

The built rpms should be produced by mock since that will give us the closest 
approximation to what will be built into Fedora.  We don't want to risk testing 
invalid packages as dependencies of these level 2 packages, and then have the 
builds fail in the pristine environment mock sets up.

Tom