Failed eclipse-findbugs noarch build due to use of %{_libdir}

[Richard Fearn]

Hi,

I tried to build eclipse-findbugs (a noarch package) in rawhide yesterday
but the build failed:

http://koji.fedoraproject.org/koji/buildinfo?buildID=483577

Here's the spec file:

http://pkgs.fedoraproject.org/cgit/eclipse-findbugs.git/tree/eclipse-findbug...

The spec file passes a few locations to ant based on %{eclipse_base}, which
is defined like this:

%global eclipse_base %{_libdir}/eclipse

I guess I've been lucky up to now because eclipse-findbugs has always built
on a 32-bit builder. Yesterday it built on a 64-bit builder where
%{_libdir} is /usr/lib, but Eclipse is installed under /usr/lib64.

I found a few tickets discussing this:

https://bugzilla.redhat.com/show_bug.cgi?id=808983
  https://bugzilla.redhat.com/show_bug.cgi?id=847130
  https://fedorahosted.org/fpc/ticket/203

which imply %{eclipse_base} shouldn't be used.

What's the correct way to build this plugin?

Thanks,

Richard

[Gerard Ryan]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

- -----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On Mon, Dec 09, 2013 at 01:49:42PM +0000, Richard Fearn wrote:
> Hi,
>
> I tried to build eclipse-findbugs (a noarch package) in rawhide yesterday
> but the build failed:
>
> http://koji.fedoraproject.org/koji/buildinfo?buildID=483577
>
> Here's the spec file:
>
> http://pkgs.fedoraproject.org/cgit/eclipse-findbugs.git/tree/eclipse-findbug...
>
> The spec file passes a few locations to ant based on %{eclipse_base}, which
> is defined like this:
>
> %global eclipse_base %{_libdir}/eclipse
>
> I guess I've been lucky up to now because eclipse-findbugs has always built
> on a 32-bit builder. Yesterday it built on a 64-bit builder where
> %{_libdir} is /usr/lib, but Eclipse is installed under /usr/lib64.
>
> I found a few tickets discussing this:
>
> https://bugzilla.redhat.com/show_bug.cgi?id=808983
>  https://bugzilla.redhat.com/show_bug.cgi?id=847130
>  https://fedorahosted.org/fpc/ticket/203
>
> which imply %{eclipse_base} shouldn't be used.
>
> What's the correct way to build this plugin?
>
> Thanks,
>
> Richard

Hi Richard,

I'm not sure if this is a recommended way (someone with more
experience that I may be able to comment on that), but if you look at
the eclipse-wtp-common spec file[1] at line 65, I've added something
to determine whether to use /usr/lib/ or /usr/lib64/ for some ugly
stuff that needs to know where a platform jar is.

Looking at the eclipse-findbugs package though, is there any reason
that it's not being updated to 2.0.3? I just had a look into the
source tarball for 2.0.3 and there's a pom file which suggests that it
would be buildable with maven. I think this might avoid the issue
you're currently having, if it's a possibility.

[1] http://pkgs.fedoraproject.org/cgit/eclipse-wtp-common.git/tree/eclipse-wtp-c...

Hope this helps,
Gerard.
> - -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.15 (GNU/Linux)
>
> iQIcBAEBCAAGBQJSqNNDAAoJEG7cfkpivEoV5tkP/i9iYnCjsjXWVCk4hl3Kjav3
> 9Dh12S771QabeHNqNAgDSK1521JYpfI7eXh6vbH3XFcbU55XrM1m193apGQUePiM
> 5KDTOT+0Lgj8FkN4QvnuXneeiRzDIn6hsS6+LS0Jbh2tOP/h5jXl3b4GHnZ1rKkj
> VmDqB3hEr/AJlvH1/6jGvhU41TfKzC8xgTuIrNYVg4AeqowdOavW/FK19N2SCUu/
> N9EmLZ9Vh0QIOSQUmQN42YpGngPIzM9hhgZ6JUbt4GFDU+3TDalVjNIJBLoksOhF
> PSDe0R7C9CS6FM9iTcQvJWumr4JWrD8LkPhtvntHz82da+lL29xUzYRTOXOtG4zP
> LyLetPxaU6rea/fDNeYDOXHRJE6DemP0Ds1C4grTco8RH0jE/+aHmK72HMwAxWHs
> 6e+pnashMjH9coC+AIVfIHvqCOFBDDKFIHN41yklFzImN+XTnPO/Op5D0XPgVZa8
> I8jTTbuo/8b3qhm3HNOd0+Pg5omrT0VZyw/d3dp/WsUNIao+lVlTmIPHYo/ran/c
> YUn9CPse5FHxeZWLjndUNW5yTjT6pwTI+Em293A4xfRilFAZvqItqMP374k9Q2aO
> LffX6nPigzfz3eCPBwuAv1gRE5UDFlftjtcp5qWz1wp5c8ZXaSw1yIVmujTsCVMO
> XLfeFKjjTdAsUV8P5VWt
> =xJyr
> - -----END PGP SIGNATURE-----
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.15 (GNU/Linux)
>
> iQIcBAEBCAAGBQJSqNNgAAoJEG7cfkpivEoVAhgP/RsP7Cquhd7s14B857556P68
> KMNNfJLvVmkQekyDdaCGuof+gMFlK6ft1gH+4jrHDfWyvKOytCk4f6n46FmiK7oH
> 7zcBn0DTUaHr1B0nb0kwReMhuOyL9rC3/7NxmCsKGVUidEaS6q3LdpPD7MPOtf6a
> kK5Rf6tHKgvUd3COMKM2nrMyz9O2o2ZFzPVidFY4rls5ASmSmIkOf4UX5rgnaIHe
> 16AoNHFZr7Bmm+nD9TrpbfVkuVtFfA2lqViWY/LcHYkE0CgWYhaQXRVUGvniHmos
> PVupQMiwWFR2uTw9amSTclRRbtVZxrGW0ngfHH1a1hF4pO1NoTp+spGNgBDfOLij
> DMz4R0lhE2eWKhaVB1sx36HgwJsN2vbpkYNkA2YoncN1SHfa6tV306TlpkSe67v0
> oNt11nhfWBNo/P3vB0Ena4a4whzmvTSTLKC3inJMqX5B7wKq1nTZxzKbo5TJkHBM
> XdXjRpstb1DiD34lxZDLku1apCXsF2HrBNoxV7nLV10ApTQ4oTGqdizcquPlMtWj
> JkyxtGxFrT3Lm1C9HOiBeGHXFn9l2Z7p8sJCfFB2o9m2gPHd6qItBLCQv+xrMv7j
> 0xiiEqldrnxTvOYzCmQQC+3vQlZ+FGR7+YPyhi1WTB9r9ptLdAbndMbhAIyBORts
> xdmRFtZETG7UcPqNdaww
> =5J8y
> -----END PGP SIGNATURE-----

[Krzysztof Daniel]

Hey Richard,

Thanks for bringing this issue.

This issue was causing a lot of problems in the Eclipse stack,
as majority of eclipse noarch plugins required arch-specific Eclipse
during the build.

We solved this by moving the eclipse-pdebuild script to /bin/, setting
the path at *Eclipse* buildtime to Eclipse, and symlinking some jars
to /usr/share/java.

You can find the correct location of Eclipse by calling
more /bin/eclipse-pdebuild | grep "datadir="
This is quick, dirty and hackish, but will work.

Another solution is described in https://fedorahosted.org/fpc/ticket/203
comment 18:
"noarch packages may use %configure (which uses %{_libdir} to set the
--libdir value)".

I have never seen this in use, but I expect that once you have a
configure script in your package, it should be able to find the value of
libdir. What could for is following configure script:

--
echo ${libdir} > .libdir
--
And then a macro for accessing the libdir
%define __eclipse_libdir `echo .libdir`/eclipse

Hope that helps.

[Richard Fearn]

Thanks Gerard and Krzysztof! I'll look into your suggestions over the
next few days.

Regards,

Richard