https://bugzilla.redhat.com/show_bug.cgi?id=1033664
Bug ID: 1033664 Summary: tomcat-juli.jar isn't resolved by xmvn-subst Product: Fedora Version: rawhide Component: tomcat Assignee: ivan.afonichev@gmail.com Reporter: rrati@redhat.com QA Contact: extras-qa@fedoraproject.org CC: akurtako@redhat.com, ivan.afonichev@gmail.com, java-sig-commits@lists.fedoraproject.org, kdaniel@redhat.com
Description of problem: The tomcat-juli.jar isn't resolved by xmvn-subst. The jar resides in _datadir/tomcat/bin but is symlinked to from _javadir/tomcat. The other tomcat jars are properly resolved, so I'd guess the tomcat-juli.jar is missing the metadata for resolution or is overwritten in the tomcat packaging.
Version-Release number of selected component (if applicable):
How reproducible:
Steps to Reproduce: 1. 2. 3.
Actual results:
Expected results:
Additional info:
https://bugzilla.redhat.com/show_bug.cgi?id=1033664
Stanislav Ochotnicky sochotni@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |sochotni@redhat.com
--- Comment #1 from Stanislav Ochotnicky sochotni@redhat.com --- I'll explain a bit more perhaps: some time ago %add_maven_depmap has been modified to inject Maven metadata into the jar itself. This way xmvn-subst can then replace jars with symlinks even if the package hasn't been built with Maven.
Other tomcat jars have META-INF/maven/org.apache.tomcat/XXX/pom.properties file injected. juli doesn't (for some reason). It's possible some file juggling in the spec can overwrite the file with injected pom.properties?
https://bugzilla.redhat.com/show_bug.cgi?id=1033664
Mikolaj Izdebski mizdebsk@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |MODIFIED Fixed In Version| |7.0.47-2 Assignee|ivan.afonichev@gmail.com |mizdebsk@redhat.com
--- Comment #2 from Mikolaj Izdebski mizdebsk@redhat.com --- Fixed in tomcat-7.0.47-2
https://bugzilla.redhat.com/show_bug.cgi?id=1033664
Mikolaj Izdebski mizdebsk@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ASSIGNED Fixed In Version|7.0.47-2 |
--- Comment #3 from Mikolaj Izdebski mizdebsk@redhat.com --- Rebuilding the package didn't fix the problem.
It turns out that JAR which was used during call to %add_maven_depmap is being replaced with a symnlink. The first JAR with injected pom.properties is lost.
%global libdir %{_javadir}/%{name} ... %add_maven_depmap JPP.%{name}-tomcat-juli.pom %{name}/tomcat-juli.jar ... # replace temporary copy with link %{__ln_s} -f %{bindir}/tomcat-juli.jar ${RPM_BUILD_ROOT}%{libdir}/
https://bugzilla.redhat.com/show_bug.cgi?id=1033664
Mikolaj Izdebski mizdebsk@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED Fixed In Version| |7.0.47-3
--- Comment #4 from Mikolaj Izdebski mizdebsk@redhat.com --- Commited the fix.
Verification:
$ rpm -q tomcat-lib tomcat-lib-7.0.47-2.fc21.noarch $ xmvn-subst tomcat-juli.jar [main] INFO org.fedoraproject.xmvn.tools.subst.ArtifactVisitor - Skipping file tomcat-juli.jar: No artifact definition found
$ rpm -q tomcat-lib tomcat-lib-7.0.47-3.fc21.noarch $ xmvn-subst tomcat-juli.jar [main] INFO org.fedoraproject.xmvn.tools.subst.ArtifactVisitor - Linked tomcat-juli.jar to /usr/share/java/tomcat/tomcat-juli.jar $ readlink -f tomcat-juli.jar /usr/share/tomcat/bin/tomcat-juli.jar
https://bugzilla.redhat.com/show_bug.cgi?id=1033664
Mikolaj Izdebski mizdebsk@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |RAWHIDE Last Closed| |2014-01-21 09:32:11
--- Comment #5 from Mikolaj Izdebski mizdebsk@redhat.com --- I believe that this bug is fixed in tomcat-7.0.47-3, which is available in Fedora Rawhide, so I am closing this bug now.
The build containing the fix can be found at Koji: http://koji.fedoraproject.org/koji/buildinfo?buildID=492693
java-sig-commits@lists.fedoraproject.org