https://bugzilla.redhat.com/show_bug.cgi?id=1271243
Bug ID: 1271243 Summary: groovy-lib has unnecessary requires Product: Fedora Version: rawhide Component: groovy Assignee: msrb@redhat.com Reporter: msimacek@redhat.com QA Contact: extras-qa@fedoraproject.org CC: java-sig-commits@lists.fedoraproject.org, mizdebsk@redhat.com, msrb@redhat.com
Description of problem: I think the groovy-lib subpackage was introduced to allow packages that use groovy as embedded language to depend on it without pulling in a ton of dependencies. But as of now, groovy-lib still pulls in ant, junit, testng etc., which I believe are not needed (are optional).
Version-Release number of selected component (if applicable): groovy-lib-0:2.4.5-1.fc24.noarch
How reproducible: always
Steps to Reproduce: 1. repoquery --requires groovy-lib
Actual results: java-headless jpackage-utils mvn(bsf:bsf) mvn(com.beust:jcommander) mvn(com.thoughtworks.qdox:qdox) mvn(commons-logging:commons-logging) mvn(jline:jline) mvn(junit:junit) mvn(org.apache.ant:ant) mvn(org.apache.ant:ant-antlr) mvn(org.apache.ant:ant-junit) mvn(org.apache.ant:ant-launcher) mvn(org.testng:testng)
Expected results: no requires on ant, junit, etc.
Additional info: On the other hand, I'd expect objectweb-asm to be among requires, as that is what groovy uses internally, isn't it?
https://bugzilla.redhat.com/show_bug.cgi?id=1271243
--- Comment #1 from Michal Srb msrb@redhat.com --- AFAIK the requires are correct. Groovy 2.x comes with artifacts like org.codehaus.groovy:groovy-testng (which pulls in testng), or org.codehaus.groovy:groovy-test (which pulls in junit). testng and junit deps are not optional in those cases. Those artifacts didn't exist in 1.8.x and therefore having singe -lib subpackage was enough. It would make sense to put each artifact into separate subpackage in case of Groovy 2.x. objectweb-asm seems to be jarjar-ed inside org.codehaus.groovy:groovy (and groovy-all), so we should probably unbundle it, or add bundled(objectweb-asm) provides.
https://bugzilla.redhat.com/show_bug.cgi?id=1271243
--- Comment #3 from Michael Simacek msimacek@redhat.com --- Created attachment 1144609 --> https://bugzilla.redhat.com/attachment.cgi?id=1144609&action=edit Split into subpackages
https://bugzilla.redhat.com/show_bug.cgi?id=1271243
Michael Simacek msimacek@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |MODIFIED Fixed In Version| |groovy-2.4.5-8.fc25 Assignee|msrb@redhat.com |msimacek@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1271243
Michael Simacek msimacek@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |RAWHIDE Last Closed| |2016-04-07 05:05:55
java-sig-commits@lists.fedoraproject.org