On Wed, 2009-03-11 at 11:55 -0400, Kyle McMartin wrote:
On Wed, Mar 11, 2009 at 11:33:25AM -0400, Josh Boyer wrote:
> >+#if __OS_HAS_AGP
>
> Not that this is your fault, but shouldn't this be something
> like __ARCH_HAS_AGP?
>
Keep in mind the DRM for better or for worse supposedly supports more
OSes than just Linux.
I suspect the 'ideal' fix for upstream is to stub out drm_agp_init_ttm
on !CONFIG_AGP arches.
OS_HAS_AGP is just a wrapper around convoluted CONFIG_AGP,
CONFIG_AGP_MODULE.
Its perfectly acceptable to build a kernel with no AGP and DRM enabled
on x86.
Dave.
regards, Kyle