On Wed, Sep 2, 2020 at 4:08 PM Hans de Goede <hdegoede(a)redhat.com> wrote:
Hi All,
5.8 introduces a new CONFIG_USB_XHCI_PCI_RENESAS Kconfig symbol.
The current Fedora kernel config says this to 'm'. I assume that
this was done because the help-text suggests that doing so will
make support for some special XHCI controllers which need to
be "booted" (have firmware loaded) by the kernel modular, while
keeping the generic xhci-pci code builtin so that we start probing
XHCI USB busses ASAP during boot.
But, and this is somewhat of a surprise, the xhci-pci-renesas
code does not use the xhci-pci code as a library on top of
which it builds. Instead it offers some hooks for the xhci-pci
code to call in and having CONFIG_USB_XHCI_PCI_RENESAS set will
thus make xhci-pci.ko depend on xhci-pci-renesas.ko.
Which means that if xhci-pci-renesas.ko is not builtin, this
also forces xhci-pci.ko to not be builtin.
As said I assume that this xhci-pci.ko no longer being builtin
is not intentional, so that the right way to fix this would
be to set CONFIG_USB_XHCI_PCI_RENESAS=y, right ?
We don't need to enable CONFIG_USB_XHCI_PCI_RENESAS because we don't
enable ARCH_RENESAS, if that controller has some weirdisms upstream
likely should have made it something like "default y if ARCH_RENESAS"
or similar.
> This problem is leading to some people not being able to
> enter their disk passwords, see:
>
>
https://bugzilla.redhat.com/show_bug.cgi?id=1874300
>
> Regards,
>
> Hans
> _______________________________________________
> kernel mailing list -- kernel(a)lists.fedoraproject.org
> To unsubscribe send an email to kernel-leave(a)lists.fedoraproject.org
> Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines:
https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives:
https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org