From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1779#note_9458776...
which variables directly affected the SPEC file and which were used for
other reasons in the Makefile.
But is that relevant for people that do anything with kernel-ark or only
useful to make the Makefiles more readable? If it's just the latter I'd say it's more confusing then helpful.
I'd argue it's to make the Makefile more readable and easier for us to debug. But I would disagree with the confusing statement. The variables that users can use are defined in redhat/Makefile.variables (see rest of my answer below)
This got me thinking: the document added by this patch afaics doesn't even
tell me what I can do with the variable names I just learned from that text. Or am I missing something?
redhat/docs/makefile-changes.rst already exists and explains the layout. I think that is sufficient but since documentation can ALWAYS be improved patches are definitely welcomed :)
I assume I can pass them to make (say `make dist-srpm BUILD=123` ?), but
shouldn't the text explain this?
Maybe adding something like "Variables in this file can be overridden on the command line." to the Makefile.variables section with your example?