Re: kernel.spec: drop superfluous call of headers_check
On Tue, Jan 14, 2014 at 4:48 AM, Paul Bolle <pebolle(a)tiscali.nl> wrote:
Josh,
Here's a possible cleanup of kernel.spec. It also addresses one of my
pet peeves: headers_check is run twice when building the kernel rpms.
See, CONFIG_HEADERS_CHECK is already set to "y" in config-generic. But
there are also a few lines in kernel.spec where headers_check is invoked
again. And, as far as I can see
grep -q exist hdrwarnings.txt
will never match. Perhaps it made sense to grep for exist in the past, I
don't know. Or was it intended to grep for an error message? But errors
are not directed to hdrwarnings.txt.
Yeah, looks correct to me. I've added it locally with a slightly
fixed up commit message and if it passes build tests I'll go with it.
Thanks!
josh