On Tue, Apr 1, 2014 at 1:45 PM, Paul Bolle <pebolle(a)tiscali.nl> wrote:
On Tue, 2014-04-01 at 12:50 -0400, Josh Boyer wrote:
> --- /dev/null
> +++ b/filter-aarch64.sh
> @@ -0,0 +1,5 @@
> +#! /bin/bash
> +
> +driverdirs="atm auxdisplay bcma bluetooth fmc infiniband isdn leds
> media memstick message mmc mtd nfc ntb pcmcia platform power ssb
> staging uio uwb"
> +
> +singlemods="ntb_netdev iscsi_ibft iscsi_boot_sysfs iscsi_tcp megaraid
> pmcraid qla1280 9pnet_rdma svcrdma xprtrdma hid-picolcd hid-prodikeys
> hwa-hc hwpoison-inject "
Another attempt at reviewing: why is this not sorted alphabetically?
Because I built the list as things depsolved or didn't. There's no
main reason it couldn't be alphabetized. I don't immediately see any
benefits of doing so, but it's easy enough to change.
And wouldn't this be easier to maintain if this was split into
two plain
text files (per arch) with one name per line?
I don't think so. Why 2 files per arch? The filter-<arch> files are
overrides for the settings in filter-modules.sh. Unless there's a
need to override, they are fairly small already.
One name per line could be done I guess but I don't see it being more
or less maintainable.
josh