On Fri, Nov 13, 2020 at 09:11:36PM -0000, GitLab Bridge on behalf of bcrocker wrote:
From: bcrocker on gitlab.com
Add a GIT macro to Makefile:
GIT ?= git
and replace literal occurrences of 'git' with $(GIT)\ in Makefile and Makefile.common.
This change enables us to override 'git' with, e.g., some\ arbitrary shell script that prints additional information\ and/or does additional processing before and/or after (or\ even instead of) invoking /usr/bin/git.
Hi Ben,
Is there anyway you can combine parts of patch 4 and 5 into patch 3? It seems odd to see the history of the code in the patches like that.
Also you mentioned the rpmlint and rpminspect are not successful on invocation, but they still seemed wired up to make dist-self-tests. I would like to make sure 'make dist-self-tests' is always successful.
You can keep the rpmlint and rpminspect code in there, just disable it and put a comment that there is work to do before it passes and can be re-enabled.
Thoughts?
Cheers, Don