On 08/09/2016 03:34 AM, Nicolas Chauvet wrote:
2016-08-08 16:58 GMT+02:00 Laura Abbott <labbott(a)redhat.com>:
> On 08/08/2016 01:39 AM, Thorsten Leemhuis wrote:
>> Lo! Mr. Aappddeevv wrote on 08.08.2016 03:47:
>>> I am encountering compile errors building off master. My build system
>>> is f24. Any thoughts? I did some google searches but could not find
>>> anyone else that had the same problem.
>>> One of the errors is below:
>>> pushd tools/iio/
>>> + make
>>> make: Entering directory
>>> gcc -Wall -g -D_GNU_SOURCE -c -o iio_event_monitor.o
>>> iio_event_monitor.c:58:3: error: 'IIO_PH' undeclared here (not in a
>>> [IIO_PH] = "ph",
>> I ran into this issue when building 4.8-pre for F23 and F24
). If you
>> want to just circumvent this problem install the kernel-headers package
>> from at least 4.7 (from my repos or the kernel-stabilization repo) in
>> your build environment. Those headers contain everything that is needed
>> to compile the iio tools from 4.8-pre. I haven't reported the problem
>> upstream yet (-ELACKOFTIME) :-/
>> CU, thl
> Yes, installing the new headers is the correct solution. Several of
> the #defines for the IIO tools came in for 4.7. Since this is a
It would be better for the userspace tools to use the headers from the
kernel source tree instead of those from the "previous" kernel-headers
This will lead to a bootstraping issue if that's not the case. Or is
there any reason why it's must use system installed headers ?
The tools aren't necessary for building the kernel itself so I don't
think there is a bootstrapping issue in the upstream project. I see
your point though and other userspace tools do use the kernel headers.
You're welcome to bring this up with the upstream maintainers and/or
submit a patch. If the patch gets acked we can bring it in.