On Thu, May 1, 2014 at 8:51 AM, Hans de Goede jwrdegoede@fedoraproject.org wrote:
commit f22ebd0b2b7a7d5d07367c5c50f81185b9fa672b Author: Hans de Goede hdegoede@redhat.com Date: Thu May 1 14:51:32 2014 +0200
Add use_native_backlight quirk for 4 laptops (rhbz 983342 1093120)
...Add-4-new-models-to-the-use_native_backli.patch | 89 ++++++++++++++++++++ kernel.spec | 9 ++ 2 files changed, 98 insertions(+), 0 deletions(-)
Hi Hans,
In the future, could you please refrain from committing patches like this directly without any heads up or discussion? A quick post to this list with a link to the upstream submission is ideal.
I really appreciate the effort your putting in on the backlight stuff here, but this patch was committed before it was even reviewed upstream. The previous incarnation of it was rejected because a supposed fix is coming in 3.16. It's certainly reasonable for Fedora to carry this until 3.16 lands, but I'd like it if we can get some agreement from upstream one way or another. There's no major rush at this point, particularly for rawhide.
Thanks.
josh
Hi Josh,
On 05/01/2014 03:25 PM, Josh Boyer wrote:
On Thu, May 1, 2014 at 8:51 AM, Hans de Goede jwrdegoede@fedoraproject.org wrote:
commit f22ebd0b2b7a7d5d07367c5c50f81185b9fa672b Author: Hans de Goede hdegoede@redhat.com Date: Thu May 1 14:51:32 2014 +0200
Add use_native_backlight quirk for 4 laptops (rhbz 983342 1093120)
...Add-4-new-models-to-the-use_native_backli.patch | 89 ++++++++++++++++++++ kernel.spec | 9 ++ 2 files changed, 98 insertions(+), 0 deletions(-)
Hi Hans,
In the future, could you please refrain from committing patches like this directly without any heads up or discussion? A quick post to this list with a link to the upstream submission is ideal.
Sure, I'll send a message to the list next time I'm adding something which is still up for upstream discussion.
Regards,
Hans
kernel@lists.fedoraproject.org