new utrace patch breaks ia64

[Doug Chapman]

Roland,

The latest incarnation of the utrace patch breaks the kernel build on
ia64:

arch/ia64/kernel/process.c: In function 'do_notify_resume_user':
arch/ia64/kernel/process.c:189: error: implicit declaration of function 'tracehook_notify_resume'

Full build log can be found here:
http://ia64.koji.fedoraproject.org/koji/getfile?taskID=94725&name=build....

- Doug

[Kyle McMartin]

On Mon, Jul 14, 2008 at 01:16:08PM -0400, Doug Chapman wrote:
> Roland,
>
> The latest incarnation of the utrace patch breaks the kernel build on
> ia64:
>
> arch/ia64/kernel/process.c: In function 'do_notify_resume_user':
> arch/ia64/kernel/process.c:189: error: implicit declaration of function 'tracehook_notify_resume'
>
> Full build log can be found here:
> http://ia64.koji.fedoraproject.org/koji/getfile?taskID=94725&name=build....

Looks like all it needs is an #include <linux/utrace.h> in process.c.

regards, Kyle

[Doug Chapman]

On Mon, 2008-07-14 at 13:16 -0400, Doug Chapman wrote:
> Roland,
>
> The latest incarnation of the utrace patch breaks the kernel build on
> ia64:
>
> arch/ia64/kernel/process.c: In function 'do_notify_resume_user':
> arch/ia64/kernel/process.c:189: error: implicit declaration of function 'tracehook_notify_resume'
>
> Full build log can be found here:
> http://ia64.koji.fedoraproject.org/koji/getfile?taskID=94725&name=build....
> Doug

Roland,

Simple patch, just missing an #include it appears.  Can you add this to
your utrace patches?

thanks,

- Doug

diff -up linux-2.6.26.ia64/arch/ia64/kernel/process.c.broken linux-2.6.26.ia64/arch/ia64/kernel/process.c
--- linux-2.6.26.ia64/arch/ia64/kernel/process.c.broken	2008-07-14 13:20:43.000000000 -0400
+++ linux-2.6.26.ia64/arch/ia64/kernel/process.c	2008-07-14 13:21:01.000000000 -0400
@@ -22,6 +22,7 @@
 #include <linux/slab.h>
 #include <linux/stddef.h>
 #include <linux/thread_info.h>
+#include <linux/tracehook.h>
 #include <linux/unistd.h>
 #include <linux/efi.h>
 #include <linux/interrupt.h>

[Doug Chapman]

On Mon, 2008-07-14 at 13:28 -0400, Doug Chapman wrote:
> On Mon, 2008-07-14 at 13:16 -0400, Doug Chapman wrote:
> > Roland,
> >
> > The latest incarnation of the utrace patch breaks the kernel build on
> > ia64:
> >
> > arch/ia64/kernel/process.c: In function 'do_notify_resume_user':
> > arch/ia64/kernel/process.c:189: error: implicit declaration of function 'tracehook_notify_resume'
> >
> > Full build log can be found here:
> > http://ia64.koji.fedoraproject.org/koji/getfile?taskID=94725&name=build....
> > Doug
>
> Roland,
>
> Simple patch, just missing an #include it appears.  Can you add this to
> your utrace patches?
>
> thanks,
> Doug
>
> diff -up linux-2.6.26.ia64/arch/ia64/kernel/process.c.broken linux-2.6.26.ia64/arch/ia64/kernel/process.c
> --- linux-2.6.26.ia64/arch/ia64/kernel/process.c.broken	2008-07-14 13:20:43.000000000 -0400
> +++ linux-2.6.26.ia64/arch/ia64/kernel/process.c	2008-07-14 13:21:01.000000000 -0400
> @@ -22,6 +22,7 @@
>  #include <linux/slab.h>
>  #include <linux/stddef.h>
>  #include <linux/thread_info.h>
> +#include <linux/tracehook.h>
>  #include <linux/unistd.h>
>  #include <linux/efi.h>
>  #include <linux/interrupt.h>

Actually, this only gets me so far.  Looks like there is stuff included
in the utrace patches that is missing for ia64.  There is a new
"syscall.h" that was added for the other arches but not for ia64.

Can we disable this patchset on ia64 in fedora until this is complete?

thanks,

- Doug

[Dave Jones]

On Mon, Jul 14, 2008 at 01:38:51PM -0400, Doug Chapman wrote:
> Actually, this only gets me so far.  Looks like there is stuff included
> in the utrace patches that is missing for ia64.  There is a new
> "syscall.h" that was added for the other arches but not for ia64.
>
> Can we disable this patchset on ia64 in fedora until this is complete?

now that .26 is out, rawhide is going to get really bumpy over the next
week or two anyway, now that the .27 window is open.
I suspect a lot of the stuff we're carrying in the Fedora kernel will
be in a on-again/off-again flux quite a bit until we hit .27rc1.

Dave

[Roland McGrath]

Thanks for catching that.  There were two issues (at least).

I fixed the missing #include you found.  Thanks.

The new code is not supposed to be enabled for ia64, because some of the
arch bits are still missing.  I thought I'd done that in config-ia64,
but I hadn't done the magic quite right.

I checked in an update to the patches and configs.  Please let me know if
the current cvs sources build on ia64.

Thanks,
Roland