1:48 p.m.
Hi Laura,
As per our conversation, here is my pull request for the config changes:
https://pagure.io/fedora-kernel-dzickus.git rh_sync
As part of an effort to foster better cross collaboration with internal Red
Hat kernels, align the configs layout to match that kernel. This will allow
Red Hat engineers to provide easier guidance on how to set various config
options.
In addition, the scripts that process the config options will migrate to the
configs/ directory too. Future config workflows will stage all work in the
configs/ area.
A simple diff between the kernels will easily expose which config options
are different. Reading the comments in the file provides guidance to Fedora
to determine if that kernel should make a similar change or not. While the
RH kernel stays internal, requested changes will be posted publicly for
review with said reason.
Rename debugconfig -> configs/base-debug
Rename baseconfig -> configs/base-generic
Rename configs/base-generic/arm/arm64 -> configs/base-generic/arm/aarch64
You can browse the changes here:
https://pagure.io/fedora-kernel-dzickus/branch/rh_sync
Note: Laura asked me not post the patches as the diffstat for the 'git mv'
is obnoxiously large. Instead I am providing the changes on pagure.
Cheers,
Don
11:42 a.m.
On 11/10/2017 11:48 AM, Don Zickus wrote:
Hi Laura,
As per our conversation, here is my pull request for the config changes:
https://pagure.io/fedora-kernel-dzickus.git rh_sync
As part of an effort to foster better cross collaboration with internal Red
Hat kernels, align the configs layout to match that kernel. This will allow
Red Hat engineers to provide easier guidance on how to set various config
options.
In addition, the scripts that process the config options will migrate to the
configs/ directory too. Future config workflows will stage all work in the
configs/ area.
A simple diff between the kernels will easily expose which config options
are different. Reading the comments in the file provides guidance to Fedora
to determine if that kernel should make a similar change or not. While the
RH kernel stays internal, requested changes will be posted publicly for
review with said reason.
Rename debugconfig -> configs/base-debug
Rename baseconfig -> configs/base-generic
Rename configs/base-generic/arm/arm64 -> configs/base-generic/arm/aarch64
You can browse the changes here:
https://pagure.io/fedora-kernel-dzickus/branch/rh_sync
Note: Laura asked me not post the patches as the diffstat for the 'git mv'
is obnoxiously large. Instead I am providing the changes on pagure.
Cheers,
Don
I went ahead and pushed this to rawhide so it could be there before
I start pulling in the merge window stuff.
11:34 p.m.
On Mon, Nov 13, 2017 at 5:42 PM, Laura Abbott <labbott(a)redhat.com> wrote:
On 11/10/2017 11:48 AM, Don Zickus wrote:
>
> Hi Laura,
>
> As per our conversation, here is my pull request for the config changes:
> https://pagure.io/fedora-kernel-dzickus.git rh_sync
>
>
> As part of an effort to foster better cross collaboration with internal
> Red
> Hat kernels, align the configs layout to match that kernel. This will
> allow
> Red Hat engineers to provide easier guidance on how to set various config
> options.
>
> In addition, the scripts that process the config options will migrate to
> the
> configs/ directory too. Future config workflows will stage all work in
> the
> configs/ area.
>
> A simple diff between the kernels will easily expose which config options
> are different. Reading the comments in the file provides guidance to
> Fedora
> to determine if that kernel should make a similar change or not. While
> the
> RH kernel stays internal, requested changes will be posted publicly for
> review with said reason.
>
> Rename debugconfig -> configs/base-debug
> Rename baseconfig -> configs/base-generic
Any chance we could drop the base- in those names and just have
configs/debug/
configs/generic
The base- is somewhat superfluous and is annoying for auto complete ;-)
8:17 a.m.
On Wed, Dec 06, 2017 at 05:34:18AM +0000, Peter Robinson wrote:
On Mon, Nov 13, 2017 at 5:42 PM, Laura Abbott
<labbott(a)redhat.com> wrote:
> On 11/10/2017 11:48 AM, Don Zickus wrote:
>>
>> Hi Laura,
>>
>> As per our conversation, here is my pull request for the config changes:
>> https://pagure.io/fedora-kernel-dzickus.git rh_sync
>>
>>
>> As part of an effort to foster better cross collaboration with internal
>> Red
>> Hat kernels, align the configs layout to match that kernel. This will
>> allow
>> Red Hat engineers to provide easier guidance on how to set various config
>> options.
>>
>> In addition, the scripts that process the config options will migrate to
>> the
>> configs/ directory too. Future config workflows will stage all work in
>> the
>> configs/ area.
>>
>> A simple diff between the kernels will easily expose which config options
>> are different. Reading the comments in the file provides guidance to
>> Fedora
>> to determine if that kernel should make a similar change or not. While
>> the
>> RH kernel stays internal, requested changes will be posted publicly for
>> review with said reason.
>>
>> Rename debugconfig -> configs/base-debug
>> Rename baseconfig -> configs/base-generic
Any chance we could drop the base- in those names and just have
configs/debug/
configs/generic
The base- is somewhat superfluous and is annoying for auto complete ;-)
It is, but was specifically added so kernels that want to do overrides like
RHEL could add their own custom configs/debug and configs/generic.
I am open to name changes but the goal was to use Fedora configs as a base
and then allow the ability to override through other directories.
So if you have a proposal to allow that, I am open to it. :-)
Cheers,
Don
8:34 a.m.
On Wed, Dec 6, 2017 at 2:17 PM, Don Zickus <dzickus(a)redhat.com> wrote:
On Wed, Dec 06, 2017 at 05:34:18AM +0000, Peter Robinson wrote:
> On Mon, Nov 13, 2017 at 5:42 PM, Laura Abbott <labbott(a)redhat.com> wrote:
> > On 11/10/2017 11:48 AM, Don Zickus wrote:
> >>
> >> Hi Laura,
> >>
> >> As per our conversation, here is my pull request for the config changes:
> >> https://pagure.io/fedora-kernel-dzickus.git rh_sync
> >>
> >>
> >> As part of an effort to foster better cross collaboration with internal
> >> Red
> >> Hat kernels, align the configs layout to match that kernel. This will
> >> allow
> >> Red Hat engineers to provide easier guidance on how to set various config
> >> options.
> >>
> >> In addition, the scripts that process the config options will migrate to
> >> the
> >> configs/ directory too. Future config workflows will stage all work in
> >> the
> >> configs/ area.
> >>
> >> A simple diff between the kernels will easily expose which config options
> >> are different. Reading the comments in the file provides guidance to
> >> Fedora
> >> to determine if that kernel should make a similar change or not. While
> >> the
> >> RH kernel stays internal, requested changes will be posted publicly for
> >> review with said reason.
> >>
> >> Rename debugconfig -> configs/base-debug
> >> Rename baseconfig -> configs/base-generic
>
> Any chance we could drop the base- in those names and just have
> configs/debug/
> configs/generic
>
> The base- is somewhat superfluous and is annoying for auto complete ;-)
It is, but was specifically added so kernels that want to do overrides like
RHEL could add their own custom configs/debug and configs/generic.
I am open to name changes but the goal was to use Fedora configs as a base
and then allow the ability to override through other directories.
I don't see how 's/base-//' would stop the ability for overrides? Do
you have an explicit example of how you see that working?
> So if you have a proposal to allow that, I am open to it. :-)
8:50 a.m.
On Wed, Dec 06, 2017 at 02:34:28PM +0000, Peter Robinson wrote:
On Wed, Dec 6, 2017 at 2:17 PM, Don Zickus <dzickus(a)redhat.com>
wrote:
> On Wed, Dec 06, 2017 at 05:34:18AM +0000, Peter Robinson wrote:
>> On Mon, Nov 13, 2017 at 5:42 PM, Laura Abbott <labbott(a)redhat.com> wrote:
>> > On 11/10/2017 11:48 AM, Don Zickus wrote:
>> >>
>> >> Hi Laura,
>> >>
>> >> As per our conversation, here is my pull request for the config
changes:
>> >> https://pagure.io/fedora-kernel-dzickus.git rh_sync
>> >>
>> >>
>> >> As part of an effort to foster better cross collaboration with
internal
>> >> Red
>> >> Hat kernels, align the configs layout to match that kernel. This will
>> >> allow
>> >> Red Hat engineers to provide easier guidance on how to set various
config
>> >> options.
>> >>
>> >> In addition, the scripts that process the config options will migrate
to
>> >> the
>> >> configs/ directory too. Future config workflows will stage all work
in
>> >> the
>> >> configs/ area.
>> >>
>> >> A simple diff between the kernels will easily expose which config
options
>> >> are different. Reading the comments in the file provides guidance to
>> >> Fedora
>> >> to determine if that kernel should make a similar change or not.
While
>> >> the
>> >> RH kernel stays internal, requested changes will be posted publicly
for
>> >> review with said reason.
>> >>
>> >> Rename debugconfig -> configs/base-debug
>> >> Rename baseconfig -> configs/base-generic
>>
>> Any chance we could drop the base- in those names and just have
>> configs/debug/
>> configs/generic
>>
>> The base- is somewhat superfluous and is annoying for auto complete ;-)
>
> It is, but was specifically added so kernels that want to do overrides like
> RHEL could add their own custom configs/debug and configs/generic.
>
> I am open to name changes but the goal was to use Fedora configs as a base
> and then allow the ability to override through other directories.
I don't see how 's/base-//' would stop the ability for overrides? Do
you have an explicit example of how you see that working?
THe way it works is configs/base-generic creates the initial template. Then
the scripts walk the configs/generic directory to override anything it
finds. This makes it clear what the differences are with Fedora and when
Fedora changes an option, it makes it easy to trigger a review of said
change.
I hope that clarifies things.
Cheers,
Don
4:24 p.m.
On 2017-12-06 9:17 AM, Don Zickus wrote:
On Wed, Dec 06, 2017 at 05:34:18AM +0000, Peter Robinson wrote:
> On Mon, Nov 13, 2017 at 5:42 PM, Laura Abbott <labbott(a)redhat.com> wrote:
>> On 11/10/2017 11:48 AM, Don Zickus wrote:
>>>
>>> Hi Laura,
>>>
>>> As per our conversation, here is my pull request for the config changes:
>>> https://pagure.io/fedora-kernel-dzickus.git rh_sync
>>>
>>>
>>> As part of an effort to foster better cross collaboration with internal
>>> Red
>>> Hat kernels, align the configs layout to match that kernel. This will
>>> allow
>>> Red Hat engineers to provide easier guidance on how to set various config
>>> options.
>>>
>>> In addition, the scripts that process the config options will migrate to
>>> the
>>> configs/ directory too. Future config workflows will stage all work in
>>> the
>>> configs/ area.
>>>
>>> A simple diff between the kernels will easily expose which config options
>>> are different. Reading the comments in the file provides guidance to
>>> Fedora
>>> to determine if that kernel should make a similar change or not. While
>>> the
>>> RH kernel stays internal, requested changes will be posted publicly for
>>> review with said reason.
>>>
>>> Rename debugconfig -> configs/base-debug
>>> Rename baseconfig -> configs/base-generic
>
> Any chance we could drop the base- in those names and just have
> configs/debug/
> configs/generic
>
> The base- is somewhat superfluous and is annoying for auto complete ;-)
It is, but was specifically added so kernels that want to do overrides like
RHEL could add their own custom configs/debug and configs/generic.
I am open to name changes but the goal was to use Fedora configs as a base
and then allow the ability to override through other directories.
So if you have a proposal to allow that, I am open to it. :-)
Why not configs/fedora/{generic,debug} and then we tack on a
configs/rhel/{generic,debug} when forking for the next RHEL kernel?
Trying to keep them from polluting each other with specific names?
--
Jarod Wilson
jarod(a)redhat.com
8:24 a.m.
On Fri, Dec 08, 2017 at 05:24:22PM -0500, Jarod Wilson wrote:
> It is, but was specifically added so kernels that want to do
overrides like
> RHEL could add their own custom configs/debug and configs/generic.
>
> I am open to name changes but the goal was to use Fedora configs as a base
> and then allow the ability to override through other directories.
>
> So if you have a proposal to allow that, I am open to it. :-)
Why not configs/fedora/{generic,debug} and then we tack on a
configs/rhel/{generic,debug} when forking for the next RHEL kernel? Trying
to keep them from polluting each other with specific names?
Ok. I don't have any objection to that.
Cheers,
Don
3:50 p.m.
On 2017-12-11 9:24 AM, Don Zickus wrote:
On Fri, Dec 08, 2017 at 05:24:22PM -0500, Jarod Wilson wrote:
>> It is, but was specifically added so kernels that want to do overrides like
>> RHEL could add their own custom configs/debug and configs/generic.
>>
>> I am open to name changes but the goal was to use Fedora configs as a base
>> and then allow the ability to override through other directories.
>>
>> So if you have a proposal to allow that, I am open to it. :-)
>
> Why not configs/fedora/{generic,debug} and then we tack on a
> configs/rhel/{generic,debug} when forking for the next RHEL kernel? Trying
> to keep them from polluting each other with specific names?
Ok. I don't have any objection to that.
Something I haven't actually looked at... Are those 'generic' and
'debug' items actually files, or folder full of individual config option
files, like we have in Red Hat Enterprise Linux 7's tree? Either way, we
could still do individual files under configs/rhel/generic/CONFIG_FOO
that override either a stack of files or an individual file from Fedora.
I'm quite partial to the one config option per file route we've taken in
RHEL7, because people so infrequently get it wrong, where the old pile
of files approach in RHEL-6, people were frequently adding config
options to what were originally the Fedora configs, iirc, rather than
the RHEL override configs. The one config per file approach is also less
prone to requiring rediffing when someone else's config option gets in
before yours. I think having configs/fedora/* for the base and
configs/rhel/* for the RHEL overrides/updates/additions should be clear
enough that it won't get tanked either, and continues to provide the
benefit of collision avoidance.
--
Jarod Wilson
jarod(a)redhat.com
8:32 p.m.
On Mon, Dec 11, 2017 at 04:50:03PM -0500, Jarod Wilson wrote:
On 2017-12-11 9:24 AM, Don Zickus wrote:
> On Fri, Dec 08, 2017 at 05:24:22PM -0500, Jarod Wilson wrote:
> > > It is, but was specifically added so kernels that want to do overrides
like
> > > RHEL could add their own custom configs/debug and configs/generic.
> > >
> > > I am open to name changes but the goal was to use Fedora configs as a
base
> > > and then allow the ability to override through other directories.
> > >
> > > So if you have a proposal to allow that, I am open to it. :-)
> >
> > Why not configs/fedora/{generic,debug} and then we tack on a
> > configs/rhel/{generic,debug} when forking for the next RHEL kernel? Trying
> > to keep them from polluting each other with specific names?
>
> Ok. I don't have any objection to that.
Something I haven't actually looked at... Are those 'generic' and
'debug'
items actually files, or folder full of individual config option files, like
we have in Red Hat Enterprise Linux 7's tree? Either way, we could still do
individual files under configs/rhel/generic/CONFIG_FOO that override either
a stack of files or an individual file from Fedora.
That was the plan. Fedora provides individual files and we have the ability
to override it with our changes. In fact, I am hoping to go one further and
provide our changes as feedback to Fedora as suggestions for them to
consider. But that is a side benefit.
I'm quite partial to the one config option per file route we've taken in
RHEL7, because people so infrequently get it wrong, where the old pile of
files approach in RHEL-6, people were frequently adding config options to
what were originally the Fedora configs, iirc, rather than the RHEL override
configs. The one config per file approach is also less prone to requiring
rediffing when someone else's config option gets in before yours. I think
having configs/fedora/* for the base and configs/rhel/* for the RHEL
overrides/updates/additions should be clear enough that it won't get tanked
either, and continues to provide the benefit of collision avoidance.
Yup. Makes sense.
I will put together a patch to share either tomorrow or the next day.
Cheers,
Don
2320
days inactive
2352
days old
kernel@lists.fedoraproject.org
9 comments
4 participants
participants (4)
-
Don Zickus -
Jarod Wilson -
Laura Abbott -
Peter Robinson