[OS-BUILD PATCH] [redhat] New configs in net/xfrm

[GitLab Bridge on behalf of jeremycline]

From: Fedora Kernel Team <kernel-team(a)fedoraproject.org&gt;

Hi,

As part of the ongoing rebase effort, the following configuration
options need to be reviewed.

As a reminder, the ARK configuration flow involves moving unreviewed
configuration options from the pending directory to the ark directory.
In the diff below, options are removed from the pending directory and
added to the ark hierarchy. The final options that need to be ACKed
are the files that are being added to the ark hierarchy.

If the value for a file that is added should be changed, please reply
with a better option.

 CONFIG_XFRM_USER_COMPAT:

 Transformation(XFRM) user configuration interface like IPsec
 used by compatible Linux applications.

 If unsure, say N.

 Symbol: XFRM_USER_COMPAT [=n]
 Type  : tristate
 Defined at net/xfrm/Kconfig:31
   Prompt: Compatible ABI support
   Depends on: NET [=y] && INET [=y] && XFRM_USER [=y] &&
COMPAT_FOR_U64_ALIGNMENT [=y] && HAVE_EFFICIENT_UNALIGNED_ACCESS [=y]
   Location:
     -> Networking support (NET [=y])
       -> Networking options
         -> Transformation user configuration interface (XFRM_USER [=y])
 Selects: WANT_COMPAT_NETLINK_MESSAGES [=n]

---

Cc: Jiri Benc <jbenc(a)redhat.com&gt;
Cc: Marcelo Leitner <mleitner(a)redhat.com&gt;
Cc: Davide Caratti <dcaratti(a)redhat.com&gt;
Cc: Eric Garver <egarver(a)redhat.com&gt;
Cc: Flavio Leitner <fbl(a)redhat.com&gt;
Cc: Florian Westphal <fwestpha(a)redhat.com&gt;
Cc: Guillaume Nault <gnault(a)redhat.com&gt;
Cc: Hangbin Liu <haliu(a)redhat.com&gt;
Cc: Ivan Vecera <ivecera(a)redhat.com&gt;
Cc: Jarod Wilson <jarod(a)redhat.com&gt;
Cc: Lorenzo Bianconi <lorenzo.bianconi(a)redhat.com&gt;
Cc: Paolo Abeni <pabeni(a)redhat.com&gt;
Cc: Phil Sutter <psutter(a)redhat.com&gt;
Cc: Sabrina Dubroca <sdubroca(a)redhat.com&gt;
Cc: Stefano Brivio <sbrivio(a)redhat.com&gt;
Cc: Xin Long <lxin(a)redhat.com&gt;
Signed-off-by: Fedora Kernel Team <kernel-team(a)fedoraproject.org&gt;
---
 .../common/generic/CONFIG_XFRM_USER_COMPAT    |  1 +
 .../generic/CONFIG_XFRM_USER_COMPAT           | 21 -------------------
 2 files changed, 1 insertion(+), 21 deletions(-)
 create mode 100644 redhat/configs/common/generic/CONFIG_XFRM_USER_COMPAT
 delete mode 100644 redhat/configs/pending-common/generic/CONFIG_XFRM_USER_COMPAT

diff --git a/redhat/configs/common/generic/CONFIG_XFRM_USER_COMPAT
b/redhat/configs/common/generic/CONFIG_XFRM_USER_COMPAT
new file mode 100644
index 000000000000..798d10e8e93e
--- /dev/null
+++ b/redhat/configs/common/generic/CONFIG_XFRM_USER_COMPAT
@@ -0,0 +1 @@
+# CONFIG_XFRM_USER_COMPAT is not set
diff --git a/redhat/configs/pending-common/generic/CONFIG_XFRM_USER_COMPAT
b/redhat/configs/pending-common/generic/CONFIG_XFRM_USER_COMPAT
deleted file mode 100644
index 7941fd360e9b..000000000000
--- a/redhat/configs/pending-common/generic/CONFIG_XFRM_USER_COMPAT
+++ /dev/null
@@ -1,21 +0,0 @@
-# CONFIG_XFRM_USER_COMPAT:
-# 
-# Transformation(XFRM) user configuration interface like IPsec
-# used by compatible Linux applications.
-# 
-# If unsure, say N.
-# 
-# Symbol: XFRM_USER_COMPAT [=n]
-# Type  : tristate
-# Defined at net/xfrm/Kconfig:31
-#   Prompt: Compatible ABI support
-#   Depends on: NET [=y] && INET [=y] && XFRM_USER [=y] &&
COMPAT_FOR_U64_ALIGNMENT [=y] && HAVE_EFFICIENT_UNALIGNED_ACCESS [=y]
-#   Location:
-#     -> Networking support (NET [=y])
-#       -> Networking options
-#         -> Transformation user configuration interface (XFRM_USER [=y])
-# Selects: WANT_COMPAT_NETLINK_MESSAGES [=n]
-# 
-# 
-# 
-# CONFIG_XFRM_USER_COMPAT is not set
-- 
GitLab

[Marcelo Ricardo Leitner]

On Fri, Oct 16, 2020 at 03:29:58PM -0000, GitLab Bridge on behalf of jeremycline wrote:
>  --- /dev/null
>  +++ b/redhat/configs/common/generic/CONFIG_XFRM_USER_COMPAT
>  @@ -0,0 +1 @@
>  +# CONFIG_XFRM_USER_COMPAT is not set 
Sabrina, thoughts?

[Sabrina Dubroca]

2020-10-19, 13:35:11 -0300, Marcelo Ricardo Leitner wrote:
>  On Fri, Oct 16, 2020 at 03:29:58PM -0000, GitLab Bridge on behalf of
> jeremycline wrote:
>  > --- /dev/null
>  > +++ b/redhat/configs/common/generic/CONFIG_XFRM_USER_COMPAT
>  > @@ -0,0 +1 @@
>  > +# CONFIG_XFRM_USER_COMPAT is not set
>  
>  Sabrina, thoughts? 
That's for 32-bit userspace programs configuring IPsec on 64-bit
kernels. I think it's ok to leave it off for now.

-- 
Sabrina

[Marcelo Ricardo Leitner]

On Mon, Oct 19, 2020 at 11:58:59PM +0200, Sabrina Dubroca wrote:
>  2020-10-19, 13:35:11 -0300, Marcelo Ricardo Leitner wrote:
>  > On Fri, Oct 16, 2020 at 03:29:58PM -0000, GitLab Bridge on behalf of jeremycline
> wrote:
>  > > --- /dev/null
>  > > +++ b/redhat/configs/common/generic/CONFIG_XFRM_USER_COMPAT
>  > > @@ -0,0 +1 @@
>  > > +# CONFIG_XFRM_USER_COMPAT is not set
>  > 
>  > Sabrina, thoughts?
>  
>  That's for 32-bit userspace programs configuring IPsec on 64-bit
>  kernels. I think it's ok to leave it off for now. 
Cool. Can you then please ack this change? :-)

  Marcelo

[Sabrina Dubroca]

2020-10-19, 19:16:40 -0300, Marcelo Ricardo Leitner wrote:
>  On Mon, Oct 19, 2020 at 11:58:59PM +0200, Sabrina Dubroca wrote:
>  > 2020-10-19, 13:35:11 -0300, Marcelo Ricardo Leitner wrote:
>  > > On Fri, Oct 16, 2020 at 03:29:58PM -0000, GitLab Bridge on behalf of
> jeremycline wrote:
>  > > > --- /dev/null
>  > > > +++ b/redhat/configs/common/generic/CONFIG_XFRM_USER_COMPAT
>  > > > @@ -0,0 +1 @@
>  > > > +# CONFIG_XFRM_USER_COMPAT is not set
>  > > 
>  > > Sabrina, thoughts?
>  > 
>  > That's for 32-bit userspace programs configuring IPsec on 64-bit
>  > kernels. I think it's ok to leave it off for now.
>  
>  Cool. Can you then please ack this change? :-) 
Acked-by: Sabrina Dubroca <sdubroca(a)redhat.com&gt;

-- 
Sabrina

[Don Zickus]

On Mon, Oct 19, 2020 at 11:58:59PM +0200, Sabrina Dubroca wrote:
>  2020-10-19, 13:35:11 -0300, Marcelo Ricardo Leitner wrote:
>  > On Fri, Oct 16, 2020 at 03:29:58PM -0000, GitLab Bridge on behalf of jeremycline
> wrote:
>  > > --- /dev/null
>  > > +++ b/redhat/configs/common/generic/CONFIG_XFRM_USER_COMPAT
>  > > @@ -0,0 +1 @@
>  > > +# CONFIG_XFRM_USER_COMPAT is not set
>  > 
>  > Sabrina, thoughts?
>  
>  That's for 32-bit userspace programs configuring IPsec on 64-bit
>  kernels. I think it's ok to leave it off for now. 
Is that an ACK for the original patch?

Cheers,
Don