1:37 a.m.
Hi All,
This is a small series of changes to the filtering of kernel modules from core. Each patch
is a mostly self contained subject like usb/drm/network protocols. I split them out to
separate patches just to make each one easier to see the bits that were changing.
Peter
1:37 a.m.
New subject: [PATCH 1/7] filters: usbdrvs: filter image misc serial from core
Disable USB_U132_HCD as it causes issues with serial filter, it's an old tech pcmcia
3G modem unlikely to be in wide use (we can revisit if necessary)
---
config-generic | 2 +-
filter-modules.sh | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/config-generic b/config-generic
index 48837af..c0551bf 100644
--- a/config-generic
+++ b/config-generic
@@ -4266,7 +4266,7 @@ CONFIG_USB_STKWEBCAM=m
# CONFIG_USB_TEST is not set
# CONFIG_USB_EHSET_TEST_FIXTURE is not set
CONFIG_USB_TRANCEVIBRATOR=m
-CONFIG_USB_U132_HCD=m
+# CONFIG_USB_U132_HCD is not set
CONFIG_USB_UEAGLEATM=m
CONFIG_USB_XUSBATM=m
diff --git a/filter-modules.sh b/filter-modules.sh
index 31b78ce..4ed7e58 100755
--- a/filter-modules.sh
+++ b/filter-modules.sh
@@ -24,7 +24,7 @@ scsidrvs="aacraid aic7xxx aic94xx be2iscsi bfa bnx2i bnx2fc
csiostor cxgbi esas2
ttydrvs="ipwireless"
-usbdrvs="atm wusbcore"
+usbdrvs="atm image misc serial wusbcore"
fsdrvs="affs befs coda cramfs dlm ecryptfs hfs hfsplus jfs minix ncpfs nilfs2 ocfs2
reiserfs romfs squashfs sysv ubifs udf ufs"
--
2.5.0
1:37 a.m.
New subject: [PATCH 2/7] filters: armv7/aarch64: add custom ethdrvs to ensure we get useful NICs in core
---
filter-aarch64.sh | 2 ++
filter-armv7hl.sh | 2 ++
2 files changed, 4 insertions(+)
diff --git a/filter-aarch64.sh b/filter-aarch64.sh
index dae47aa..886a9e1 100644
--- a/filter-aarch64.sh
+++ b/filter-aarch64.sh
@@ -11,4 +11,6 @@
driverdirs="atm auxdisplay bcma bluetooth fmc infiniband isdn leds media memstick
message mmc mtd nfc ntb pcmcia platform power ssb staging uio uwb"
+ethdrvs="3com adaptec arc alteon atheros broadcom cadence calxeda chelsio cisco dec
dlink emulex icplus marvell micrel myricom neterion nvidia oki-semi packetengines qlogic
rdc renesas sfc silan sis smsc stmicro sun tehuti ti via wiznet xircom"
+
singlemods="ntb_netdev iscsi_ibft iscsi_boot_sysfs megaraid pmcraid qla1280
9pnet_rdma rpcrdma hid-picolcd hid-prodikeys hwa-hc hwpoison-inject
target_core_user"
diff --git a/filter-armv7hl.sh b/filter-armv7hl.sh
index 5803dd0..4a17102 100644
--- a/filter-armv7hl.sh
+++ b/filter-armv7hl.sh
@@ -11,4 +11,6 @@
driverdirs="atm auxdisplay bcma bluetooth fmc infiniband isdn media memstick message
nfc ntb pcmcia platform ssb staging uio uwb"
+ethdrvs="3com adaptec alteon altera amd atheros broadcom cadence chelsio cisco dec
dlink emulex icplus mellanox micrel myricom natsemi neterion nvidia oki-semi packetengines
qlogic rdc renesas sfc silan sis sun tehuti via wiznet xircom"
+
singlemods="ntb_netdev iscsi_ibft iscsi_boot_sysfs megaraid pmcraid qla1280
9pnet_rdma rpcrdma hid-picolcd hid-prodikeys hwa-hc hwpoison-inject
target_core_user"
--
2.5.0
1:37 a.m.
New subject: [PATCH 3/7] filters: add option to filter input drivers and apply to gameport, tablet and touchscreen so they move out of core
---
filter-modules.sh | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/filter-modules.sh b/filter-modules.sh
index 4ed7e58..8a8a2d4 100755
--- a/filter-modules.sh
+++ b/filter-modules.sh
@@ -20,6 +20,8 @@ netdrvs="appletalk can dsa hamradio ieee802154 irda ppp slip usb
wireless"
ethdrvs="3com adaptec alteon amd atheros broadcom cadence calxeda chelsio cisco dec
dlink emulex icplus marvell mellanox neterion nvidia oki-semi packetengines qlogic rdc
renesas sfc silan sis smsc stmicro sun tehuti ti wiznet xircom"
+inputdrvs="gameport tablet touchscreen"
+
scsidrvs="aacraid aic7xxx aic94xx be2iscsi bfa bnx2i bnx2fc csiostor cxgbi esas2r
fcoe fnic isci libsas lpfc megaraid mpt2sas mpt3sas mvsas pm8001 qla2xxx qla4xxx
sym53c8xx_2 ufs"
ttydrvs="ipwireless"
@@ -95,6 +97,12 @@ do
filter_dir $1 drivers/scsi/${scsi}
done
+# Input
+for input in ${inputdrvs}
+do
+ filter_dir $1 drivers/input/${input}
+done
+
# TTY
for tty in ${ttydrvs}
do
--
2.5.0
1:37 a.m.
New subject: [PATCH 4/7] filters: move firewire mwave w1 from core to modules
---
filter-aarch64.sh | 4 ++--
filter-armv7hl.sh | 4 ++--
filter-i686.sh | 4 ++--
filter-modules.sh | 4 ++--
filter-ppc64.sh | 4 ++--
filter-ppc64le.sh | 4 ++--
filter-ppc64p7.sh | 4 ++--
7 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/filter-aarch64.sh b/filter-aarch64.sh
index 886a9e1..139d179 100644
--- a/filter-aarch64.sh
+++ b/filter-aarch64.sh
@@ -9,8 +9,8 @@
# modifications to the overrides below. If something should be removed across
# all arches, remove it in the default instead of per-arch.
-driverdirs="atm auxdisplay bcma bluetooth fmc infiniband isdn leds media memstick
message mmc mtd nfc ntb pcmcia platform power ssb staging uio uwb"
+driverdirs="atm auxdisplay bcma bluetooth firewire fmc infiniband isdn leds media
memstick message mmc mtd mwave nfc ntb pcmcia platform power ssb staging uio uwb w1"
ethdrvs="3com adaptec arc alteon atheros broadcom cadence calxeda chelsio cisco dec
dlink emulex icplus marvell micrel myricom neterion nvidia oki-semi packetengines qlogic
rdc renesas sfc silan sis smsc stmicro sun tehuti ti via wiznet xircom"
-singlemods="ntb_netdev iscsi_ibft iscsi_boot_sysfs megaraid pmcraid qla1280
9pnet_rdma rpcrdma hid-picolcd hid-prodikeys hwa-hc hwpoison-inject
target_core_user"
+singlemods="ntb_netdev iscsi_ibft iscsi_boot_sysfs megaraid pmcraid qla1280
9pnet_rdma rpcrdma hid-picolcd hid-prodikeys hwa-hc hwpoison-inject target_core_user
sbp_target"
diff --git a/filter-armv7hl.sh b/filter-armv7hl.sh
index 4a17102..cab8daf 100644
--- a/filter-armv7hl.sh
+++ b/filter-armv7hl.sh
@@ -9,8 +9,8 @@
# modifications to the overrides below. If something should be removed across
# all arches, remove it in the default instead of per-arch.
-driverdirs="atm auxdisplay bcma bluetooth fmc infiniband isdn media memstick message
nfc ntb pcmcia platform ssb staging uio uwb"
+driverdirs="atm auxdisplay bcma bluetooth firewire fmc infiniband isdn media
memstick message mwave nfc ntb pcmcia platform ssb staging uio uwb w1"
ethdrvs="3com adaptec alteon altera amd atheros broadcom cadence chelsio cisco dec
dlink emulex icplus mellanox micrel myricom natsemi neterion nvidia oki-semi packetengines
qlogic rdc renesas sfc silan sis sun tehuti via wiznet xircom"
-singlemods="ntb_netdev iscsi_ibft iscsi_boot_sysfs megaraid pmcraid qla1280
9pnet_rdma rpcrdma hid-picolcd hid-prodikeys hwa-hc hwpoison-inject
target_core_user"
+singlemods="ntb_netdev iscsi_ibft iscsi_boot_sysfs megaraid pmcraid qla1280
9pnet_rdma rpcrdma hid-picolcd hid-prodikeys hwa-hc hwpoison-inject target_core_user
sbp_target"
diff --git a/filter-i686.sh b/filter-i686.sh
index 784ab37..dc6f42f 100644
--- a/filter-i686.sh
+++ b/filter-i686.sh
@@ -9,6 +9,6 @@
# modifications to the overrides below. If something should be removed across
# all arches, remove it in the default instead of per-arch.
-driverdirs="atm auxdisplay bcma bluetooth fmc infiniband isdn leds media memstick
mfd mmc mtd nfc ntb pcmcia platform power ssb staging uio uwb"
+driverdirs="atm auxdisplay bcma bluetooth firewire fmc infiniband isdn leds media
memstick mfd mmc mtd mwave nfc ntb pcmcia platform power ssb staging uio uwb w1"
-singlemods="ntb_netdev iscsi_ibft iscsi_boot_sysfs megaraid pmcraid qla1280
9pnet_rdma rpcrdma hid-picolcd hid-prodikeys hwa-hc hwpoison-inject hid-sensor-hub
hid-sensor-magn-3d hid-sensor-incl-3d hid-sensor-gyro-3d hid-sensor-iio-common
hid-sensor-accel-3d hid-sensor-trigger hid-sensor-als hid-sensor-rotation
target_core_user"
+singlemods="ntb_netdev iscsi_ibft iscsi_boot_sysfs megaraid pmcraid qla1280
9pnet_rdma rpcrdma hid-picolcd hid-prodikeys hwa-hc hwpoison-inject hid-sensor-hub
hid-sensor-magn-3d hid-sensor-incl-3d hid-sensor-gyro-3d hid-sensor-iio-common
hid-sensor-accel-3d hid-sensor-trigger hid-sensor-als hid-sensor-rotation target_core_user
sbp_target"
diff --git a/filter-modules.sh b/filter-modules.sh
index 8a8a2d4..eea1480 100755
--- a/filter-modules.sh
+++ b/filter-modules.sh
@@ -14,7 +14,7 @@
# listed here.
# Set the default dirs/modules to filter out
-driverdirs="atm auxdisplay bcma bluetooth fmc iio infiniband isdn leds media
memstick mfd mmc mtd nfc ntb pcmcia platform power ssb staging uio uwb"
+driverdirs="atm auxdisplay bcma bluetooth firewire fmc iio infiniband isdn leds
media memstick mfd mmc mtd mwave nfc ntb pcmcia platform power ssb staging uio uwb
w1"
netdrvs="appletalk can dsa hamradio ieee802154 irda ppp slip usb wireless"
@@ -34,7 +34,7 @@ netprots="appletalk atm ax25 batman-adv bluetooth can dccp dsa
ieee802154 irda l
drmdrvs="ast gma500 mgag200 via nouveau"
-singlemods="ntb_netdev iscsi_ibft iscsi_boot_sysfs megaraid pmcraid qla1280
9pnet_rdma rpcrdma hid-picolcd hid-prodikeys hwa-hc hwpoison-inject hid-sensor-hub
target_core_user"
+singlemods="ntb_netdev iscsi_ibft iscsi_boot_sysfs megaraid pmcraid qla1280
9pnet_rdma rpcrdma hid-picolcd hid-prodikeys hwa-hc hwpoison-inject hid-sensor-hub
target_core_user sbp_target"
# Grab the arch-specific filter list overrides
source ./filter-$2.sh
diff --git a/filter-ppc64.sh b/filter-ppc64.sh
index 8001e09..e4990bb 100644
--- a/filter-ppc64.sh
+++ b/filter-ppc64.sh
@@ -9,6 +9,6 @@
# modifications to the overrides below. If something should be removed across
# all arches, remove it in the default instead of per-arch.
-driverdirs="atm auxdisplay bcma bluetooth fmc infiniband isdn leds media memstick
message mmc mtd nfc ntb pcmcia platform power ssb staging uio uwb"
+driverdirs="atm auxdisplay bcma bluetooth firewire fmc infiniband isdn leds media
memstick message mmc mtd mwave nfc ntb pcmcia platform power ssb staging uio uwb w1"
-singlemods="ntb_netdev iscsi_ibft iscsi_boot_sysfs megaraid pmcraid qla1280
9pnet_rdma rpcrdma hid-picolcd hid-prodikeys hwa-hc hwpoison-inject
target_core_user"
+singlemods="ntb_netdev iscsi_ibft iscsi_boot_sysfs megaraid pmcraid qla1280
9pnet_rdma rpcrdma hid-picolcd hid-prodikeys hwa-hc hwpoison-inject target_core_user
sbp_target"
diff --git a/filter-ppc64le.sh b/filter-ppc64le.sh
index c8948c9..e44c88e 100644
--- a/filter-ppc64le.sh
+++ b/filter-ppc64le.sh
@@ -9,6 +9,6 @@
# modifications to the overrides below. If something should be removed across
# all arches, remove it in the default instead of per-arch.
-driverdirs="atm auxdisplay bcma bluetooth fmc infiniband isdn leds media memstick
message mmc mtd nfc ntb pcmcia platform power ssb staging uio uwb"
+driverdirs="atm auxdisplay bcma bluetooth firewire fmc infiniband isdn leds media
memstick message mmc mtd mwave nfc ntb pcmcia platform power ssb staging uio uwb w1"
-singlemods="ntb_netdev iscsi_ibft iscsi_boot_sysfs megaraid pmcraid qla1280
9pnet_rdma rpcrdma hid-picolcd hid-prodikeys hwa-hc hwpoison-inject
target_core_user"
+singlemods="ntb_netdev iscsi_ibft iscsi_boot_sysfs megaraid pmcraid qla1280
9pnet_rdma rpcrdma hid-picolcd hid-prodikeys hwa-hc hwpoison-inject target_core_user
sbp_target"
diff --git a/filter-ppc64p7.sh b/filter-ppc64p7.sh
index 32c43a4..b499f0e 100644
--- a/filter-ppc64p7.sh
+++ b/filter-ppc64p7.sh
@@ -9,6 +9,6 @@
# modifications to the overrides below. If something should be removed across
# all arches, remove it in the default instead of per-arch.
-driverdirs="atm auxdisplay bcma bluetooth fmc infiniband isdn leds media memstick
message mmc mtd nfc ntb pcmcia platform power ssb staging uio uwb"
+driverdirs="atm auxdisplay bcma bluetooth firewire fmc infiniband isdn leds media
memstick message mmc mtd mwave nfc ntb pcmcia platform power ssb staging uio uwb w1"
-singlemods="ntb_netdev iscsi_ibft iscsi_boot_sysfs megaraid pmcraid qla1280
9pnet_rdma rpcrdma hid-picolcd hid-prodikeys hwa-hc hwpoison-inject
target_core_user"
+singlemods="ntb_netdev iscsi_ibft iscsi_boot_sysfs megaraid pmcraid qla1280
9pnet_rdma rpcrdma hid-picolcd hid-prodikeys hwa-hc hwpoison-inject target_core_user
sbp_target"
--
2.5.0
1:37 a.m.
New subject: [PATCH 5/7] filters: netprots: filter 6lowpan and mpls from core
---
filter-modules.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/filter-modules.sh b/filter-modules.sh
index eea1480..0e0e4fc 100755
--- a/filter-modules.sh
+++ b/filter-modules.sh
@@ -30,7 +30,7 @@ usbdrvs="atm image misc serial wusbcore"
fsdrvs="affs befs coda cramfs dlm ecryptfs hfs hfsplus jfs minix ncpfs nilfs2 ocfs2
reiserfs romfs squashfs sysv ubifs udf ufs"
-netprots="appletalk atm ax25 batman-adv bluetooth can dccp dsa ieee802154 irda l2tp
mac80211 mac802154 netrom nfc rds rfkill rose sctp wireless"
+netprots="6lowpan appletalk atm ax25 batman-adv bluetooth can dccp dsa ieee802154
irda l2tp mac80211 mac802154 mpls netrom nfc rds rfkill rose sctp wireless"
drmdrvs="ast gma500 mgag200 via nouveau"
--
2.5.0
1:37 a.m.
New subject: [PATCH 6/7] filters: drmdrvs: add amd, i2c, i915, and radeon plus ARMv7 specific drivers to modules alongside nouveau. -modules is generally needed for desktop anyway
---
filter-armv7hl.sh | 2 ++
filter-modules.sh | 2 +-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/filter-armv7hl.sh b/filter-armv7hl.sh
index cab8daf..6de7765 100644
--- a/filter-armv7hl.sh
+++ b/filter-armv7hl.sh
@@ -13,4 +13,6 @@ driverdirs="atm auxdisplay bcma bluetooth firewire fmc infiniband
isdn media mem
ethdrvs="3com adaptec alteon altera amd atheros broadcom cadence chelsio cisco dec
dlink emulex icplus mellanox micrel myricom natsemi neterion nvidia oki-semi packetengines
qlogic rdc renesas sfc silan sis sun tehuti via wiznet xircom"
+drmdrvs="amd armada bridge ast exynos i2c imx mgag200 msm omapdrm panel nouveau
radeon rockchip tegra tilcdc via"
+
singlemods="ntb_netdev iscsi_ibft iscsi_boot_sysfs megaraid pmcraid qla1280
9pnet_rdma rpcrdma hid-picolcd hid-prodikeys hwa-hc hwpoison-inject target_core_user
sbp_target"
diff --git a/filter-modules.sh b/filter-modules.sh
index 0e0e4fc..8063f8a 100755
--- a/filter-modules.sh
+++ b/filter-modules.sh
@@ -32,7 +32,7 @@ fsdrvs="affs befs coda cramfs dlm ecryptfs hfs hfsplus jfs minix
ncpfs nilfs2 oc
netprots="6lowpan appletalk atm ax25 batman-adv bluetooth can dccp dsa ieee802154
irda l2tp mac80211 mac802154 mpls netrom nfc rds rfkill rose sctp wireless"
-drmdrvs="ast gma500 mgag200 via nouveau"
+drmdrvs="amd ast gma500 i2c i915 mgag200 nouveau radeon via "
singlemods="ntb_netdev iscsi_ibft iscsi_boot_sysfs megaraid pmcraid qla1280
9pnet_rdma rpcrdma hid-picolcd hid-prodikeys hwa-hc hwpoison-inject hid-sensor-hub
target_core_user sbp_target"
--
2.5.0
1:37 a.m.
New subject: [PATCH 7/7] filters: tty: just filter all tty drivers, they're all corner case MP serial adapters, pcmcia (which we filter already) or other corner case, all core serial used for consoles are already built in
---
filter-modules.sh | 10 +---------
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/filter-modules.sh b/filter-modules.sh
index 8063f8a..7f14011 100755
--- a/filter-modules.sh
+++ b/filter-modules.sh
@@ -14,7 +14,7 @@
# listed here.
# Set the default dirs/modules to filter out
-driverdirs="atm auxdisplay bcma bluetooth firewire fmc iio infiniband isdn leds
media memstick mfd mmc mtd mwave nfc ntb pcmcia platform power ssb staging uio uwb
w1"
+driverdirs="atm auxdisplay bcma bluetooth firewire fmc iio infiniband isdn leds
media memstick mfd mmc mtd mwave nfc ntb pcmcia platform power ssb staging tty uio uwb
w1"
netdrvs="appletalk can dsa hamradio ieee802154 irda ppp slip usb wireless"
@@ -24,8 +24,6 @@ inputdrvs="gameport tablet touchscreen"
scsidrvs="aacraid aic7xxx aic94xx be2iscsi bfa bnx2i bnx2fc csiostor cxgbi esas2r
fcoe fnic isci libsas lpfc megaraid mpt2sas mpt3sas mvsas pm8001 qla2xxx qla4xxx
sym53c8xx_2 ufs"
-ttydrvs="ipwireless"
-
usbdrvs="atm image misc serial wusbcore"
fsdrvs="affs befs coda cramfs dlm ecryptfs hfs hfsplus jfs minix ncpfs nilfs2 ocfs2
reiserfs romfs squashfs sysv ubifs udf ufs"
@@ -103,12 +101,6 @@ do
filter_dir $1 drivers/input/${input}
done
-# TTY
-for tty in ${ttydrvs}
-do
- filter_dir $1 drivers/tty/${tty}
-done
-
# USB
for usb in ${usbdrvs}
do
--
2.5.0
6:09 a.m.
On Fri, Jan 15, 2016 at 2:37 AM, Peter Robinson <pbrobinson(a)gmail.com> wrote:
Hi All,
This is a small series of changes to the filtering of kernel modules from core. Each
patch is a mostly self contained subject like usb/drm/network protocols. I split them out
to separate patches just to make each one easier to see the bits that were changing.
This series looks pretty good. I'm only hesitant about 6/7 but not
much so. Did you happen to do a scratch build with all of this
applied? I'm surprised you got firewire to move cleanly. I tried
that when I originally did this and it looked like a pain. Maybe I
messed up back then.
josh
6:12 a.m.
On Fri, Jan 15, 2016 at 12:09 PM, Josh Boyer <jwboyer(a)fedoraproject.org> wrote:
On Fri, Jan 15, 2016 at 2:37 AM, Peter Robinson
<pbrobinson(a)gmail.com> wrote:
> Hi All,
>
> This is a small series of changes to the filtering of kernel modules from core. Each
patch is a mostly self contained subject like usb/drm/network protocols. I split them out
to separate patches just to make each one easier to see the bits that were changing.
This series looks pretty good. I'm only hesitant about 6/7 but not
much so. Did you happen to do a scratch build with all of this
applied? I'm surprised you got firewire to move cleanly. I tried
that when I originally did this and it looked like a pain. Maybe I
messed up back then.
I did scratch builds for x86_64, armv7 and aarch64, all the other
arches should be covered by that combination.
Peter
6:14 a.m.
On Fri, Jan 15, 2016 at 12:12 PM, Peter Robinson <pbrobinson(a)gmail.com> wrote:
On Fri, Jan 15, 2016 at 12:09 PM, Josh Boyer
<jwboyer(a)fedoraproject.org> wrote:
> On Fri, Jan 15, 2016 at 2:37 AM, Peter Robinson <pbrobinson(a)gmail.com> wrote:
>> Hi All,
>>
>> This is a small series of changes to the filtering of kernel modules from core.
Each patch is a mostly self contained subject like usb/drm/network protocols. I split them
out to separate patches just to make each one easier to see the bits that were changing.
>
> This series looks pretty good. I'm only hesitant about 6/7 but not
> much so. Did you happen to do a scratch build with all of this
> applied? I'm surprised you got firewire to move cleanly. I tried
> that when I originally did this and it looked like a pain. Maybe I
> messed up back then.
I did scratch builds for x86_64, armv7 and aarch64, all the other
arches should be covered by that combination.
Firewall needed the single sbp_target added, most of the rest of
firewall is sound which was all bumped by default.
P
7:06 a.m.
On 01/15/2016 07:37 AM, Peter Robinson wrote:
Hi All,
This is a small series of changes to the filtering of kernel modules from core. Each
patch is a mostly self contained subject like usb/drm/network protocols. I split them out
to separate patches just to make each one easier to see the bits that were changing.
If I can recall correctly, one of the modular kernel packaging changes
was that you could only have kernel-core installed so I have to ask wont
this break running systems for users that are relying on things being in
kernel-core since then?
And since the kernel modular change was aimed to achieve the smallest as
well as the most flexible footprint I have to ask is there something
preventing putting every kernel module in it's own sub package (
kernel-module-<module> ) to prevent ( potential ) breakage in the
future as people go smaller and smaller which will eventually lead to
what I have described here.
JBG
7:09 a.m.
On Fri, Jan 15, 2016 at 7:12 AM, Peter Robinson <pbrobinson(a)gmail.com> wrote:
On Fri, Jan 15, 2016 at 12:09 PM, Josh Boyer
<jwboyer(a)fedoraproject.org> wrote:
> On Fri, Jan 15, 2016 at 2:37 AM, Peter Robinson <pbrobinson(a)gmail.com> wrote:
>> Hi All,
>>
>> This is a small series of changes to the filtering of kernel modules from core.
Each patch is a mostly self contained subject like usb/drm/network protocols. I split them
out to separate patches just to make each one easier to see the bits that were changing.
>
> This series looks pretty good. I'm only hesitant about 6/7 but not
> much so. Did you happen to do a scratch build with all of this
> applied? I'm surprised you got firewire to move cleanly. I tried
> that when I originally did this and it looked like a pain. Maybe I
> messed up back then.
I did scratch builds for x86_64, armv7 and aarch64, all the other
arches should be covered by that combination.
Did you happen to boot any of the resulting builds? I don't think it
should be a problem with kernel-core and kernel-modules installed
clearly, but I'm wondering about just kernel-core in e.g. an x86_64
VM.
Also, I'm assuming this is targeted at rawhide, correct?
josh
7:14 a.m.
On Fri, Jan 15, 2016 at 1:09 PM, Josh Boyer <jwboyer(a)fedoraproject.org> wrote:
On Fri, Jan 15, 2016 at 7:12 AM, Peter Robinson
<pbrobinson(a)gmail.com> wrote:
> On Fri, Jan 15, 2016 at 12:09 PM, Josh Boyer <jwboyer(a)fedoraproject.org>
wrote:
>> On Fri, Jan 15, 2016 at 2:37 AM, Peter Robinson <pbrobinson(a)gmail.com>
wrote:
>>> Hi All,
>>>
>>> This is a small series of changes to the filtering of kernel modules from
core. Each patch is a mostly self contained subject like usb/drm/network protocols. I
split them out to separate patches just to make each one easier to see the bits that were
changing.
>>
>> This series looks pretty good. I'm only hesitant about 6/7 but not
>> much so. Did you happen to do a scratch build with all of this
>> applied? I'm surprised you got firewire to move cleanly. I tried
>> that when I originally did this and it looked like a pain. Maybe I
>> messed up back then.
>
> I did scratch builds for x86_64, armv7 and aarch64, all the other
> arches should be covered by that combination.
Did you happen to boot any of the resulting builds? I don't think it
should be a problem with kernel-core and kernel-modules installed
clearly, but I'm wondering about just kernel-core in e.g. an x86_64
VM.
No, I have them locally so can do.
Also, I'm assuming this is targeted at rawhide, correct?
Correct.
Peter
7:18 a.m.
On Fri, Jan 15, 2016 at 8:06 AM, Jóhann B. Guðmundsson
<johannbg(a)gmail.com> wrote:
On 01/15/2016 07:37 AM, Peter Robinson wrote:
>
> Hi All,
>
> This is a small series of changes to the filtering of kernel modules from
> core. Each patch is a mostly self contained subject like usb/drm/network
> protocols. I split them out to separate patches just to make each one easier
> to see the bits that were changing.
>
If I can recall correctly, one of the modular kernel packaging changes was
that you could only have kernel-core installed so I have to ask wont this
break running systems for users that are relying on things being in
kernel-core since then?
Not exactly. The work was done to reduce the size of the kernel
needed for cloud installations and it was extended to include the set
of modules needed to boot KVM guests. There has never been the
guarantee that kernel-core alone would work on any particularly subset
of physical hardware.
And since the kernel modular change was aimed to achieve the smallest
as
well as the most flexible footprint I have to ask is there something
preventing putting every kernel module in it's own sub package (
kernel-module-<module> ) to prevent ( potential ) breakage in the future as
people go smaller and smaller which will eventually lead to what I have
described here.
Time, and packaging pain is what is preventing it. Also, the 80%
solution as it exists today is sufficient for everyone's needs at the
moment, so investing further to split everything up like that isn't
really worthwhile. Particularly when you'd have to make related
changes in anaconda and other packages.
josh
9:01 a.m.
On 01/15/2016 01:18 PM, Josh Boyer wrote:
On Fri, Jan 15, 2016 at 8:06 AM, Jóhann B. Guðmundsson
<johannbg(a)gmail.com> wrote:
>
> On 01/15/2016 07:37 AM, Peter Robinson wrote:
>> Hi All,
>>
>> This is a small series of changes to the filtering of kernel modules from
>> core. Each patch is a mostly self contained subject like usb/drm/network
>> protocols. I split them out to separate patches just to make each one easier
>> to see the bits that were changing.
>>
>
> If I can recall correctly, one of the modular kernel packaging changes was
> that you could only have kernel-core installed so I have to ask wont this
> break running systems for users that are relying on things being in
> kernel-core since then?
Not exactly. The work was done to reduce the size of the kernel
needed for cloud installations and it was extended to include the set
of modules needed to boot KVM guests. There has never been the
guarantee that kernel-core alone would work on any particularly subset
of physical hardware.
No but the change proposal implied you could just install kernel-core
and get away with it as long the included modules worked.
> And since the kernel modular change was aimed to achieve the smallest as
> well as the most flexible footprint I have to ask is there something
> preventing putting every kernel module in it's own sub package (
> kernel-module-<module> ) to prevent ( potential ) breakage in the future as
> people go smaller and smaller which will eventually lead to what I have
> described here.
Time, and packaging pain is what is preventing it.
Contribute time to an community is work in one form or another with the
only prevention being people themselves.
Also, the 80%
solution as it exists today is sufficient for everyone's needs at the
moment, so investing further to split everything up like that isn't
really worthwhile.
Sorry this does not make any sense to me and throwing some arbitrary
percentage number even less so since instability in package management (
that includes kernel splits and merges repeat through history ) and ui
is what's driving people away from the community.
To me this basically says that it's worthwhile to cause breakage and end
users frustration which eventually lead to less contribution to the
community ( which means less hours in total in the contributed time pool
) but that has no meaningful end result in the long term so that's
probably not what you are hinting at even if it was we live in an ever
changing environment ( IoT, ARM,Servers,
Cloud,Containers,Phones,Tablets,Desktops which are all things Fedora is
currently trying to support for example ) and the only way to adapt to
that is to precisely to be as modular as possible with package
expressing correct dependency since that's the only effectively way to
combine what ever mixture of components put together to reflects that
environment in any given point in time.
To be able to get there ( assuming people want to actually fix what's
broken ) it first and for most takes time even thou some people may
subjectively view that task at hand based on their emotion or
perspective and categories them as hard or easy while I personally dont
see things that way since an task is just an task to me nor easy nor
hard. and to be there we have to begin on the core/baseOS and the first
component there with kernel to start working on ( by completely
splitting it ) then fix the failure of the fundamental task of fesco/fps
of providing and ensuring components express correct package dependency.
Fixing that will probably be the most time consuming task since I know
for fact after crawling through around 500 - 1000 components with the
most troublesome being those that dont express any. It's like package
maintainers of those components seem to have magically expected
core/baseOS in the distribution to be frozen in time since FC1 o_O.
Those components are the one that will be the most likely the cause most
breakage as well.
9:40 a.m.
On Fri, Jan 15, 2016 at 03:01:34PM +0000, Jóhann B. Guðmundsson wrote:
>>And since the kernel modular change was aimed to achieve the
smallest as
>>well as the most flexible footprint I have to ask is there something
>>preventing putting every kernel module in it's own sub package (
>>kernel-module-<module> ) to prevent ( potential ) breakage in the future
as
>>people go smaller and smaller which will eventually lead to what I have
>>described here.
>Time, and packaging pain is what is preventing it.
Contribute time to an community is work in one form or another with
the only prevention being people themselves.
That is correct. I should have been clearer when I said the above. I
meant I personally do not have the time to implement something like
that.
> Also, the 80%
>solution as it exists today is sufficient for everyone's needs at the
>moment, so investing further to split everything up like that isn't
>really worthwhile.
Sorry this does not make any sense to me and throwing some arbitrary
percentage number even less so since instability in package
management ( that includes kernel splits and merges repeat through
history ) and ui is what's driving people away from the community.
I've seen neither decreased nor increased participation in the Fedora
kernel since the split went in. I have seen a number of people express
that they like the change because it suits their needs better. Everyone
else I've interacted with seems to be mostly ambivalent about it.
To me this basically says that it's worthwhile to cause breakage
and
end users frustration which eventually lead to less contribution to
the community ( which means less hours in total in the contributed
time pool ) but that has no meaningful end result in the long term
I'm not aware of any breakage. I believe there were a few bugs very
early, but for the most part things have been working fine. The split
has been in 3 releases now, so this isn't new any longer.
so that's probably not what you are hinting at even if it was we
live in an ever changing environment ( IoT, ARM,Servers,
Cloud,Containers,Phones,Tablets,Desktops which are all things Fedora
is currently trying to support for example ) and the only way to
Correct. Our environment is constantly changing, and so is the kernel
itself.
adapt to that is to precisely to be as modular as possible with
package expressing correct dependency since that's the only
effectively way to combine what ever mixture of components put
together to reflects that environment in any given point in time.
I'm sure we'd be happy to review changes that do this if someone feels
inclined. There will be a lot of work if something like that goes in,
which means people interested need to be willing to do that work as you
said in the section I've trimmed.
josh
3021
days inactive
3021
days old
kernel@lists.fedoraproject.org
16 comments
3 participants
participants (3)
-
Josh Boyer -
Jóhann B. Guðmundsson -
Peter Robinson