From: Fedora Kernel Team kernel-team@fedoraproject.org
[redhat] New configs in drivers/hid
Hi,
As part of the ongoing rebase effort, the following configuration options need to be reviewed.
As a reminder, the ARK configuration flow involves moving unreviewed configuration options from the pending directory to the ark directory. In the diff below, options are removed from the pending directory and added to the ark hierarchy. The final options that need to be ACKed are the files that are being added to the ark hierarchy.
If the value for a file that is added should be changed, please reply with a better option.
Symbol: HID_APPLETB_BL [=n] Type : tristate Defined at drivers/hid/Kconfig:151 Prompt: Apple Touch Bar Backlight Depends on: HID_SUPPORT [=y] && HID [=y] && BACKLIGHT_CLASS_DEVICE [=y] Location: -> Device Drivers -> HID bus support (HID_SUPPORT [=y]) -> HID bus core support (HID [=y]) -> Special HID drivers -> Apple Touch Bar Backlight (HID_APPLETB_BL [=n]) Selected by [n]: - HID_APPLETB_KBD [=n] && HID_SUPPORT [=y] && HID [=y] && USB_HID [=y] && BACKLIGHT_CLASS_DEVICE [=y] && INPUT [=y]
Commit: 1fd41e5e3d7c (HID: hid-appletb-bl: add driver for the backlight of Apple Touch Bars)
---
Symbol: HID_APPLETB_KBD [=n] Type : tristate Defined at drivers/hid/Kconfig:161 Prompt: Apple Touch Bar Keyboard Mode Depends on: HID_SUPPORT [=y] && HID [=y] && USB_HID [=y] && BACKLIGHT_CLASS_DEVICE [=y] && INPUT [=y] Location: -> Device Drivers -> HID bus support (HID_SUPPORT [=y]) -> HID bus core support (HID [=y]) -> Special HID drivers -> Apple Touch Bar Keyboard Mode (HID_APPLETB_KBD [=n]) Selects: INPUT_SPARSEKMAP [=m] && HID_APPLETB_BL [=n]
Commit: 8e9b9152cfbd (HID: hid-appletb-kbd: add driver for the keyboard mode of Apple Touch Bars)
---
Symbol: HID_UNIVERSAL_PIDFF [=n] Type : tristate Defined at drivers/hid/Kconfig:1249 Prompt: universal-pidff: extended USB PID driver compatibility and usage Depends on: HID_SUPPORT [=y] && HID [=y] && USB_HID [=y] && HID_PID [=y] Location: -> Device Drivers -> HID bus support (HID_SUPPORT [=y]) -> HID bus core support (HID [=y]) -> Special HID drivers -> universal-pidff: extended USB PID driver compatibility and usage (HID_UNIVERSAL_PIDFF [=n])
Commit: f06bf8d94fff (HID: Add hid-universal-pidff driver and supported device ids)
---
Signed-off-by: Fedora Kernel Team kernel-team@fedoraproject.org
diff --git a/redhat/configs/pending-rhel/generic/CONFIG_HID_APPLETB_BL b/redhat/configs/pending-rhel/generic/CONFIG_HID_APPLETB_BL deleted file mode 100644 index blahblah..blahblah 0 --- a/redhat/configs/pending-rhel/generic/CONFIG_HID_APPLETB_BL +++ /dev/null @@ -1,18 +0,0 @@ -# Symbol: HID_APPLETB_BL [=n] -# Type : tristate -# Defined at drivers/hid/Kconfig:151 -# Prompt: Apple Touch Bar Backlight -# Depends on: HID_SUPPORT [=y] && HID [=y] && BACKLIGHT_CLASS_DEVICE [=y] -# Location: -# -> Device Drivers -# -> HID bus support (HID_SUPPORT [=y]) -# -> HID bus core support (HID [=y]) -# -> Special HID drivers -# -> Apple Touch Bar Backlight (HID_APPLETB_BL [=n]) -# Selected by [n]: -# - HID_APPLETB_KBD [=n] && HID_SUPPORT [=y] && HID [=y] && USB_HID [=y] && BACKLIGHT_CLASS_DEVICE [=y] && INPUT [=y] -# -# -# -# Commit: 1fd41e5e3d7c (HID: hid-appletb-bl: add driver for the backlight of Apple Touch Bars) -# CONFIG_HID_APPLETB_BL is not set diff --git a/redhat/configs/pending-rhel/generic/CONFIG_HID_APPLETB_KBD b/redhat/configs/pending-rhel/generic/CONFIG_HID_APPLETB_KBD deleted file mode 100644 index blahblah..blahblah 0 --- a/redhat/configs/pending-rhel/generic/CONFIG_HID_APPLETB_KBD +++ /dev/null @@ -1,17 +0,0 @@ -# Symbol: HID_APPLETB_KBD [=n] -# Type : tristate -# Defined at drivers/hid/Kconfig:161 -# Prompt: Apple Touch Bar Keyboard Mode -# Depends on: HID_SUPPORT [=y] && HID [=y] && USB_HID [=y] && BACKLIGHT_CLASS_DEVICE [=y] && INPUT [=y] -# Location: -# -> Device Drivers -# -> HID bus support (HID_SUPPORT [=y]) -# -> HID bus core support (HID [=y]) -# -> Special HID drivers -# -> Apple Touch Bar Keyboard Mode (HID_APPLETB_KBD [=n]) -# Selects: INPUT_SPARSEKMAP [=m] && HID_APPLETB_BL [=n] -# -# -# -# Commit: 8e9b9152cfbd (HID: hid-appletb-kbd: add driver for the keyboard mode of Apple Touch Bars) -# CONFIG_HID_APPLETB_KBD is not set diff --git a/redhat/configs/pending-rhel/generic/CONFIG_HID_UNIVERSAL_PIDFF b/redhat/configs/pending-rhel/generic/CONFIG_HID_UNIVERSAL_PIDFF deleted file mode 100644 index blahblah..blahblah 0 --- a/redhat/configs/pending-rhel/generic/CONFIG_HID_UNIVERSAL_PIDFF +++ /dev/null @@ -1,16 +0,0 @@ -# Symbol: HID_UNIVERSAL_PIDFF [=n] -# Type : tristate -# Defined at drivers/hid/Kconfig:1249 -# Prompt: universal-pidff: extended USB PID driver compatibility and usage -# Depends on: HID_SUPPORT [=y] && HID [=y] && USB_HID [=y] && HID_PID [=y] -# Location: -# -> Device Drivers -# -> HID bus support (HID_SUPPORT [=y]) -# -> HID bus core support (HID [=y]) -# -> Special HID drivers -# -> universal-pidff: extended USB PID driver compatibility and usage (HID_UNIVERSAL_PIDFF [=n]) -# -# -# -# Commit: f06bf8d94fff (HID: Add hid-universal-pidff driver and supported device ids) -# CONFIG_HID_UNIVERSAL_PIDFF is not set diff --git a/redhat/configs/rhel/generic/CONFIG_HID_APPLETB_BL b/redhat/configs/rhel/generic/CONFIG_HID_APPLETB_BL new file mode 100644 index blahblah..blahblah 100644 --- /dev/null +++ b/redhat/configs/rhel/generic/CONFIG_HID_APPLETB_BL @@ -0,0 +1 @@ +# CONFIG_HID_APPLETB_BL is not set diff --git a/redhat/configs/rhel/generic/CONFIG_HID_APPLETB_KBD b/redhat/configs/rhel/generic/CONFIG_HID_APPLETB_KBD new file mode 100644 index blahblah..blahblah 100644 --- /dev/null +++ b/redhat/configs/rhel/generic/CONFIG_HID_APPLETB_KBD @@ -0,0 +1 @@ +# CONFIG_HID_APPLETB_KBD is not set diff --git a/redhat/configs/rhel/generic/CONFIG_HID_UNIVERSAL_PIDFF b/redhat/configs/rhel/generic/CONFIG_HID_UNIVERSAL_PIDFF new file mode 100644 index blahblah..blahblah 100644 --- /dev/null +++ b/redhat/configs/rhel/generic/CONFIG_HID_UNIVERSAL_PIDFF @@ -0,0 +1 @@ +# CONFIG_HID_UNIVERSAL_PIDFF is not set
-- https://gitlab.com/cki-project/kernel-ark/-/merge_requests/3757
From: Jarod Wilson on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/3757#note_2420967...
@btissoir I assume we can happily ignore the Apple Touch Bar stuff, but I have no idea about this PIDFF thingy.
From: Benjamin Tissoires on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/3757#note_2461500...
@btissoir I assume we can happily ignore the Apple Touch Bar stuff, but I
have no idea about this PIDFF thingy.
Yep, looks good to me.
PIDFF is force feedback, like in joysticks or gamepads, so having an explicit request to enable it seems good to me.
kernel@lists.fedoraproject.org