[OS-BUILD PATCH] Fix update_scripts.sh unselective pattern sub

[GitLab Bridge on behalf of jmflinuxtx]

From: David Howells <dhowells(a)redhat.com&gt;

The update_scripts.sh script doesn't correctly strip the suffix from the
end of the pathname, but will substitute for it anywhere in the path.  The
pattern really ought to have been /[.]$TARGET$//.

Fix this by using a special shell expansion to do it instead of invoking a
sed pipeline.

Signed-off-by: David Howells <dhowells(a)redhat.com&gt;
cc: Jeremy Cline <jcline(a)redhat.com&gt;
---
 redhat/update_scripts.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/redhat/update_scripts.sh b/redhat/update_scripts.sh
index bbfd6f11f058..5c3dbaeb9459 100755
--- a/redhat/update_scripts.sh
+++ b/redhat/update_scripts.sh
@@ -7,6 +7,6 @@ fi
 TARGET=$1
 
 for i in $RPM_SOURCE_DIR/*.$TARGET; do
-	NEW=`echo $i | sed s/.$TARGET//`
+	NEW=${i%.$TARGET}
 	cp $i $NEW
 done
-- 
2.26.2

[GitLab Bridge on behalf of Justin Forbes]

From: Justin Forbes on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/389#note_35198...

This was already reviewed on list, but it came through list and the mail
gateway didn't create a MR for some reason.

[Jiri Benc]

On Fri, 29 May 2020 16:00:57 -0000, GitLab Bridge on behalf of jmflinuxtx wrote:
>  From: David Howells <dhowells(a)redhat.com&gt;
>  
>  The update_scripts.sh script doesn't correctly strip the suffix from the
>  end of the pathname, but will substitute for it anywhere in the path.  The
>  pattern really ought to have been /[.]$TARGET$//.
>  
>  Fix this by using a special shell expansion to do it instead of invoking a
>  sed pipeline.
>  
>  Signed-off-by: David Howells <dhowells(a)redhat.com&gt;
>  cc: Jeremy Cline <jcline(a)redhat.com&gt; 
Not sure we need to ack again, in case we do:

Acked-by: Jiri Benc <jbenc(a)redhat.com&gt;

[Prarit Bhargava]

On 5/29/20 12:00 PM, GitLab Bridge on behalf of jmflinuxtx wrote:
>  From: David Howells <dhowells(a)redhat.com&gt;
>
>  The update_scripts.sh script doesn't correctly strip the suffix from the
>  end of the pathname, but will substitute for it anywhere in the path.  The
>  pattern really ought to have been /[.]$TARGET$//.
>
>  Fix this by using a special shell expansion to do it instead of invoking a
>  sed pipeline.
>
>  Signed-off-by: David Howells <dhowells(a)redhat.com&gt;
>  cc: Jeremy Cline <jcline(a)redhat.com&gt;
>  ---
>   redhat/update_scripts.sh | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-) 
Acked-by: Prarit Bhargava <prarit(a)redhat.com&gt;

P.