From: "CKI@GitLab" cki-project@redhat.com
Hi,
As part of the ongoing rebase effort, the following configuration options need to be reviewed.
As a reminder, the ARK configuration flow involves moving unreviewed configuration options from the pending directory to the ark directory. In the diff below, options are removed from the pending directory and added to the ark hierarchy. The final options that need to be ACKed are the files that are being added to the ark hierarchy.
If the value for a file that is added should be changed, please reply with a better option.
CONFIG_ZSMALLOC_PGTABLE_MAPPING:
By default, zsmalloc uses a copy-based object mapping method to access allocations that span two pages. However, if a particular architecture (ex, ARM) performs VM mapping faster than copying, then you should select this. This causes zsmalloc to use page table mapping rather than copying for object mapping.
You can check speed with zsmalloc benchmark: https://github.com/spartacus06/zsmapbench
Symbol: ZSMALLOC_PGTABLE_MAPPING [=n] Type : bool Defined at mm/Kconfig:708 Prompt: Use page table mapping to access object in zsmalloc Depends on: ZSMALLOC [=y]=y Location: -> Memory Management options -> Memory allocator for compressed pages (ZSMALLOC [=y])
---
Signed-off-by: CKI@GitLab cki-project@redhat.com --- .../generic/CONFIG_ZSMALLOC_PGTABLE_MAPPING | 1 + .../generic/CONFIG_ZSMALLOC_PGTABLE_MAPPING | 23 ------------------- 2 files changed, 1 insertion(+), 23 deletions(-) create mode 100644 redhat/configs/common/generic/CONFIG_ZSMALLOC_PGTABLE_MAPPING delete mode 100644 redhat/configs/pending-common/generic/CONFIG_ZSMALLOC_PGTABLE_MAPPING
diff --git a/redhat/configs/common/generic/CONFIG_ZSMALLOC_PGTABLE_MAPPING b/redhat/configs/common/generic/CONFIG_ZSMALLOC_PGTABLE_MAPPING new file mode 100644 index 000000000000..502c3e374887 --- /dev/null +++ b/redhat/configs/common/generic/CONFIG_ZSMALLOC_PGTABLE_MAPPING @@ -0,0 +1 @@ +# CONFIG_ZSMALLOC_PGTABLE_MAPPING is not set diff --git a/redhat/configs/pending-common/generic/CONFIG_ZSMALLOC_PGTABLE_MAPPING b/redhat/configs/pending-common/generic/CONFIG_ZSMALLOC_PGTABLE_MAPPING deleted file mode 100644 index 2f3d89cf6004..000000000000 --- a/redhat/configs/pending-common/generic/CONFIG_ZSMALLOC_PGTABLE_MAPPING +++ /dev/null @@ -1,23 +0,0 @@ -# CONFIG_ZSMALLOC_PGTABLE_MAPPING: -# -# By default, zsmalloc uses a copy-based object mapping method to -# access allocations that span two pages. However, if a particular -# architecture (ex, ARM) performs VM mapping faster than copying, -# then you should select this. This causes zsmalloc to use page table -# mapping rather than copying for object mapping. -# -# You can check speed with zsmalloc benchmark: -# https://github.com/spartacus06/zsmapbench -# -# Symbol: ZSMALLOC_PGTABLE_MAPPING [=n] -# Type : bool -# Defined at mm/Kconfig:708 -# Prompt: Use page table mapping to access object in zsmalloc -# Depends on: ZSMALLOC [=y]=y -# Location: -# -> Memory Management options -# -> Memory allocator for compressed pages (ZSMALLOC [=y]) -# -# -# -# CONFIG_ZSMALLOC_PGTABLE_MAPPING is not set
On 6/3/20 1:14 PM, GitLab Bridge on behalf of jeremycline wrote:
From: "CKI@GitLab" cki-project@redhat.com
Hi,
As part of the ongoing rebase effort, the following configuration options need to be reviewed.
aquini, please review.
Thanks,
P.
As a reminder, the ARK configuration flow involves moving unreviewed configuration options from the pending directory to the ark directory. In the diff below, options are removed from the pending directory and added to the ark hierarchy. The final options that need to be ACKed are the files that are being added to the ark hierarchy.
If the value for a file that is added should be changed, please reply with a better option.
CONFIG_ZSMALLOC_PGTABLE_MAPPING:
By default, zsmalloc uses a copy-based object mapping method to access allocations that span two pages. However, if a particular architecture (ex, ARM) performs VM mapping faster than copying, then you should select this. This causes zsmalloc to use page table mapping rather than copying for object mapping.
You can check speed with zsmalloc benchmark: https://github.com/spartacus06/zsmapbench
Symbol: ZSMALLOC_PGTABLE_MAPPING [=n] Type : bool Defined at mm/Kconfig:708 Prompt: Use page table mapping to access object in zsmalloc Depends on: ZSMALLOC [=y]=y Location: -> Memory Management options -> Memory allocator for compressed pages (ZSMALLOC [=y])
Signed-off-by: CKI@GitLab cki-project@redhat.com
.../generic/CONFIG_ZSMALLOC_PGTABLE_MAPPING | 1 + .../generic/CONFIG_ZSMALLOC_PGTABLE_MAPPING | 23 ------------------- 2 files changed, 1 insertion(+), 23 deletions(-) create mode 100644 redhat/configs/common/generic/CONFIG_ZSMALLOC_PGTABLE_MAPPING delete mode 100644
redhat/configs/pending-common/generic/CONFIG_ZSMALLOC_PGTABLE_MAPPING
diff --git a/redhat/configs/common/generic/CONFIG_ZSMALLOC_PGTABLE_MAPPING
b/redhat/configs/common/generic/CONFIG_ZSMALLOC_PGTABLE_MAPPING
new file mode 100644 index 000000000000..502c3e374887 --- /dev/null +++ b/redhat/configs/common/generic/CONFIG_ZSMALLOC_PGTABLE_MAPPING @@ -0,0 +1 @@ +# CONFIG_ZSMALLOC_PGTABLE_MAPPING is not set diff --git
a/redhat/configs/pending-common/generic/CONFIG_ZSMALLOC_PGTABLE_MAPPING b/redhat/configs/pending-common/generic/CONFIG_ZSMALLOC_PGTABLE_MAPPING
deleted file mode 100644 index 2f3d89cf6004..000000000000 --- a/redhat/configs/pending-common/generic/CONFIG_ZSMALLOC_PGTABLE_MAPPING +++ /dev/null @@ -1,23 +0,0 @@ -# CONFIG_ZSMALLOC_PGTABLE_MAPPING: -# -# By default, zsmalloc uses a copy-based object mapping method to -# access allocations that span two pages. However, if a particular -# architecture (ex, ARM) performs VM mapping faster than copying, -# then you should select this. This causes zsmalloc to use page table -# mapping rather than copying for object mapping. -# -# You can check speed with zsmalloc benchmark: -# https://github.com/spartacus06/zsmapbench -# -# Symbol: ZSMALLOC_PGTABLE_MAPPING [=n] -# Type : bool -# Defined at mm/Kconfig:708 -# Prompt: Use page table mapping to access object in zsmalloc -# Depends on: ZSMALLOC [=y]=y -# Location: -# -> Memory Management options -# -> Memory allocator for compressed pages (ZSMALLOC [=y]) -# -# -# -# CONFIG_ZSMALLOC_PGTABLE_MAPPING is not set
:wq
From: "CKI@GitLab" CKI@GitLab
Hi,
As part of the ongoing rebase effort, the following configuration options need to be reviewed.
As a reminder, the ARK configuration flow involves moving unreviewed configuration options from the pending directory to the ark directory. In the diff below, options are removed from the pending directory and added to the ark hierarchy. The final options that need to be ACKed are the files that are being added to the ark hierarchy.
If the value for a file that is added should be changed, please reply with a better option.
CONFIG_ZSMALLOC_PGTABLE_MAPPING:
By default, zsmalloc uses a copy-based object mapping method to access allocations that span two pages. However, if a particular architecture (ex, ARM) performs VM mapping faster than copying, then you should select this. This causes zsmalloc to use page table mapping rather than copying for object mapping.
You can check speed with zsmalloc benchmark: https://github.com/spartacus06/zsmapbench
Symbol: ZSMALLOC_PGTABLE_MAPPING [=n] Type : bool Defined at mm/Kconfig:708 Prompt: Use page table mapping to access object in zsmalloc Depends on: ZSMALLOC [=y]=y Location: -> Memory Management options -> Memory allocator for compressed pages (ZSMALLOC [=y])
Cc: Rafael Aquini aquini@redhat.com --- .../generic/CONFIG_ZSMALLOC_PGTABLE_MAPPING | 1 + .../generic/CONFIG_ZSMALLOC_PGTABLE_MAPPING | 23 ------------------- 2 files changed, 1 insertion(+), 23 deletions(-) create mode 100644 redhat/configs/common/generic/CONFIG_ZSMALLOC_PGTABLE_MAPPING delete mode 100644 redhat/configs/pending-common/generic/CONFIG_ZSMALLOC_PGTABLE_MAPPING
diff --git a/redhat/configs/common/generic/CONFIG_ZSMALLOC_PGTABLE_MAPPING b/redhat/configs/common/generic/CONFIG_ZSMALLOC_PGTABLE_MAPPING new file mode 100644 index 000000000000..502c3e374887 --- /dev/null +++ b/redhat/configs/common/generic/CONFIG_ZSMALLOC_PGTABLE_MAPPING @@ -0,0 +1 @@ +# CONFIG_ZSMALLOC_PGTABLE_MAPPING is not set diff --git a/redhat/configs/pending-common/generic/CONFIG_ZSMALLOC_PGTABLE_MAPPING b/redhat/configs/pending-common/generic/CONFIG_ZSMALLOC_PGTABLE_MAPPING deleted file mode 100644 index 2f3d89cf6004..000000000000 --- a/redhat/configs/pending-common/generic/CONFIG_ZSMALLOC_PGTABLE_MAPPING +++ /dev/null @@ -1,23 +0,0 @@ -# CONFIG_ZSMALLOC_PGTABLE_MAPPING: -# -# By default, zsmalloc uses a copy-based object mapping method to -# access allocations that span two pages. However, if a particular -# architecture (ex, ARM) performs VM mapping faster than copying, -# then you should select this. This causes zsmalloc to use page table -# mapping rather than copying for object mapping. -# -# You can check speed with zsmalloc benchmark: -# https://github.com/spartacus06/zsmapbench -# -# Symbol: ZSMALLOC_PGTABLE_MAPPING [=n] -# Type : bool -# Defined at mm/Kconfig:708 -# Prompt: Use page table mapping to access object in zsmalloc -# Depends on: ZSMALLOC [=y]=y -# Location: -# -> Memory Management options -# -> Memory allocator for compressed pages (ZSMALLOC [=y]) -# -# -# -# CONFIG_ZSMALLOC_PGTABLE_MAPPING is not set
From: Patrick Talbert on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/406#note_49412132...
This merge request has not been updated in over 90 days. Please review this MR's current changes regarding the following configuration option(s):
CONFIG_ZSMALLOC_PGTABLE_MAPPING
From: Rafael Aquini on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/406#note_53581617...
Acked-by: Rafael Aquini aquini@redhat.com
kernel@lists.fedoraproject.org
-
cki-gitlab＠redhat.com -
GitLab Bridge on behalf of jeremycline
-
GitLab Bridge on behalf of jeremycline -
Prarit Bhargava -
Rafael Aquini (via Email Bridge)