[OS-BUILD PATCH] [redhat] New configs in drivers/iommu

[GitLab Bridge on behalf of jeremycline]

From: Fedora Kernel Team <kernel-team(a)fedoraproject.org&gt;

Hi,

As part of the ongoing rebase effort, the following configuration
options need to be reviewed.

As a reminder, the ARK configuration flow involves moving unreviewed
configuration options from the pending directory to the ark directory.
In the diff below, options are removed from the pending directory and
added to the ark hierarchy. The final options that need to be ACKed
are the files that are being added to the ark hierarchy.

If the value for a file that is added should be changed, please reply
with a better option.

 CONFIG_ARM_SMMU_V3_SVA:

 Support for sharing process address spaces with devices using the
 SMMUv3.

 Say Y here if your system supports SVA extensions such as PCIe PASID
 and PRI.

 Symbol: ARM_SMMU_V3_SVA [=n]
 Type  : bool
 Defined at drivers/iommu/Kconfig:311
   Prompt: Shared Virtual Addressing support for the ARM SMMUv3
   Depends on: IOMMU_SUPPORT [=y] && ARM_SMMU_V3 [=y]
   Location:
     -> Device Drivers
       -> IOMMU Hardware Support (IOMMU_SUPPORT [=y])
         -> ARM Ltd. System MMU Version 3 (SMMUv3) Support (ARM_SMMU_V3 [=y])

---

Cc: Jerry Snitselaar <jsnitsel(a)redhat.com&gt;
Cc: Myron Stowe <myron.stowe(a)redhat.com&gt;
Cc: Alex Williamson <alex.williamson(a)redhat.com&gt;
Cc: Don Dutile <ddutile(a)redhat.com&gt;
Signed-off-by: Fedora Kernel Team <kernel-team(a)fedoraproject.org&gt;
---
 .../common/generic/CONFIG_ARM_SMMU_V3_SVA     |  1 +
 .../generic/CONFIG_ARM_SMMU_V3_SVA            | 21 -------------------
 2 files changed, 1 insertion(+), 21 deletions(-)
 create mode 100644 redhat/configs/common/generic/CONFIG_ARM_SMMU_V3_SVA
 delete mode 100644 redhat/configs/pending-common/generic/CONFIG_ARM_SMMU_V3_SVA

diff --git a/redhat/configs/common/generic/CONFIG_ARM_SMMU_V3_SVA
b/redhat/configs/common/generic/CONFIG_ARM_SMMU_V3_SVA
new file mode 100644
index 000000000000..425c8fb90256
--- /dev/null
+++ b/redhat/configs/common/generic/CONFIG_ARM_SMMU_V3_SVA
@@ -0,0 +1 @@
+# CONFIG_ARM_SMMU_V3_SVA is not set
diff --git a/redhat/configs/pending-common/generic/CONFIG_ARM_SMMU_V3_SVA
b/redhat/configs/pending-common/generic/CONFIG_ARM_SMMU_V3_SVA
deleted file mode 100644
index 32cecc4a00f8..000000000000
--- a/redhat/configs/pending-common/generic/CONFIG_ARM_SMMU_V3_SVA
+++ /dev/null
@@ -1,21 +0,0 @@
-# CONFIG_ARM_SMMU_V3_SVA:
-# 
-# Support for sharing process address spaces with devices using the
-# SMMUv3.
-# 
-# Say Y here if your system supports SVA extensions such as PCIe PASID
-# and PRI.
-# 
-# Symbol: ARM_SMMU_V3_SVA [=n]
-# Type  : bool
-# Defined at drivers/iommu/Kconfig:311
-#   Prompt: Shared Virtual Addressing support for the ARM SMMUv3
-#   Depends on: IOMMU_SUPPORT [=y] && ARM_SMMU_V3 [=y]
-#   Location:
-#     -> Device Drivers
-#       -> IOMMU Hardware Support (IOMMU_SUPPORT [=y])
-#         -> ARM Ltd. System MMU Version 3 (SMMUv3) Support (ARM_SMMU_V3 [=y])
-# 
-# 
-# 
-# CONFIG_ARM_SMMU_V3_SVA is not set
-- 
GitLab

[Jerry Snitselaar]

GitLab Bridge on behalf of jeremycline @ 2020-10-16 08:29 MST:

>  From: Fedora Kernel Team <kernel-team(a)fedoraproject.org&gt;
>
>  Hi,
>
>  As part of the ongoing rebase effort, the following configuration
>  options need to be reviewed.
>
>  As a reminder, the ARK configuration flow involves moving unreviewed
>  configuration options from the pending directory to the ark directory.
>  In the diff below, options are removed from the pending directory and
>  added to the ark hierarchy. The final options that need to be ACKed
>  are the files that are being added to the ark hierarchy.
>
>  If the value for a file that is added should be changed, please reply
>  with a better option.
>
>   CONFIG_ARM_SMMU_V3_SVA:
>
>   Support for sharing process address spaces with devices using the
>   SMMUv3.
>
>   Say Y here if your system supports SVA extensions such as PCIe PASID
>   and PRI.
>
>   Symbol: ARM_SMMU_V3_SVA [=n]
>   Type  : bool
>   Defined at drivers/iommu/Kconfig:311
>     Prompt: Shared Virtual Addressing support for the ARM SMMUv3
>     Depends on: IOMMU_SUPPORT [=y] && ARM_SMMU_V3 [=y]
>     Location:
>       -> Device Drivers
>         -> IOMMU Hardware Support (IOMMU_SUPPORT [=y])
>           -> ARM Ltd. System MMU Version 3 (SMMUv3) Support (ARM_SMMU_V3 [=y])
>
>  ---
>
>  Cc: Jerry Snitselaar <jsnitsel(a)redhat.com&gt;
>  Cc: Myron Stowe <myron.stowe(a)redhat.com&gt;
>  Cc: Alex Williamson <alex.williamson(a)redhat.com&gt;
>  Cc: Don Dutile <ddutile(a)redhat.com&gt;
>  Signed-off-by: Fedora Kernel Team <kernel-team(a)fedoraproject.org&gt;
>  ---
>   .../common/generic/CONFIG_ARM_SMMU_V3_SVA     |  1 +
>   .../generic/CONFIG_ARM_SMMU_V3_SVA            | 21 -------------------
>   2 files changed, 1 insertion(+), 21 deletions(-)
>   create mode 100644 redhat/configs/common/generic/CONFIG_ARM_SMMU_V3_SVA
>   delete mode 100644 redhat/configs/pending-common/generic/CONFIG_ARM_SMMU_V3_SVA
>
>  diff --git a/redhat/configs/common/generic/CONFIG_ARM_SMMU_V3_SVA
> b/redhat/configs/common/generic/CONFIG_ARM_SMMU_V3_SVA
>  new file mode 100644
>  index 000000000000..425c8fb90256
>  --- /dev/null
>  +++ b/redhat/configs/common/generic/CONFIG_ARM_SMMU_V3_SVA
>  @@ -0,0 +1 @@
>  +# CONFIG_ARM_SMMU_V3_SVA is not set
>  diff --git a/redhat/configs/pending-common/generic/CONFIG_ARM_SMMU_V3_SVA
> b/redhat/configs/pending-common/generic/CONFIG_ARM_SMMU_V3_SVA
>  deleted file mode 100644
>  index 32cecc4a00f8..000000000000
>  --- a/redhat/configs/pending-common/generic/CONFIG_ARM_SMMU_V3_SVA
>  +++ /dev/null
>  @@ -1,21 +0,0 @@
>  -# CONFIG_ARM_SMMU_V3_SVA:
>  -# 
>  -# Support for sharing process address spaces with devices using the
>  -# SMMUv3.
>  -# 
>  -# Say Y here if your system supports SVA extensions such as PCIe PASID
>  -# and PRI.
>  -# 
>  -# Symbol: ARM_SMMU_V3_SVA [=n]
>  -# Type  : bool
>  -# Defined at drivers/iommu/Kconfig:311
>  -#   Prompt: Shared Virtual Addressing support for the ARM SMMUv3
>  -#   Depends on: IOMMU_SUPPORT [=y] && ARM_SMMU_V3 [=y]
>  -#   Location:
>  -#     -> Device Drivers
>  -#       -> IOMMU Hardware Support (IOMMU_SUPPORT [=y])
>  -#         -> ARM Ltd. System MMU Version 3 (SMMUv3) Support (ARM_SMMU_V3 [=y])
>  -# 
>  -# 
>  -# 
>  -# CONFIG_ARM_SMMU_V3_SVA is not set 
Would like to enable this, so can this be changed to

CONFIG_ARM_SMMU_V3_SVA=y

and I imagine it should be moved somewhere under common/generic/arm

[Don Dutile]

On 10/21/20 1:03 PM, Jerry Snitselaar wrote:
>  GitLab Bridge on behalf of jeremycline @ 2020-10-16 08:29 MST:
>
> > From: Fedora Kernel Team <kernel-team(a)fedoraproject.org&gt;
> >
> > Hi,
> >
> > As part of the ongoing rebase effort, the following configuration
> > options need to be reviewed.
> >
> > As a reminder, the ARK configuration flow involves moving unreviewed
> > configuration options from the pending directory to the ark directory.
> > In the diff below, options are removed from the pending directory and
> > added to the ark hierarchy. The final options that need to be ACKed
> > are the files that are being added to the ark hierarchy.
> >
> > If the value for a file that is added should be changed, please reply
> > with a better option.
> >
> >   CONFIG_ARM_SMMU_V3_SVA:
> >
> >   Support for sharing process address spaces with devices using the
> >   SMMUv3.
> >
> >   Say Y here if your system supports SVA extensions such as PCIe PASID
> >   and PRI.
> >
> >   Symbol: ARM_SMMU_V3_SVA [=n]
> >   Type  : bool
> >   Defined at drivers/iommu/Kconfig:311
> >     Prompt: Shared Virtual Addressing support for the ARM SMMUv3
> >     Depends on: IOMMU_SUPPORT [=y] && ARM_SMMU_V3 [=y]
> >     Location:
> >       -> Device Drivers
> >         -> IOMMU Hardware Support (IOMMU_SUPPORT [=y])
> >           -> ARM Ltd. System MMU Version 3 (SMMUv3) Support (ARM_SMMU_V3 [=y])
> >
> > ---
> >
> > Cc: Jerry Snitselaar <jsnitsel(a)redhat.com&gt;
> > Cc: Myron Stowe <myron.stowe(a)redhat.com&gt;
> > Cc: Alex Williamson <alex.williamson(a)redhat.com&gt;
> > Cc: Don Dutile <ddutile(a)redhat.com&gt;
> > Signed-off-by: Fedora Kernel Team <kernel-team(a)fedoraproject.org&gt;
> > ---
> >   .../common/generic/CONFIG_ARM_SMMU_V3_SVA     |  1 +
> >   .../generic/CONFIG_ARM_SMMU_V3_SVA            | 21 -------------------
> >   2 files changed, 1 insertion(+), 21 deletions(-)
> >   create mode 100644 redhat/configs/common/generic/CONFIG_ARM_SMMU_V3_SVA
> >   delete mode 100644 redhat/configs/pending-common/generic/CONFIG_ARM_SMMU_V3_SVA
> >
> > diff --git a/redhat/configs/common/generic/CONFIG_ARM_SMMU_V3_SVA
> b/redhat/configs/common/generic/CONFIG_ARM_SMMU_V3_SVA
> > new file mode 100644
> > index 000000000000..425c8fb90256
> > --- /dev/null
> > +++ b/redhat/configs/common/generic/CONFIG_ARM_SMMU_V3_SVA
> > @@ -0,0 +1 @@
> > +# CONFIG_ARM_SMMU_V3_SVA is not set
> > diff --git a/redhat/configs/pending-common/generic/CONFIG_ARM_SMMU_V3_SVA
> b/redhat/configs/pending-common/generic/CONFIG_ARM_SMMU_V3_SVA
> > deleted file mode 100644
> > index 32cecc4a00f8..000000000000
> > --- a/redhat/configs/pending-common/generic/CONFIG_ARM_SMMU_V3_SVA
> > +++ /dev/null
> > @@ -1,21 +0,0 @@
> > -# CONFIG_ARM_SMMU_V3_SVA:
> > -#
> > -# Support for sharing process address spaces with devices using the
> > -# SMMUv3.
> > -#
> > -# Say Y here if your system supports SVA extensions such as PCIe PASID
> > -# and PRI.
> > -#
> > -# Symbol: ARM_SMMU_V3_SVA [=n]
> > -# Type  : bool
> > -# Defined at drivers/iommu/Kconfig:311
> > -#   Prompt: Shared Virtual Addressing support for the ARM SMMUv3
> > -#   Depends on: IOMMU_SUPPORT [=y] && ARM_SMMU_V3 [=y]
> > -#   Location:
> > -#     -> Device Drivers
> > -#       -> IOMMU Hardware Support (IOMMU_SUPPORT [=y])
> > -#         -> ARM Ltd. System MMU Version 3 (SMMUv3) Support (ARM_SMMU_V3 [=y])
> > -#
> > -#
> > -#
> > -# CONFIG_ARM_SMMU_V3_SVA is not set
>  Would like to enable this, so can this be changed to
>
>  CONFIG_ARM_SMMU_V3_SVA=y 
        ^^^^^
ah yes.... seems like this is a common problem with many of these config's that are
arch-specific (i.e., improperly put in non-arch, common area).
... btw: common + generic ... what am I missing that one of those names isn't
redundant?

>  and I imagine it should be moved somewhere under common/generic/arm
>

[Jerry Snitselaar]

Don Dutile @ 2020-10-21 20:53 MST:

>  On 10/21/20 1:03 PM, Jerry Snitselaar wrote:
> > GitLab Bridge on behalf of jeremycline @ 2020-10-16 08:29 MST:
> >
> >> From: Fedora Kernel Team <kernel-team(a)fedoraproject.org&gt;
> >>
> >> Hi,
> >>
> >> As part of the ongoing rebase effort, the following configuration
> >> options need to be reviewed.
> >>
> >> As a reminder, the ARK configuration flow involves moving unreviewed
> >> configuration options from the pending directory to the ark directory.
> >> In the diff below, options are removed from the pending directory and
> >> added to the ark hierarchy. The final options that need to be ACKed
> >> are the files that are being added to the ark hierarchy.
> >>
> >> If the value for a file that is added should be changed, please reply
> >> with a better option.
> >>
> >>   CONFIG_ARM_SMMU_V3_SVA:
> >>
> >>   Support for sharing process address spaces with devices using the
> >>   SMMUv3.
> >>
> >>   Say Y here if your system supports SVA extensions such as PCIe PASID
> >>   and PRI.
> >>
> >>   Symbol: ARM_SMMU_V3_SVA [=n]
> >>   Type  : bool
> >>   Defined at drivers/iommu/Kconfig:311
> >>     Prompt: Shared Virtual Addressing support for the ARM SMMUv3
> >>     Depends on: IOMMU_SUPPORT [=y] && ARM_SMMU_V3 [=y]
> >>     Location:
> >>       -> Device Drivers
> >>         -> IOMMU Hardware Support (IOMMU_SUPPORT [=y])
> >>           -> ARM Ltd. System MMU Version 3 (SMMUv3) Support (ARM_SMMU_V3
> [=y])
> >>
> >> ---
> >>
> >> Cc: Jerry Snitselaar <jsnitsel(a)redhat.com&gt;
> >> Cc: Myron Stowe <myron.stowe(a)redhat.com&gt;
> >> Cc: Alex Williamson <alex.williamson(a)redhat.com&gt;
> >> Cc: Don Dutile <ddutile(a)redhat.com&gt;
> >> Signed-off-by: Fedora Kernel Team <kernel-team(a)fedoraproject.org&gt;
> >> ---
> >>   .../common/generic/CONFIG_ARM_SMMU_V3_SVA     |  1 +
> >>   .../generic/CONFIG_ARM_SMMU_V3_SVA            | 21 -------------------
> >>   2 files changed, 1 insertion(+), 21 deletions(-)
> >>   create mode 100644 redhat/configs/common/generic/CONFIG_ARM_SMMU_V3_SVA
> >>   delete mode 100644
> redhat/configs/pending-common/generic/CONFIG_ARM_SMMU_V3_SVA
> >>
> >> diff --git a/redhat/configs/common/generic/CONFIG_ARM_SMMU_V3_SVA
> b/redhat/configs/common/generic/CONFIG_ARM_SMMU_V3_SVA
> >> new file mode 100644
> >> index 000000000000..425c8fb90256
> >> --- /dev/null
> >> +++ b/redhat/configs/common/generic/CONFIG_ARM_SMMU_V3_SVA
> >> @@ -0,0 +1 @@
> >> +# CONFIG_ARM_SMMU_V3_SVA is not set
> >> diff --git a/redhat/configs/pending-common/generic/CONFIG_ARM_SMMU_V3_SVA
> b/redhat/configs/pending-common/generic/CONFIG_ARM_SMMU_V3_SVA
> >> deleted file mode 100644
> >> index 32cecc4a00f8..000000000000
> >> --- a/redhat/configs/pending-common/generic/CONFIG_ARM_SMMU_V3_SVA
> >> +++ /dev/null
> >> @@ -1,21 +0,0 @@
> >> -# CONFIG_ARM_SMMU_V3_SVA:
> >> -#
> >> -# Support for sharing process address spaces with devices using the
> >> -# SMMUv3.
> >> -#
> >> -# Say Y here if your system supports SVA extensions such as PCIe PASID
> >> -# and PRI.
> >> -#
> >> -# Symbol: ARM_SMMU_V3_SVA [=n]
> >> -# Type  : bool
> >> -# Defined at drivers/iommu/Kconfig:311
> >> -#   Prompt: Shared Virtual Addressing support for the ARM SMMUv3
> >> -#   Depends on: IOMMU_SUPPORT [=y] && ARM_SMMU_V3 [=y]
> >> -#   Location:
> >> -#     -> Device Drivers
> >> -#       -> IOMMU Hardware Support (IOMMU_SUPPORT [=y])
> >> -#         -> ARM Ltd. System MMU Version 3 (SMMUv3) Support (ARM_SMMU_V3
> [=y])
> >> -#
> >> -#
> >> -#
> >> -# CONFIG_ARM_SMMU_V3_SVA is not set
> > Would like to enable this, so can this be changed to
> >
> > CONFIG_ARM_SMMU_V3_SVA=y
>         ^^^^^
>  ah yes.... seems like this is a common problem with many of these config's that are
> arch-specific (i.e., improperly put in non-arch, common area).
>  ... btw: common + generic ... what am I missing that one of those names isn't
> redundant?
>  
common I believe means common to all the distributions (ark, fedora),
and generic along with debug is the top level at distribution. There are
directories inside generic that can limit things based on arch.

> >
> > and I imagine it should be moved somewhere under common/generic/arm
> >

From: CKI Bot on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/711#note_49157...

Hi! This is the friendly CKI test bot.

It appears that you are not a member of redhat/red-hat-ci-
tools/kernel/cki-runs/trusted-pipelines. This means that the CI
pipeline on your MR will fail. As getting testing is important, I'll be
responsible for testing your changes. After every MR change, I'll start
a
small testing pipeline and link it here so you can follow the results.
I'll
also create and link a pipeline for hardware testing that the reviewers
can
start to get extra test coverage.

From: CKI Bot on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/711#note_49157...

Testing pipeline status:
Basic testing pipeline:

  https://gitlab.com/redhat/red-hat-ci-tools/kernel/cki-
runs/external-pipelines/-/pipelines/245422717 - created
:hourglass_flowing_sand:

From: Patrick Talbert on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/711#note_49157...

Hello Jerry, Don,

The file structure is redhat/configs/<dist>/<build>/<arch>/

- <dist> is one of 'ark', 'fedora', or 'common'.
- <build> is either 'generic' or 'debug'.
- <arch> is an optional arch :).


Anyway, I have updated the MR so that `ARM_SMMU_V3_SVA` is enabled and
lives under redhat/configs/common/generic/arm/aarch64/. Please re-
review!

All commits in this MR will be squashed upon merge.


Thank you,

Patrick