[PATCH] Add -r to debuginfo_args to invoke eu-strip --reloc-debug-sections.

[Mark Wielaard]

The -r flag to find-debuginfo.sh to invoke eu-strip --reloc-debug-sections
reduces the number of unnecessary relocations in kernel module .ko.debug
files. This saves ~500MB on the installed size of the kernel-debuginfo
package and makes the rpm file ~30MB smaller.
---
 kernel.spec |   12 +++++++++---
 1 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/kernel.spec b/kernel.spec
index 1f801f0..b9715fe 100644
--- a/kernel.spec
+++ b/kernel.spec
@@ -54,7 +54,7 @@ Summary: The Linux kernel
 # For non-released -rc kernels, this will be appended after the rcX and
 # gitX tags, so a 3 here would become part of release "0.rcX.gitX.3"
 #
-%global baserelease 2
+%global baserelease 3
 %global fedora_build %{baserelease}

# base_sublevel is the kernel version we're starting with and patching
@@ -566,8 +566,11 @@ BuildRequires: pciutils-devel gettext
 BuildConflicts: rhbuildsys(DiskFree) < 500Mb
 %if %{with_debuginfo}
 # Fancy new debuginfo generation introduced in Fedora 8/RHEL 6.
-BuildRequires: rpm-build >= 4.4.2.1-4
-%define debuginfo_args --strict-build-id
+# The -r flag to find-debuginfo.sh to invoke eu-strip --reloc-debug-sections
+# reduces the number of relocations in kernel module .ko.debug files and was
+# introduced with rpm 4.9 and elfutils 0.153.
+BuildRequires: rpm-build >= 4.9.0-1, elfutils >= elfutils-0.153-1
+%define debuginfo_args --strict-build-id -r
 %endif

Source0: ftp://ftp.kernel.org/pub/linux/kernel/v3.0/linux-%{kversion}.tar.xz
@@ -2376,6 +2379,9 @@ fi
 #                 ||----w |
 #                 ||     ||
 %changelog
+* Wed Feb 29 2012 Mark Wielaard  - 3.3.0-0.rc5.git2.3
+- Add -r to debuginfo_args to invoke eu-strip --reloc-debug-sections.
+
 * Tue Feb 28 2012 Josh Boyer 
 - Add patch to enable keyboard backlight on Sony laptops (rhbz 728478)

[Mark Wielaard]

On Wed, 2012-02-29 at 14:55 +0100, Mark Wielaard wrote:
> The -r flag to find-debuginfo.sh to invoke eu-strip --reloc-debug-sections
> reduces the number of unnecessary relocations in kernel module .ko.debug
> files. This saves ~500MB on the installed size of the kernel-debuginfo
> package and makes the rpm file ~30MB smaller.

Ping. Attached is a rebase of the same patch to current kernel master
(without spec bump to make merging easier). As explained on irc I did
test this on various arches and against a full make installcheck run of
systemtap to make sure things work as expected. If there is anything
else I can do to get this patch in please let me know.

Thanks,

Mark

[Josh Boyer]

On Mon, Mar 05, 2012 at 10:59:35AM +0100, Mark Wielaard wrote:
> On Wed, 2012-02-29 at 14:55 +0100, Mark Wielaard wrote:
> > The -r flag to find-debuginfo.sh to invoke eu-strip --reloc-debug-sections
> > reduces the number of unnecessary relocations in kernel module .ko.debug
> > files. This saves ~500MB on the installed size of the kernel-debuginfo
> > package and makes the rpm file ~30MB smaller.
>
> Ping. Attached is a rebase of the same patch to current kernel master
> (without spec bump to make merging easier). As explained on irc I did
> test this on various arches and against a full make installcheck run of
> systemtap to make sure things work as expected. If there is anything
> else I can do to get this patch in please let me know.

I think you forgot to attach the rebase, but it was trivial to fix up
from the original patch anyway.  I've committed and pushed your change
to f17/rawhide now.

Thanks much for the great patch.

josh