From: Scott Weaver scweaver@redhat.com
redhat/kernel.spec: drop bindgen build requirement for ELN
CentOS Stream 10 and RHEL 10 do not maintain a bindgen package, and it is not currently required to build ELN. Therefore, remove it so that we can build kernel-ark in brew.
Signed-off-by: Scott Weaver scweaver@redhat.com
diff --git a/redhat/kernel.spec.template b/redhat/kernel.spec.template index blahblah..blahblah 100644 --- a/redhat/kernel.spec.template +++ b/redhat/kernel.spec.template @@ -706,7 +706,12 @@ BuildRequires: bzip2, xz, findutils, m4, perl-interpreter, perl-Carp, perl-devel BuildRequires: zstd %endif BuildRequires: gcc, binutils, redhat-rpm-config, hmaccalc, bison, flex, gcc-c++ +%if 0%{?fedora} BuildRequires: rust, rust-src, bindgen, rustfmt, clippy +%else +# CS/RHEL does not maintain a bindgen package +BuildRequires: rust, rust-src, rustfmt, clippy +%endif BuildRequires: net-tools, hostname, bc, elfutils-devel BuildRequires: dwarves BuildRequires: python3
-- https://gitlab.com/cki-project/kernel-ark/-/merge_requests/3843
From: Jan Stancek on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/3843#note_2472570...
It was introduced with `enable Rust code in ELN`, what's the impact of removing it for ELN?
From: Scott Weaver on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/3843#note_2473484...
There isn't currently a build time dependency on bindgen that I could find when building the ELN kernel and I'm not sure why it was included when Rust was enabled for rawhide. I don't that it's required to build rawhide either but maybe Asahi needs it? It was originally included in `redhat: Turn on support for Rust code in Fedora`. It might be that at some point it could become a build dep for ELN but right now it isn't required.
From: Jan Stancek on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/3843#note_2473571...
I could find reference in https://gitlab.com/cki-project/kernel- ark/-/merge_requests/3295#note_2037464426 - maybe it's needed only for CLANG builds?
From: Jan Stancek on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/3843#note_2473595...
Do you have a brew/koji build link for this MR?
From: Jan Stancek on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/3843#note_2473642...
It does look like RUST is getting silently disabled when bindgen is missing. CKI containers still have it, so it's not visible in pipeline here.
From: Scott Weaver on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/3843#note_2473644...
Looks like we need to get this package in RHEL then. Closing this MR.
kernel@lists.fedoraproject.org
-
Jan Stancek (via Email Bridge) -
Scott Weaver (via Email Bridge)