[OS-BUILD PATCH 0/0] configs: fedora: Fix CONFIG_I2C_DESIGNWARE_CORE being unset on x86_64 breaking touchpads and more
From: Hans de Goede on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/3429 NOTE: Truncated patchset due to missing public @redhat.com email address on your GitLab profile at https://gitlab.com/-/profile. Once that is fixed, close and reopen the merge request to retrigger sending the emails.
Before 6.12 CONFIG_I2C_DESIGNWARE_CORE was not user selectable, instead it was automatically selected by CONFIG_I2C_DESIGNWARE_PLATFORM / CONFIG_I2C_DESIGNWARE_PCI.
Commit 098c95d5adce ("[PATCH] [redhat] AUTOMATIC: New configs") added a new redhat/configs/pending-fedora/generic/CONFIG_I2C_DESIGNWARE_CORE file which sets "# CONFIG_I2C_DESIGNWARE_CORE is not set".
This is causing all the other CONFIG_I2C_DESIGNWARE_* options to be disabled breaking anything connected to any designware I2C controllers, such as touchpads, accelerometers, fuel-gauges, USB Type-C controllers, camera sensors, etc.
configs/fedora/generic/CONFIG_I2C_DESIGNWARE_PLATFORM has CONFIG_I2C_DESIGNWARE_PLATFORM=y
So previously CONFIG_I2C_DESIGNWARE_CORE was always 'y' on Fedora, restore this behavior by creating redhat/configs/fedora/generic/CONFIG_I2C_DESIGNWARE_CORE with "CONFIG_I2C_DESIGNWARE_CORE=y"
And drop:
- redhat/configs/fedora/generic/x86/CONFIG_I2C_DESIGNWARE_CORE - redhat/configs/fedora/generic/arm/aarch64/CONFIG_I2C_DESIGNWARE_CORE
which are now duplicates of fedora/generic/CONFIG_I2C_DESIGNWARE_CORE
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=2314756
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=2271136
--- redhat/configs/fedora/generic/s390x/CONFIG_I2C_DESIGNWARE_CORE | 1 + redhat/configs/fedora/generic/s390x/CONFIG_I2C_DESIGNWARE_PCI | 1 - redhat/configs/fedora/generic/x86/CONFIG_I2C_DESIGNWARE_CORE | 1 - redhat/configs/fedora/generic/arm/aarch64/CONFIG_I2C_DESIGNWARE_CORE => redhat/configs/fedora/generic/CONFIG_I2C_DESIGNWARE_CORE | 0 redhat/configs/pending-fedora/generic/CONFIG_I2C_DESIGNWARE_CORE | 17 ---------- 5 files changed, 1 insertions(+), 19 deletions(-)
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/3429#note_2146034...
I fixed this up in a different way, moving the unset to fedora/generic. That way it won't get accidentally turned off if another arch decides to support it. It is currently explicitly unset for everything except for x86 and aarch64.
From: Hans de Goede on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/3429#note_2146063...
Ok, that solves most of the issue.
I say most of the issue because CONFIG_I2C_DESIGNWARE_PCI is also necessary for the I2C controller used to talk to the Type-C controller for the Type-C port found on some AMD NAVI cards and those might be used in e.g. ppc64le systems too.
So basically we want CONFIG_I2C_DESIGNWARE_PCI=m everywhere which requires CONFIG_I2C_DESIGNWARE_CORE=m everywhere.
And then unset CONFIG_I2C_DESIGNWARE_CORE specifically for s390x.
From: Daniel Horak on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/3429#note_2146079...
I can confirm AMD NAVI cards are used on ppc64le with Fedora.
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/3429#note_2146095...
We did not have CONFIG_I2C_DESIGNWARE_CORE set for ppc previously. Anyway, should be fixed up now.
From: Hans de Goede on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/3429#note_2146348...
Thank you things look good to now.
There is the one issue of the i2c-designware drivers getting build on s390x where we do not want them (the PCI driver is disabled but the platform drivers and core are not).
That is fixed by the second commit in this MR. I'll rebase this MR and push a new version.
kernel@lists.fedoraproject.org
-
Daniel Horak (via Email Bridge) -
Hans de Goede (via Email Bridge)
-
Justin M. Forbes (via Email Bridge)