From: Fedora Kernel Team kernel-team@fedoraproject.org
[redhat] New configs in arch/arm64
Hi,
As part of the ongoing rebase effort, the following configuration options need to be reviewed.
As a reminder, the ARK configuration flow involves moving unreviewed configuration options from the pending directory to the ark directory. In the diff below, options are removed from the pending directory and added to the ark hierarchy. The final options that need to be ACKed are the files that are being added to the ark hierarchy.
If the value for a file that is added should be changed, please reply with a better option.
Symbol: ROCKCHIP_ERRATUM_3568002 [=y] Type : bool Defined at arch/arm64/Kconfig:1307 Prompt: Rockchip 3568002: GIC600 can not access physical addresses higher than 4GB Location: -> Kernel Features -> ARM errata workarounds via the alternatives framework -> Rockchip 3568002: GIC600 can not access physical addresses higher than 4GB (ROCKCHIP_ERRATUM_3568002 [=y])
Commit: 2d81e1bb6252 (irqchip/gic-v3: Add Rockchip 3568002 erratum workaround)
---
Signed-off-by: Fedora Kernel Team kernel-team@fedoraproject.org
diff --git a/redhat/configs/pending-rhel/generic/CONFIG_ROCKCHIP_ERRATUM_3568002 b/redhat/configs/pending-rhel/generic/CONFIG_ROCKCHIP_ERRATUM_3568002 deleted file mode 100644 index blahblah..blahblah 0 --- a/redhat/configs/pending-rhel/generic/CONFIG_ROCKCHIP_ERRATUM_3568002 +++ /dev/null @@ -1,13 +0,0 @@ -# Symbol: ROCKCHIP_ERRATUM_3568002 [=y] -# Type : bool -# Defined at arch/arm64/Kconfig:1307 -# Prompt: Rockchip 3568002: GIC600 can not access physical addresses higher than 4GB -# Location: -# -> Kernel Features -# -> ARM errata workarounds via the alternatives framework -# -> Rockchip 3568002: GIC600 can not access physical addresses higher than 4GB (ROCKCHIP_ERRATUM_3568002 [=y]) -# -# -# -# Commit: 2d81e1bb6252 (irqchip/gic-v3: Add Rockchip 3568002 erratum workaround) -CONFIG_ROCKCHIP_ERRATUM_3568002=y diff --git a/redhat/configs/rhel/generic/CONFIG_ROCKCHIP_ERRATUM_3568002 b/redhat/configs/rhel/generic/CONFIG_ROCKCHIP_ERRATUM_3568002 new file mode 100644 index blahblah..blahblah 100644 --- /dev/null +++ b/redhat/configs/rhel/generic/CONFIG_ROCKCHIP_ERRATUM_3568002 @@ -0,0 +1 @@ +CONFIG_ROCKCHIP_ERRATUM_3568002=y
-- https://gitlab.com/cki-project/kernel-ark/-/merge_requests/3754
From: Charles Mirabile on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/3754#note_2420246...
This SOC is not supported in RHEL so I don't think the config should be enabled.
From: Patrick Talbert on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/3754#note_2446510...
@cmirabil @mlangsdorf
I am happy to turn it off. But perhaps it does not hurt to leave it on, in case this SOC is ever enabled; assuming this `CONFIG_ROCKCHIP_ERRATUM_3568002` is something that a user of the SOC would definitely want enabled. Am I overthinking this?
From: Mark Langsdorf on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/3754#note_2447223...
I agree with Patrick that for generally supported architectures, we should enable all erratum, even for currently unsupported implementations. Rockchip has an ARM64 implementation, and even if we don't support the SoC now, we might be called upon to support it in the future.
From: Charles Mirabile on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/3754#note_2447489...
yeah, that is totally reasonable. I am not opposed to enabling it given this reasoning.
kernel@lists.fedoraproject.org
-
Charles Mirabile (via Email Bridge) -
CKI ARK Bot (via Email Bridge)
-
Mark Langsdorf (via Email Bridge)
-
Patrick Talbert (via Email Bridge)