[OS-BUILD PATCH] [redhat] New configs in drivers/virtio

[GitLab Bridge on behalf of jeremycline]

From: Fedora Kernel Team <kernel-team(a)fedoraproject.org&gt;

Hi,

As part of the ongoing rebase effort, the following configuration
options need to be reviewed.

As a reminder, the ARK configuration flow involves moving unreviewed
configuration options from the pending directory to the ark directory.
In the diff below, options are removed from the pending directory and
added to the ark hierarchy. The final options that need to be ACKed
are the files that are being added to the ark hierarchy.

If the value for a file that is added should be changed, please reply
with a better option.

 CONFIG_VIRTIO_MEM:

 This driver provides access to virtio-mem paravirtualized memory
 devices, allowing to hotplug and hotunplug memory.

 This driver was only tested under x86-64, but should theoretically
 work on all architectures that support memory hotplug and hotremove.

 If unsure, say M.

 Symbol: VIRTIO_MEM [=m]
 Type  : tristate
 Defined at drivers/virtio/Kconfig:81
   Prompt: Virtio mem driver
   Depends on: VIRTIO_MENU [=y] && X86_64 [=y] && VIRTIO [=y] &&
MEMORY_HOTPLUG_SPARSE [=y] && MEMORY_HOTREMOVE [=y]
   Location:
     -> Device Drivers
       -> Virtio drivers (VIRTIO_MENU [=y])
 Selects: CONTIG_ALLOC [=y]

---

Cc: "Michael S. Tsirkin" <mst(a)redhat.com&gt;
Cc: Jason Wang <jasowang(a)redhat.com&gt;
Cc: rhvirt-patches(a)redhat.com
Signed-off-by: Fedora Kernel Team <kernel-team(a)fedoraproject.org&gt;
---
 .../configs/common/generic/CONFIG_VIRTIO_MEM  |  1 +
 .../pending-common/generic/CONFIG_VIRTIO_MEM  | 23 -------------------
 2 files changed, 1 insertion(+), 23 deletions(-)
 create mode 100644 redhat/configs/common/generic/CONFIG_VIRTIO_MEM
 delete mode 100644 redhat/configs/pending-common/generic/CONFIG_VIRTIO_MEM

diff --git a/redhat/configs/common/generic/CONFIG_VIRTIO_MEM
b/redhat/configs/common/generic/CONFIG_VIRTIO_MEM
new file mode 100644
index 000000000000..3780f32af7be
--- /dev/null
+++ b/redhat/configs/common/generic/CONFIG_VIRTIO_MEM
@@ -0,0 +1 @@
+CONFIG_VIRTIO_MEM=m
diff --git a/redhat/configs/pending-common/generic/CONFIG_VIRTIO_MEM
b/redhat/configs/pending-common/generic/CONFIG_VIRTIO_MEM
deleted file mode 100644
index d5500a9c6c1e..000000000000
--- a/redhat/configs/pending-common/generic/CONFIG_VIRTIO_MEM
+++ /dev/null
@@ -1,23 +0,0 @@
-# CONFIG_VIRTIO_MEM:
-# 
-# This driver provides access to virtio-mem paravirtualized memory
-# devices, allowing to hotplug and hotunplug memory.
-# 
-# This driver was only tested under x86-64, but should theoretically
-# work on all architectures that support memory hotplug and hotremove.
-# 
-# If unsure, say M.
-# 
-# Symbol: VIRTIO_MEM [=m]
-# Type  : tristate
-# Defined at drivers/virtio/Kconfig:81
-#   Prompt: Virtio mem driver
-#   Depends on: VIRTIO_MENU [=y] && X86_64 [=y] && VIRTIO [=y] &&
MEMORY_HOTPLUG_SPARSE [=y] && MEMORY_HOTREMOVE [=y]
-#   Location:
-#     -> Device Drivers
-#       -> Virtio drivers (VIRTIO_MENU [=y])
-# Selects: CONTIG_ALLOC [=y]
-# 
-# 
-# 
-CONFIG_VIRTIO_MEM=m
-- 
2.27.0

From: Patrick Talbert on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/454#note_48896...

This merge request has not been updated in over 30 days.
Please review this MR's current changes regarding the following
configuration option(s):

     CONFIG_VIRTIO_MEM

From: Paolo Bonzini on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/454#note_48999...

Please make it "n" for now.  If needed, we will enable it explicitly
later.

[OS-BUILD PATCHv2 0/2] [redhat] New configs in drivers/virtio

[Jeremy Cline (via Email Bridge)]

From: Jeremy Cline on gitlab.com
Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/454

Hi,

As part of the ongoing rebase effort, the following configuration
options need to be reviewed.

As a reminder, the ARK configuration flow involves moving unreviewed
configuration options from the pending directory to the ark directory.
In the diff below, options are removed from the pending directory and
added to the ark hierarchy. The final options that need to be ACKed
are the files that are being added to the ark hierarchy.

If the value for a file that is added should be changed, please reply
with a better option.

 CONFIG_VIRTIO_MEM:

 This driver provides access to virtio-mem paravirtualized memory
 devices, allowing to hotplug and hotunplug memory.

 This driver was only tested under x86-64, but should theoretically
 work on all architectures that support memory hotplug and hotremove.

 If unsure, say M.

 Symbol: VIRTIO_MEM [=m]
 Type  : tristate
 Defined at drivers/virtio/Kconfig:81
   Prompt: Virtio mem driver
   Depends on: VIRTIO_MENU [=y] && X86_64 [=y] && VIRTIO [=y] &&
MEMORY_HOTPLUG_SPARSE [=y] && MEMORY_HOTREMOVE [=y]
   Location:
     -> Device Drivers
       -> Virtio drivers (VIRTIO_MENU [=y])
 Selects: CONTIG_ALLOC [=y]

---

Cc: "Michael S. Tsirkin" <mst(a)redhat.com&gt;
Cc: Jason Wang <jasowang(a)redhat.com&gt;
Cc: rhvirt-patches(a)redhat.com
Signed-off-by: Fedora Kernel Team <kernel-team(a)fedoraproject.org&gt;

[OS-BUILD PATCHv2 1/2] [redhat] New configs in drivers/virtio

[Jeremy Cline (via Email Bridge)]

From: Fedora Kernel Team <kernel-team(a)fedoraproject.org&gt;

[redhat] New configs in drivers/virtio

Hi,

As part of the ongoing rebase effort, the following configuration
options need to be reviewed.

As a reminder, the ARK configuration flow involves moving unreviewed
configuration options from the pending directory to the ark directory.
In the diff below, options are removed from the pending directory and
added to the ark hierarchy. The final options that need to be ACKed
are the files that are being added to the ark hierarchy.

If the value for a file that is added should be changed, please reply
with a better option.

 CONFIG_VIRTIO_MEM:

 This driver provides access to virtio-mem paravirtualized memory
 devices, allowing to hotplug and hotunplug memory.

 This driver was only tested under x86-64, but should theoretically
 work on all architectures that support memory hotplug and hotremove.

 If unsure, say M.

 Symbol: VIRTIO_MEM [=m]
 Type  : tristate
 Defined at drivers/virtio/Kconfig:81
   Prompt: Virtio mem driver
   Depends on: VIRTIO_MENU [=y] && X86_64 [=y] && VIRTIO [=y] &&
MEMORY_HOTPLUG_SPARSE [=y] && MEMORY_HOTREMOVE [=y]
   Location:
     -> Device Drivers
       -> Virtio drivers (VIRTIO_MENU [=y])
 Selects: CONTIG_ALLOC [=y]

---

Cc: "Michael S. Tsirkin" <mst(a)redhat.com&gt;
Cc: Jason Wang <jasowang(a)redhat.com&gt;
Cc: rhvirt-patches(a)redhat.com
Signed-off-by: Fedora Kernel Team <kernel-team(a)fedoraproject.org&gt;

diff a/redhat/configs/common/generic/CONFIG_VIRTIO_MEM
b/redhat/configs/common/generic/CONFIG_VIRTIO_MEM
--- /dev/null
+++ b/redhat/configs/common/generic/CONFIG_VIRTIO_MEM
@@ -0,0 +1 @@
+CONFIG_VIRTIO_MEM=m
diff a/redhat/configs/pending-common/generic/CONFIG_VIRTIO_MEM
b/redhat/configs/pending-common/generic/CONFIG_VIRTIO_MEM
--- a/redhat/configs/pending-common/generic/CONFIG_VIRTIO_MEM
+++ /dev/null
@@ -1,23 +0,0 @@
-# CONFIG_VIRTIO_MEM:
-# 
-# This driver provides access to virtio-mem paravirtualized memory
-# devices, allowing to hotplug and hotunplug memory.
-# 
-# This driver was only tested under x86-64, but should theoretically
-# work on all architectures that support memory hotplug and hotremove.
-# 
-# If unsure, say M.
-# 
-# Symbol: VIRTIO_MEM [=m]
-# Type  : tristate
-# Defined at drivers/virtio/Kconfig:81
-#   Prompt: Virtio mem driver
-#   Depends on: VIRTIO_MENU [=y] && X86_64 [=y] && VIRTIO [=y] &&
MEMORY_HOTPLUG_SPARSE [=y] && MEMORY_HOTREMOVE [=y]
-#   Location:
-#     -> Device Drivers
-#       -> Virtio drivers (VIRTIO_MENU [=y])
-# Selects: CONTIG_ALLOC [=y]
-# 
-# 
-# 
-CONFIG_VIRTIO_MEM=m

--
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/454

[OS-BUILD PATCHv2 2/2] Update CONFIG_VIRTIO_MEM

[Jeremy Cline (via Email Bridge)]

From: Patrick Talbert <ptalbert(a)redhat.com&gt;

Update CONFIG_VIRTIO_MEM
diff a/redhat/configs/common/generic/CONFIG_VIRTIO_MEM
b/redhat/configs/common/generic/CONFIG_VIRTIO_MEM
--- a/redhat/configs/common/generic/CONFIG_VIRTIO_MEM
+++ b/redhat/configs/common/generic/CONFIG_VIRTIO_MEM
@@ -1 +1 @@
-CONFIG_VIRTIO_MEM=m
+# CONFIG_VIRTIO_MEM is not set

--
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/454

[OS-BUILD PATCHv2 0/2] [redhat] New configs in drivers/virtio

From: CKI Bot on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/454#note_49145...

Hi! This is the friendly CKI test bot.

It appears that you are not a member of redhat/red-hat-ci-
tools/kernel/cki-runs/trusted-pipelines. This means that the CI
pipeline on your MR will fail. As getting testing is important, I'll be
responsible for testing your changes. After every MR change, I'll start
a
small testing pipeline and link it here so you can follow the results.
I'll
also create and link a pipeline for hardware testing that the reviewers
can
start to get extra test coverage.

[OS-BUILD PATCHv2 0/2] [redhat] New configs in drivers/virtio

From: CKI Bot on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/454#note_49145...

Testing pipeline status:
Basic testing pipeline:

  https://gitlab.com/redhat/red-hat-ci-tools/kernel/cki-
runs/external-pipelines/-/pipelines/245354315 - created
:hourglass_flowing_sand:

[OS-BUILD PATCHv2 0/2] [redhat] New configs in drivers/virtio

From: Patrick Talbert on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/454#note_49145...

Thank you Paolo.

I have updated the MR so CONFIG_VIRTIO_MEM will not be set. Please
rereview.

All commits in this MR will be squashed upon merge.

Thank you,

Patrick

[OS-BUILD PATCHv2 0/2] [redhat] New configs in drivers/virtio

From: David Hildenbrand on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/454#note_49302...

The config for Fedora should remain "m". For ark, we want "n". I
think
this merge request changes it for both, fedora and ark.