Patch: BuildRequire openssl openssl-devel on %{ix86} x86_64

[Thorsten Leemhuis]

Lo! Consider applying below patch for rawhide and the stabilization
branch. It fixes a build problem in mock on %{ix86} x86_64 when setting
%signmodules to 0 in kernel.spec. The build fails because Linux since
4.3-rc1 needs openssl and openssl-devel when CONFIG_MODULE_SIG is set,
which is the done by config-x86-generic in Fedora. CU, thl

diff --git a/kernel.spec b/kernel.spec
index 33d7e47..873167c 100644
--- a/kernel.spec
+++ b/kernel.spec
@@ -388,8 +388,12 @@ BuildRequires: rpm-build, elfutils
 %define debuginfo_args --strict-build-id -r
 %endif

-%if %{signmodules}
+%ifarch %{ix86} x86_64
+# MODULE_SIG is enabled in config-x86-generic and needs these:
 BuildRequires: openssl openssl-devel
+%endif
+
+%if %{signmodules}
 BuildRequires: pesign >= 0.10-4
 %endif

[Josh Boyer]

On Thu, Dec 10, 2015 at 2:50 PM, Thorsten Leemhuis  wrote:
> Lo! Consider applying below patch for rawhide and the stabilization
> branch. It fixes a build problem in mock on %{ix86} x86_64 when setting
> %signmodules to 0 in kernel.spec. The build fails because Linux since
> 4.3-rc1 needs openssl and openssl-devel when CONFIG_MODULE_SIG is set,
> which is the done by config-x86-generic in Fedora. CU, thl

Hm.  Yes.  This looks correct to me as a reflection of the state of
things today.

Thinking about it some, there isn't really a reason CONFIG_MODULE_SIG
couldn't be enabled on other architectures.  Signed modules are
independent of UEFI secure boot support.  If we did that, we might
want to come up with something that maps arches which have it enabled
to a single RPM macro.

Anyway, that's likely future work.

josh
> diff --git a/kernel.spec b/kernel.spec
> index 33d7e47..873167c 100644
> --- a/kernel.spec
> +++ b/kernel.spec
> @@ -388,8 +388,12 @@ BuildRequires: rpm-build, elfutils
>  %define debuginfo_args --strict-build-id -r
>  %endif
>
> -%if %{signmodules}
> +%ifarch %{ix86} x86_64
> +# MODULE_SIG is enabled in config-x86-generic and needs these:
>  BuildRequires: openssl openssl-devel
> +%endif
>
> +%if %{signmodules}
>  BuildRequires: pesign >= 0.10-4
>  %endif
> _______________________________________________
> kernel mailing list
> [e-mail]
> http://lists.fedoraproject.org/admin/lists/[e-mail]

[Josh Boyer]

On Thu, Dec 10, 2015 at 2:59 PM, Josh Boyer  wrote:
> On Thu, Dec 10, 2015 at 2:50 PM, Thorsten Leemhuis  wrote:
> > Lo! Consider applying below patch for rawhide and the stabilization
> > branch. It fixes a build problem in mock on %{ix86} x86_64 when setting
> > %signmodules to 0 in kernel.spec. The build fails because Linux since
> > 4.3-rc1 needs openssl and openssl-devel when CONFIG_MODULE_SIG is set,
> > which is the done by config-x86-generic in Fedora. CU, thl
>
> Hm.  Yes.  This looks correct to me as a reflection of the state of
> things today.

I've applied this today.  Future things can be done in the future.  Thanks!

josh