Hi,
On 30-07-18 13:59, Peter Robinson wrote:
On Mon, Jul 30, 2018 at 10:01 AM, Hans de Goede
<hdegoede(a)redhat.com> wrote:
> Hi,
>
> If there are no objections I plan to push the attached patch to the
> rawhide kernel in the next couple of days.
>
> Note that we had e.g. the PMIC opregions for this already enabled
> in the past, see: configs/fedora/generic/x86/CONFIG_BXT_WC_PMIC_OPREGION
> which this patch does not change, but newer kernels have added more
> fine grained Kconfig options for the PMC_IPC bus between the
> Apollo Lake SoC and the PMIC, we ended up picking 'N' for the
> CONFIG_INTEL_PMC_IPC option, effectively disabling the PMIC support.
I don't see the patch
Weird, it is there (attached) in my send folder anyways here is an inline copy:
From 0bf24e28962018c02c0f8a2c71cf957f4bf4767d Mon Sep 17 00:00:00 2001
From: Hans de Goede <hdegoede(a)redhat.com>
Date: Mon, 30 Jul 2018 10:56:55 +0200
Subject: [PATCH] Enable Apollo Lake Whiskey Cove PMIC support
---
configs/fedora/generic/x86/CONFIG_INTEL_BXTWC_PMIC_TMU | 1 +
configs/fedora/generic/x86/CONFIG_INTEL_PMC_IPC | 2 +-
configs/fedora/generic/x86/CONFIG_INTEL_SOC_PMIC_BXTWC | 1 +
configs/fedora/generic/x86/CONFIG_INTEL_TELEMETRY | 1 +
configs/fedora/generic/x86/CONFIG_TYPEC_WCOVE | 1 +
kernel-i686-PAE.config | 5 ++++-
kernel-i686-PAEdebug.config | 5 ++++-
kernel-i686-debug.config | 5 ++++-
kernel-i686.config | 5 ++++-
kernel-x86_64-debug.config | 5 ++++-
kernel-x86_64.config | 5 ++++-
11 files changed, 29 insertions(+), 7 deletions(-)
create mode 100644 configs/fedora/generic/x86/CONFIG_INTEL_BXTWC_PMIC_TMU
create mode 100644 configs/fedora/generic/x86/CONFIG_INTEL_SOC_PMIC_BXTWC
create mode 100644 configs/fedora/generic/x86/CONFIG_INTEL_TELEMETRY
create mode 100644 configs/fedora/generic/x86/CONFIG_TYPEC_WCOVE
diff --git a/configs/fedora/generic/x86/CONFIG_INTEL_BXTWC_PMIC_TMU
b/configs/fedora/generic/x86/CONFIG_INTEL_BXTWC_PMIC_TMU
new file mode 100644
index 00000000..8d20abc9
--- /dev/null
+++ b/configs/fedora/generic/x86/CONFIG_INTEL_BXTWC_PMIC_TMU
@@ -0,0 +1 @@
+CONFIG_INTEL_BXTWC_PMIC_TMU=m
diff --git a/configs/fedora/generic/x86/CONFIG_INTEL_PMC_IPC
b/configs/fedora/generic/x86/CONFIG_INTEL_PMC_IPC
index eedef11a..7e5ad0c7 100644
--- a/configs/fedora/generic/x86/CONFIG_INTEL_PMC_IPC
+++ b/configs/fedora/generic/x86/CONFIG_INTEL_PMC_IPC
@@ -1 +1 @@
-# CONFIG_INTEL_PMC_IPC is not set
+CONFIG_INTEL_PMC_IPC=y
diff --git a/configs/fedora/generic/x86/CONFIG_INTEL_SOC_PMIC_BXTWC
b/configs/fedora/generic/x86/CONFIG_INTEL_SOC_PMIC_BXTWC
new file mode 100644
index 00000000..a99d79db
--- /dev/null
+++ b/configs/fedora/generic/x86/CONFIG_INTEL_SOC_PMIC_BXTWC
@@ -0,0 +1 @@
+CONFIG_INTEL_SOC_PMIC_BXTWC=y
diff --git a/configs/fedora/generic/x86/CONFIG_INTEL_TELEMETRY
b/configs/fedora/generic/x86/CONFIG_INTEL_TELEMETRY
new file mode 100644
index 00000000..7d51a945
--- /dev/null
+++ b/configs/fedora/generic/x86/CONFIG_INTEL_TELEMETRY
@@ -0,0 +1 @@
+CONFIG_INTEL_TELEMETRY=m
diff --git a/configs/fedora/generic/x86/CONFIG_TYPEC_WCOVE
b/configs/fedora/generic/x86/CONFIG_TYPEC_WCOVE
new file mode 100644
index 00000000..8801ecb2
--- /dev/null
+++ b/configs/fedora/generic/x86/CONFIG_TYPEC_WCOVE
@@ -0,0 +1 @@
+CONFIG_TYPEC_WCOVE=m
diff --git a/kernel-i686-PAE.config b/kernel-i686-PAE.config
index f4af560a..8bc18663 100644
--- a/kernel-i686-PAE.config
+++ b/kernel-i686-PAE.config
@@ -2301,6 +2301,7 @@ CONFIG_INTEGRITY_AUDIT=y
CONFIG_INTEGRITY_SIGNATURE=y
CONFIG_INTEGRITY=y
CONFIG_INTEL_BXT_PMIC_THERMAL=m
+CONFIG_INTEL_BXTWC_PMIC_TMU=m
CONFIG_INTEL_CHTDC_TI_PWRBTN=m
CONFIG_INTEL_CHT_INT33FE=m
CONFIG_INTEL_HID_EVENT=m
@@ -2321,7 +2322,7 @@ CONFIG_INTEL_MEI_WDT=m
CONFIG_INTEL_OAKTRAIL=m
CONFIG_INTEL_PCH_THERMAL=m
CONFIG_INTEL_PMC_CORE=y
-# CONFIG_INTEL_PMC_IPC is not set
+CONFIG_INTEL_PMC_IPC=y
CONFIG_INTEL_POWERCLAMP=m
CONFIG_INTEL_PUNIT_IPC=m
CONFIG_INTEL_RAPL=m
@@ -2331,9 +2332,11 @@ CONFIG_INTEL_RST=m
# CONFIG_INTEL_SCU_IPC is not set
CONFIG_INTEL_SMARTCONNECT=y
CONFIG_INTEL_SOC_DTS_THERMAL=m
+CONFIG_INTEL_SOC_PMIC_BXTWC=y
CONFIG_INTEL_SOC_PMIC_CHTDC_TI=m
# CONFIG_INTEL_SOC_PMIC_CHTWC is not set
CONFIG_INTEL_SOC_PMIC=y
+CONFIG_INTEL_TELEMETRY=m
# CONFIG_INTEL_TH is not set
# CONFIG_INTEL_TXT is not set
CONFIG_INTEL_VBTN=m
diff --git a/kernel-i686-PAEdebug.config b/kernel-i686-PAEdebug.config
index 8dfbdcbc..eab19d33 100644
--- a/kernel-i686-PAEdebug.config
+++ b/kernel-i686-PAEdebug.config
@@ -2322,6 +2322,7 @@ CONFIG_INTEGRITY_AUDIT=y
CONFIG_INTEGRITY_SIGNATURE=y
CONFIG_INTEGRITY=y
CONFIG_INTEL_BXT_PMIC_THERMAL=m
+CONFIG_INTEL_BXTWC_PMIC_TMU=m
CONFIG_INTEL_CHTDC_TI_PWRBTN=m
CONFIG_INTEL_CHT_INT33FE=m
CONFIG_INTEL_HID_EVENT=m
@@ -2342,7 +2343,7 @@ CONFIG_INTEL_MEI_WDT=m
CONFIG_INTEL_OAKTRAIL=m
CONFIG_INTEL_PCH_THERMAL=m
CONFIG_INTEL_PMC_CORE=y
-# CONFIG_INTEL_PMC_IPC is not set
+CONFIG_INTEL_PMC_IPC=y
CONFIG_INTEL_POWERCLAMP=m
CONFIG_INTEL_PUNIT_IPC=m
CONFIG_INTEL_RAPL=m
@@ -2352,9 +2353,11 @@ CONFIG_INTEL_RST=m
# CONFIG_INTEL_SCU_IPC is not set
CONFIG_INTEL_SMARTCONNECT=y
CONFIG_INTEL_SOC_DTS_THERMAL=m
+CONFIG_INTEL_SOC_PMIC_BXTWC=y
CONFIG_INTEL_SOC_PMIC_CHTDC_TI=m
# CONFIG_INTEL_SOC_PMIC_CHTWC is not set
CONFIG_INTEL_SOC_PMIC=y
+CONFIG_INTEL_TELEMETRY=m
# CONFIG_INTEL_TH is not set
# CONFIG_INTEL_TXT is not set
CONFIG_INTEL_VBTN=m
diff --git a/kernel-i686-debug.config b/kernel-i686-debug.config
index bebf56d9..cc60cff5 100644
--- a/kernel-i686-debug.config
+++ b/kernel-i686-debug.config
@@ -2322,6 +2322,7 @@ CONFIG_INTEGRITY_AUDIT=y
CONFIG_INTEGRITY_SIGNATURE=y
CONFIG_INTEGRITY=y
CONFIG_INTEL_BXT_PMIC_THERMAL=m
+CONFIG_INTEL_BXTWC_PMIC_TMU=m
CONFIG_INTEL_CHTDC_TI_PWRBTN=m
CONFIG_INTEL_CHT_INT33FE=m
CONFIG_INTEL_HID_EVENT=m
@@ -2342,7 +2343,7 @@ CONFIG_INTEL_MEI_WDT=m
CONFIG_INTEL_OAKTRAIL=m
CONFIG_INTEL_PCH_THERMAL=m
CONFIG_INTEL_PMC_CORE=y
-# CONFIG_INTEL_PMC_IPC is not set
+CONFIG_INTEL_PMC_IPC=y
CONFIG_INTEL_POWERCLAMP=m
CONFIG_INTEL_PUNIT_IPC=m
CONFIG_INTEL_RAPL=m
@@ -2352,9 +2353,11 @@ CONFIG_INTEL_RST=m
# CONFIG_INTEL_SCU_IPC is not set
CONFIG_INTEL_SMARTCONNECT=y
CONFIG_INTEL_SOC_DTS_THERMAL=m
+CONFIG_INTEL_SOC_PMIC_BXTWC=y
CONFIG_INTEL_SOC_PMIC_CHTDC_TI=m
# CONFIG_INTEL_SOC_PMIC_CHTWC is not set
CONFIG_INTEL_SOC_PMIC=y
+CONFIG_INTEL_TELEMETRY=m
# CONFIG_INTEL_TH is not set
# CONFIG_INTEL_TXT is not set
CONFIG_INTEL_VBTN=m
diff --git a/kernel-i686.config b/kernel-i686.config
index 2cfbcc8e..83c9796d 100644
--- a/kernel-i686.config
+++ b/kernel-i686.config
@@ -2301,6 +2301,7 @@ CONFIG_INTEGRITY_AUDIT=y
CONFIG_INTEGRITY_SIGNATURE=y
CONFIG_INTEGRITY=y
CONFIG_INTEL_BXT_PMIC_THERMAL=m
+CONFIG_INTEL_BXTWC_PMIC_TMU=m
CONFIG_INTEL_CHTDC_TI_PWRBTN=m
CONFIG_INTEL_CHT_INT33FE=m
CONFIG_INTEL_HID_EVENT=m
@@ -2321,7 +2322,7 @@ CONFIG_INTEL_MEI_WDT=m
CONFIG_INTEL_OAKTRAIL=m
CONFIG_INTEL_PCH_THERMAL=m
CONFIG_INTEL_PMC_CORE=y
-# CONFIG_INTEL_PMC_IPC is not set
+CONFIG_INTEL_PMC_IPC=y
CONFIG_INTEL_POWERCLAMP=m
CONFIG_INTEL_PUNIT_IPC=m
CONFIG_INTEL_RAPL=m
@@ -2331,9 +2332,11 @@ CONFIG_INTEL_RST=m
# CONFIG_INTEL_SCU_IPC is not set
CONFIG_INTEL_SMARTCONNECT=y
CONFIG_INTEL_SOC_DTS_THERMAL=m
+CONFIG_INTEL_SOC_PMIC_BXTWC=y
CONFIG_INTEL_SOC_PMIC_CHTDC_TI=m
# CONFIG_INTEL_SOC_PMIC_CHTWC is not set
CONFIG_INTEL_SOC_PMIC=y
+CONFIG_INTEL_TELEMETRY=m
# CONFIG_INTEL_TH is not set
# CONFIG_INTEL_TXT is not set
CONFIG_INTEL_VBTN=m
diff --git a/kernel-x86_64-debug.config b/kernel-x86_64-debug.config
index 5b142965..00d19eba 100644
--- a/kernel-x86_64-debug.config
+++ b/kernel-x86_64-debug.config
@@ -2372,6 +2372,7 @@ CONFIG_INTEGRITY_AUDIT=y
CONFIG_INTEGRITY_SIGNATURE=y
CONFIG_INTEGRITY=y
CONFIG_INTEL_BXT_PMIC_THERMAL=m
+CONFIG_INTEL_BXTWC_PMIC_TMU=m
CONFIG_INTEL_CHTDC_TI_PWRBTN=m
CONFIG_INTEL_CHT_INT33FE=m
CONFIG_INTEL_HID_EVENT=m
@@ -2397,7 +2398,7 @@ CONFIG_INTEL_MIC_X100_DMA=m
CONFIG_INTEL_OAKTRAIL=m
CONFIG_INTEL_PCH_THERMAL=m
CONFIG_INTEL_PMC_CORE=y
-# CONFIG_INTEL_PMC_IPC is not set
+CONFIG_INTEL_PMC_IPC=y
CONFIG_INTEL_POWERCLAMP=m
CONFIG_INTEL_PUNIT_IPC=m
CONFIG_INTEL_RAPL=m
@@ -2407,9 +2408,11 @@ CONFIG_INTEL_RST=m
# CONFIG_INTEL_SCU_IPC is not set
CONFIG_INTEL_SMARTCONNECT=y
CONFIG_INTEL_SOC_DTS_THERMAL=m
+CONFIG_INTEL_SOC_PMIC_BXTWC=y
CONFIG_INTEL_SOC_PMIC_CHTDC_TI=m
CONFIG_INTEL_SOC_PMIC_CHTWC=y
CONFIG_INTEL_SOC_PMIC=y
+CONFIG_INTEL_TELEMETRY=m
# CONFIG_INTEL_TH is not set
CONFIG_INTEL_TURBO_MAX_3=y
CONFIG_INTEL_TXT=y
diff --git a/kernel-x86_64.config b/kernel-x86_64.config
index 86d421eb..046f503e 100644
--- a/kernel-x86_64.config
+++ b/kernel-x86_64.config
@@ -2351,6 +2351,7 @@ CONFIG_INTEGRITY_AUDIT=y
CONFIG_INTEGRITY_SIGNATURE=y
CONFIG_INTEGRITY=y
CONFIG_INTEL_BXT_PMIC_THERMAL=m
+CONFIG_INTEL_BXTWC_PMIC_TMU=m
CONFIG_INTEL_CHTDC_TI_PWRBTN=m
CONFIG_INTEL_CHT_INT33FE=m
CONFIG_INTEL_HID_EVENT=m
@@ -2376,7 +2377,7 @@ CONFIG_INTEL_MIC_X100_DMA=m
CONFIG_INTEL_OAKTRAIL=m
CONFIG_INTEL_PCH_THERMAL=m
CONFIG_INTEL_PMC_CORE=y
-# CONFIG_INTEL_PMC_IPC is not set
+CONFIG_INTEL_PMC_IPC=y
CONFIG_INTEL_POWERCLAMP=m
CONFIG_INTEL_PUNIT_IPC=m
CONFIG_INTEL_RAPL=m
@@ -2386,9 +2387,11 @@ CONFIG_INTEL_RST=m
# CONFIG_INTEL_SCU_IPC is not set
CONFIG_INTEL_SMARTCONNECT=y
CONFIG_INTEL_SOC_DTS_THERMAL=m
+CONFIG_INTEL_SOC_PMIC_BXTWC=y
CONFIG_INTEL_SOC_PMIC_CHTDC_TI=m
CONFIG_INTEL_SOC_PMIC_CHTWC=y
CONFIG_INTEL_SOC_PMIC=y
+CONFIG_INTEL_TELEMETRY=m
# CONFIG_INTEL_TH is not set
CONFIG_INTEL_TURBO_MAX_3=y
CONFIG_INTEL_TXT=y
---
Regards,
Hans