kernel-4.15.0-0.rc3.git0.1.fc28 src rpm fails to compile because of errors in ppc64p7 config file

[stan]

I tried to compile this kernel from the src rpm on rawhide.  I kept
getting the error that two config options for ppc64p7 were set to m,
and m wasn't a valid choice.

So, I generated the following patch,

diff --git a/configs/kernel-4.15.0-ppc64p7.config
b/configs/kernel-4.15.0-ppc64p7.config index 18f4b44..ca5b410 100644
--- a/configs/kernel-4.15.0-ppc64p7.config
+++ b/configs/kernel-4.15.0-ppc64p7.config
@@ -1704,7 +1704,7 @@ CONFIG_HW_RANDOM_TIMERIOMEM=m
 CONFIG_HW_RANDOM_TPM=m
 CONFIG_HW_RANDOM_VIRTIO=m
 CONFIG_HW_RANDOM=y
-CONFIG_HWSPINLOCK=m
+CONFIG_HWSPINLOCK=y
 CONFIG_HYSDN_CAPI=y
 CONFIG_HYSDN=m
 CONFIG_HZ=100
@@ -4447,7 +4447,7 @@ CONFIG_SND_DARLA24=m
 # CONFIG_SND_DEBUG_VERBOSE is not set
 CONFIG_SND_DEBUG=y
 CONFIG_SND_DESIGNWARE_I2S=m
-CONFIG_SND_DESIGNWARE_PCM=m
+CONFIG_SND_DESIGNWARE_PCM=y
 CONFIG_SND_DICE=m
 CONFIG_SND_DMAENGINE_PCM=m
 CONFIG_SND_DRIVERS=y

I don't know if y is a valid setting for a ppc for those options, but I
presume if m was desired, y would succeed.  I don't really care about
ppc64p7 as I'm building for x86_64.  I changed the spec file so that
this architecture won't be built in nobuildarches, and this error still
occurred.

Unfortunately, at the time that the kernel is patched, this config file
doesn't exist yet, and so the patch fails.  I see a successful build in
koji; I'm not sure how that can be.

What is the best way to proceed from here?

Thanks.

[Laura Abbott]

On 12/13/2017 10:25 AM, stan wrote:
>  
>  I tried to compile this kernel from the src rpm on rawhide.  I kept
>  getting the error that two config options for ppc64p7 were set to m,
>  and m wasn't a valid choice.
>  
>  So, I generated the following patch,
>  
>  diff --git a/configs/kernel-4.15.0-ppc64p7.config
>  b/configs/kernel-4.15.0-ppc64p7.config index 18f4b44..ca5b410 100644
>  --- a/configs/kernel-4.15.0-ppc64p7.config
>  +++ b/configs/kernel-4.15.0-ppc64p7.config
>  @@ -1704,7 +1704,7 @@ CONFIG_HW_RANDOM_TIMERIOMEM=m
>    CONFIG_HW_RANDOM_TPM=m
>    CONFIG_HW_RANDOM_VIRTIO=m
>    CONFIG_HW_RANDOM=y
>  -CONFIG_HWSPINLOCK=m
>  +CONFIG_HWSPINLOCK=y
>    CONFIG_HYSDN_CAPI=y
>    CONFIG_HYSDN=m
>    CONFIG_HZ=100
>  @@ -4447,7 +4447,7 @@ CONFIG_SND_DARLA24=m
>    # CONFIG_SND_DEBUG_VERBOSE is not set
>    CONFIG_SND_DEBUG=y
>    CONFIG_SND_DESIGNWARE_I2S=m
>  -CONFIG_SND_DESIGNWARE_PCM=m
>  +CONFIG_SND_DESIGNWARE_PCM=y
>    CONFIG_SND_DICE=m
>    CONFIG_SND_DMAENGINE_PCM=m
>    CONFIG_SND_DRIVERS=y
>  
>  I don't know if y is a valid setting for a ppc for those options, but I
>  presume if m was desired, y would succeed.  I don't really care about
>  ppc64p7 as I'm building for x86_64.  I changed the spec file so that
>  this architecture won't be built in nobuildarches, and this error still
>  occurred.
>  
>  Unfortunately, at the time that the kernel is patched, this config file
>  doesn't exist yet, and so the patch fails.  I see a successful build in
>  koji; I'm not sure how that can be.
>  
>  What is the best way to proceed from here? 
Can you share the steps you used to produce this build as well as the
full build log? As you noted, this was built successfully in koji.

Thanks,
Laura

[Peter Robinson]

On Wed, Dec 13, 2017 at 8:08 PM, Laura Abbott <labbott(a)redhat.com&gt; wrote:
>  On 12/13/2017 10:25 AM, stan wrote:
> >
> >
> > I tried to compile this kernel from the src rpm on rawhide.  I kept
> > getting the error that two config options for ppc64p7 were set to m,
> > and m wasn't a valid choice.
> >
> > So, I generated the following patch,
> >
> > diff --git a/configs/kernel-4.15.0-ppc64p7.config
> > b/configs/kernel-4.15.0-ppc64p7.config index 18f4b44..ca5b410 100644
> > --- a/configs/kernel-4.15.0-ppc64p7.config
> > +++ b/configs/kernel-4.15.0-ppc64p7.config
> > @@ -1704,7 +1704,7 @@ CONFIG_HW_RANDOM_TIMERIOMEM=m
> >   CONFIG_HW_RANDOM_TPM=m
> >   CONFIG_HW_RANDOM_VIRTIO=m
> >   CONFIG_HW_RANDOM=y
> > -CONFIG_HWSPINLOCK=m
> > +CONFIG_HWSPINLOCK=y
> >   CONFIG_HYSDN_CAPI=y
> >   CONFIG_HYSDN=m
> >   CONFIG_HZ=100
> > @@ -4447,7 +4447,7 @@ CONFIG_SND_DARLA24=m
> >   # CONFIG_SND_DEBUG_VERBOSE is not set
> >   CONFIG_SND_DEBUG=y
> >   CONFIG_SND_DESIGNWARE_I2S=m
> > -CONFIG_SND_DESIGNWARE_PCM=m
> > +CONFIG_SND_DESIGNWARE_PCM=y
> >   CONFIG_SND_DICE=m
> >   CONFIG_SND_DMAENGINE_PCM=m
> >   CONFIG_SND_DRIVERS=y
> >
> > I don't know if y is a valid setting for a ppc for those options, but I
> > presume if m was desired, y would succeed.  I don't really care about
> > ppc64p7 as I'm building for x86_64.  I changed the spec file so that
> > this architecture won't be built in nobuildarches, and this error still
> > occurred.
> >
> > Unfortunately, at the time that the kernel is patched, this config file
> > doesn't exist yet, and so the patch fails.  I see a successful build in
> > koji; I'm not sure how that can be.
> >
> > What is the best way to proceed from here?
>
>
>  Can you share the steps you used to produce this build as well as the
>  full build log? As you noted, this was built successfully in koji. 
The ppc64p7 sub variant was removed so I'm not even sure why that's showing up.

[stan]

On Thu, 14 Dec 2017 01:00:10 +0000
Peter Robinson <pbrobinson(a)gmail.com&gt; wrote:

>  On Wed, Dec 13, 2017 at 8:08 PM, Laura Abbott
> <labbott(a)redhat.com&gt;
>  wrote: 
>  > Can you share the steps you used to produce this build as well
> as
>  > the full build log? As you noted, this was built successfully in
>  > koji.   
I'm following this procedure for building from the src.rpm using
rpmbuild.

https://fedoraproject.org/wiki/Building_a_custom_kernel/Source_RPM

I've been using it for years, and I successfully built a 4.15 kernel
just a few weeks ago using the same procedure.

>  The ppc64p7 sub variant was removed so I'm not even sure why
> that's
>  showing up. 
This was the key comment.  It seems that the kernel picks up any kernel
config files in SOURCES.  There was an old set of configs for ppc64p7
there.  Once I deleted them, everything worked fine.  The previous
version of 4.15 I successfully built was in F25, and I'm now building in
rawhide, and it had the obsolete ppc64p7 config file I SOURCES from
older builds.

Sorry for the noise, but thanks for the help.

[Peter Robinson]

> > On Wed, Dec 13, 2017 at 8:08 PM, Laura Abbott
> <labbott(a)redhat.com&gt;
> > wrote:
>
> > > Can you share the steps you used to produce this build as well as
> > > the full build log? As you noted, this was built successfully in
> > > koji.
>
>  I'm following this procedure for building from the src.rpm using
>  rpmbuild.
>
>  https://fedoraproject.org/wiki/Building_a_custom_kernel/Source_RPM
>
>  I've been using it for years, and I successfully built a 4.15 kernel
>  just a few weeks ago using the same procedure.
>
> > The ppc64p7 sub variant was removed so I'm not even sure why that's
> > showing up.
>
>  This was the key comment.  It seems that the kernel picks up any kernel
>  config files in SOURCES.  There was an old set of configs for ppc64p7
>  there.  Once I deleted them, everything worked fine.  The previous
>  version of 4.15 I successfully built was in F25, and I'm now building in
>  rawhide, and it had the obsolete ppc64p7 config file I SOURCES from
>  older builds.
>
>  Sorry for the noise, but thanks for the help. 
No issues, I always find "git status" is a big help here with kernel
stuff, especially when it comes to stuff that might be generated.