From: Al Stone ahs3@redhat.com
Clean up the config for the Tegra186 timer
This device is used by NVIDIA Orin and needs to be enabled for arm64. However, the default is to be not set so we can move this to common and simplify.
Signed-off-by: Al Stone ahs3@redhat.com
diff --git a/redhat/configs/ark/generic/CONFIG_TEGRA186_TIMER b/redhat/configs/common/generic/arm/CONFIG_TEGRA186_TIMER rename from redhat/configs/ark/generic/CONFIG_TEGRA186_TIMER rename to redhat/configs/common/generic/arm/CONFIG_TEGRA186_TIMER index blahblah..blahblah 100644 --- a/redhat/configs/ark/generic/CONFIG_TEGRA186_TIMER +++ b/redhat/configs/common/generic/arm/CONFIG_TEGRA186_TIMER diff --git a/redhat/configs/fedora/generic/arm/aarch64/CONFIG_TEGRA186_TIMER b/redhat/configs/common/generic/arm/aarch64/CONFIG_TEGRA186_TIMER rename from redhat/configs/fedora/generic/arm/aarch64/CONFIG_TEGRA186_TIMER rename to redhat/configs/common/generic/arm/aarch64/CONFIG_TEGRA186_TIMER index blahblah..blahblah 100644 --- a/redhat/configs/fedora/generic/arm/aarch64/CONFIG_TEGRA186_TIMER +++ b/redhat/configs/common/generic/arm/aarch64/CONFIG_TEGRA186_TIMER diff --git a/redhat/configs/fedora/generic/arm/CONFIG_TEGRA186_TIMER b/redhat/configs/fedora/generic/arm/CONFIG_TEGRA186_TIMER deleted file mode 100644 index blahblah..blahblah 0 --- a/redhat/configs/fedora/generic/arm/CONFIG_TEGRA186_TIMER +++ /dev/null @@ -1 +0,0 @@ -# CONFIG_TEGRA186_TIMER is not set
-- https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2166
From: Al Stone on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2166#note_1191921...
TIL: 'make dist-configs' != 'make dist-rhel-configs && make dist-fedora- configs'
Sorry about that -- bad testing on my part; this version of the patch is a tad simpler. Default CONFIG_TEGRA186_TIMER to not set, but turn it on for aarch64, for all flavors.
From: pbrobinson on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2166#note_1191929...
LGTM
From: Mark Salter on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2166#note_1194817...
Just FYI, tegra186 and higher (tegra194, tegra234, etc) are aarch64, so no need for anything in the arm dir.
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2166#note_1194864...
Fedora drops 32 bit arm when F36 goes EOL in roughly 7 months. At that point, I expect we will do the same consolidation done for x86, and the aarch64 directory will go away, moving the contents up a level to just arm/
From: Al Stone on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2166#note_1195334...
Right -- istr that the configs weren't processing correctly if I skipped the arm dir, but I'll double check that.
@jmflinuxtx : so are you suggesting I should fix this or it's fine as is since 32-bit will be going away anyway? I'll assume the former unless you say otherwise.
Thanks for the reviews.
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2166#note_1195335...
I was saying it is fine as 32bit will be going away.
From: Al Stone on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2166#note_1197010...
Thanks, Justin. I just wanted to be sure I understood.
And yes, ```make dist-fedora-configs``` fails if I remove the entry in arm (the arm7hl configs are missing the entry). So, the moral is, I believe, that this patch is fine as is, and when 32-bit goes away, the configs will get simpler.
Thanks for the reviews.
kernel@lists.fedoraproject.org