From: Eric Auger eric.auger@redhat.com
redhat/configs: Set PVPANIC_MMIO for x86 and PVPANIC_PCI for aarch64
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1961178 Upstream Status: RHEL only Tested: on x86 with libvirt, on ARM with qemu as pvpanic-pci is not yet integrated in libvirt
With the introduction of pvpanic-pci new configs were introduced for the MMIO and PCI flavour. On x86, currently none is set so the ISA device is not available (this is a regression). The MMIO flavour must be used on x86_64.
On ARM, the PCI one must be set.
Signed-off-by: Eric Auger eric.auger@redhat.com
---
v1 -> v2: - s/y/m for PCI and MMIO configs
diff --git a/redhat/configs/ark/generic/arm/aarch64/CONFIG_PVPANIC b/redhat/configs/ark/generic/arm/aarch64/CONFIG_PVPANIC new file mode 100644 index blahblah..blahblah 100644 --- /dev/null +++ b/redhat/configs/ark/generic/arm/aarch64/CONFIG_PVPANIC @@ -0,0 +1 @@ +CONFIG_PVPANIC=y diff --git a/redhat/configs/ark/generic/arm/aarch64/CONFIG_PVPANIC_MMIO b/redhat/configs/ark/generic/arm/aarch64/CONFIG_PVPANIC_MMIO new file mode 100644 index blahblah..blahblah 100644 --- /dev/null +++ b/redhat/configs/ark/generic/arm/aarch64/CONFIG_PVPANIC_MMIO @@ -0,0 +1 @@ +# CONFIG_PVPANIC_MMIO is not set diff --git a/redhat/configs/ark/generic/arm/aarch64/CONFIG_PVPANIC_PCI b/redhat/configs/ark/generic/arm/aarch64/CONFIG_PVPANIC_PCI new file mode 100644 index blahblah..blahblah 100644 --- /dev/null +++ b/redhat/configs/ark/generic/arm/aarch64/CONFIG_PVPANIC_PCI @@ -0,0 +1 @@ +CONFIG_PVPANIC_PCI=m diff --git a/redhat/configs/ark/generic/x86/x86_64/CONFIG_PVPANIC_MMIO b/redhat/configs/ark/generic/x86/x86_64/CONFIG_PVPANIC_MMIO new file mode 100644 index blahblah..blahblah 100644 --- /dev/null +++ b/redhat/configs/ark/generic/x86/x86_64/CONFIG_PVPANIC_MMIO @@ -0,0 +1 @@ +CONFIG_PVPANIC_MMIO=m diff --git a/redhat/configs/ark/generic/x86/x86_64/CONFIG_PVPANIC_PCI b/redhat/configs/ark/generic/x86/x86_64/CONFIG_PVPANIC_PCI new file mode 100644 index blahblah..blahblah 100644 --- /dev/null +++ b/redhat/configs/ark/generic/x86/x86_64/CONFIG_PVPANIC_PCI @@ -0,0 +1 @@ +# CONFIG_PVPANIC_PCI is not set
-- https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1158
From: Eric Auger on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1158#note_5863449...
I have updated the MR to set MMIO and PCI configs to "m"
From: John Linville on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1158#note_5870263...
Acked-by: John W. Linville linville@redhat.com
From: Patrick Talbert on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1158#note_5876386...
@bonzini Were your concerns addressed?
From: Andrew Jones on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1158#note_5892305...
Is there any reason not to enable the PCI version of the device for x86 and/or for any other supported architecture that supports PCI and wants to support the pvpanic device?
From: Eric Auger on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1158#note_5901059...
At this stage my goal was just to fix the regression on x86 PVPANIC/ISA while adding the functionality on aarch64. If we decide to add PVPANIC-PCI on x86 this may handled through another BZ to also test it separately. Also libvirt wouldn't support it.
From: Andrew Jones on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1158#note_5901422...
A separate BZ for x86 pci pvpanic makes sense, as support for it should be discussed. The libvirt reason shouldn't make a difference though, since libvirt will be gaining support for AArch64's pci pvpanic and therefore would also support x86 pci pvpanic at the same time.
From: Andrew Jones on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1158#note_5901444...
Since I don't have an ACK button...
Acked-by: Andrew Jones drjones@redhat.com
From: Eric Auger on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1158#note_5901502...
Yes. I meant this would deserve separate enablement and testing at libvirt level AND qemu level. I guess the pvpanic-pci device is not compiled either at qemu level for x86. Anyway I would be in favour of handling this in a separate BZ if we decide to support it. I can raise the point on virt-devel. Drew can you close the thread if you're OK.
kernel@lists.fedoraproject.org
-
Andrew Jones (via Email Bridge) -
Eric Auger (via Email Bridge)
-
John Linville (via Email Bridge)
-
Patrick Talbert (via Email Bridge)