[OS-BUILD PATCH] all: Changing CONFIG_UV_SYSFS to build uv_sysfs.ko as a loadable

[Frank Ramsay (via Email Bridge)]

From: Frank Ramsay

all: Changing CONFIG_UV_SYSFS to build uv_sysfs.ko as a loadable
module.

There is no advantage to this being a built-in; and the vendor prefers
it being a loadable module.

signed-off-by: Frank Ramsay

diff --git a/redhat/configs/common/generic/CONFIG_UV_SYSFS b/redhat/configs/common/generic/CONFIG_UV_SYSFS
index blahblah..blahblah 100644
--- a/redhat/configs/common/generic/CONFIG_UV_SYSFS
+++ b/redhat/configs/common/generic/CONFIG_UV_SYSFS
@@ -1 +1 @@
-CONFIG_UV_SYSFS=y
+CONFIG_UV_SYSFS=m

--
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1165

[David Arcari (via Email Bridge)]

From: David Arcari on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1165#note_5918689...

Acked-by: David Arcari 
(via approve button)

[Patrick Talbert (via Email Bridge)]

From: Patrick Talbert on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1165#note_5918788...

There is a separate definition for this config item in fedora so the change
here will not affect it.

[David Arcari (via Email Bridge)]

From: David Arcari on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1165#note_5918812...

Is the separate config for Fedora intentional or should we unify the two?

[Patrick Talbert (via Email Bridge)]

From: Patrick Talbert on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1165#note_5919274...

It is currently disabled in fedora:

https://gitlab.com/cki-project/kernel-ark/-/blob/os-
build/redhat/configs/fedora/generic/CONFIG_UV_SYSFS

@jmflinuxtx, thoughts?

[Justin Forbes (via Email Bridge)]

From: Justin Forbes on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1165#note_5920152...

I haven't had a request to turn on UV for Fedora, and I am not sure that there
is anyone interested in it, but I don't have an issue with flipping it on if
anyone is.

[Frank Ramsay (via Email Bridge)]

From: Frank Ramsay on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1165#note_5920559...

You can turn it on if you wish but HPE does not support Fedora on UV systems.
Which is why I didn't change the fedora config.

[David Arcari (via Email Bridge)]

From: David Arcari on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1165#note_5920731...

OK - let's just leave Fedora as is.  Seems to make sense in this case.

[Prarit Bhargava (via Email Bridge)]

From: Prarit Bhargava on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1165#note_5920741...

Would it hurt to switch Fedora to "is not set" with a note to THIS MR so we
can point to this simple discussion in the future?

Just a thought.

[Justin Forbes]

On Thu, Jun 3, 2021 at 8:22 AM Prarit Bhargava (via Email Bridge)
 wrote:
> From: Prarit Bhargava on gitlab.com
> https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1165#note_5920741...
>
> Would it hurt to switch Fedora to "is not set" with a note to THIS MR so we
> can point to this simple discussion in the future?
>
> Just a thought.

Fedora already "is not set" so there is nothing to change there. I
don't have an issue with a note being added, and honestly I am not too
concerned with what HPE supports. If we have users requesting it be
turned on because they feel like experimenting, I can turn it on. I
just haven't had anyone ask, and assume no one is wanting to run
Fedora in this environment.

Justin

[Frank Ramsay (via Email Bridge)]

From: Frank Ramsay on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1165#note_5956439...

Is there anything else I need to do on this MR to get it to move forward?

[Patrick Talbert (via Email Bridge)]

From: Patrick Talbert on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1165#note_5956706...

It was merged five days ago.

If you want to see CONFIG_UV_SYSFS enabled for fedora that will need a
separate MR.