[Fedora PATCH]: BZ 234473 Remove sparse directory listing from kernel rpmbuild

[Prarit Bhargava]

Currently, rpmbuild -bp kernel-2.6.spec does

/usr/bin/bzip2 -dc /usr/src/redhat/SOURCES/sparse-0.2.tar.bz2
tar -xvvf -

which displays the directory of what has been untarred:

drwxrwxrwx git/git           0 2006-12-05 06:22:44 sparse-0.2/
(snip 123 lines)

I'm not sure if the full directory listing of sparse is needed.  If it isn't,
then let's clean it up.

Resolves BZ 234473.

Signed-off-by: Prarit Bhargava <prarit(a)redhat.com&gt;

--- kernel-2.6.spec.orig	2007-03-29 06:04:13.000000000 -0400
+++ kernel-2.6.spec	2007-03-29 06:04:16.000000000 -0400
@@ -1219,7 +1219,7 @@
 
 # unpack sparse.
 if [ ! -d sparse-%{sparsever} ] ; then
-%setup -T -D -a 3 -q
+%setup -D -T -q -a3
 fi
 
 # Unpack the Xen tarball.

[Pete Zaitcev]

On Thu, 29 Mar 2007 11:29:21 -0400, Prarit Bhargava <prarit(a)redhat.com&gt; wrote:

>  +++ kernel-2.6.spec	2007-03-29 06:04:16.000000000 -0400
>  @@ -1219,7 +1219,7 @@
>   
>   # unpack sparse.
>   if [ ! -d sparse-%{sparsever} ] ; then
>  -%setup -T -D -a 3 -q
>  +%setup -D -T -q -a3
>   fi 
This looks nice and to the point.

However, it would be great if someone just added the sparse package
to Fedora and the we'd have BuildRequires instead of monkeying with
it on every build. It already takes several hours on my 3GHz Pentium D.

-- Pete

[Jarod Wilson]

Pete Zaitcev wrote:
>  On Thu, 29 Mar 2007 11:29:21 -0400, Prarit Bhargava
> <prarit(a)redhat.com&gt; wrote:
>  
> > +++ kernel-2.6.spec	2007-03-29 06:04:16.000000000 -0400
> > @@ -1219,7 +1219,7 @@
> >  
> >  # unpack sparse.
> >  if [ ! -d sparse-%{sparsever} ] ; then
> > -%setup -T -D -a 3 -q
> > +%setup -D -T -q -a3
> >  fi
>  
>  This looks nice and to the point.
>  
>  However, it would be great if someone just added the sparse package
>  to Fedora and the we'd have BuildRequires instead of monkeying with
>  it on every build. It already takes several hours on my 3GHz Pentium D. 
I can't recall if I heard what (if any) roadblocks there were to it
being packaged in fedora, but if so desired, I'd be happy to take a
crack at packaging it up.

-- 
Jarod Wilson
jwilson(a)redhat.com

[Jon Masters]

Pete Zaitcev wrote:
>  On Thu, 29 Mar 2007 11:29:21 -0400, Prarit Bhargava
> <prarit(a)redhat.com&gt; wrote:
>  
> > +++ kernel-2.6.spec	2007-03-29 06:04:16.000000000 -0400
> > @@ -1219,7 +1219,7 @@
> >  
> >  # unpack sparse.
> >  if [ ! -d sparse-%{sparsever} ] ; then
> > -%setup -T -D -a 3 -q
> > +%setup -D -T -q -a3
> >  fi
>  
>  This looks nice and to the point.
>  
>  However, it would be great if someone just added the sparse package
>  to Fedora and the we'd have BuildRequires instead of monkeying with
>  it on every build. It already takes several hours on my 3GHz Pentium D. 
Pete,

I think Dave already mentioned that it *is* planned to add this to 
Fedora but he's just waiting on the merge status, I think?

Jon.

[Dave Jones]

On Thu, Mar 29, 2007 at 01:37:13PM -0400, Jon Masters wrote:
>  Pete Zaitcev wrote:
>  > On Thu, 29 Mar 2007 11:29:21 -0400, Prarit Bhargava <prarit(a)redhat.com&gt;
> wrote:
>  > 
>  >> +++ kernel-2.6.spec	2007-03-29 06:04:16.000000000 -0400
>  >> @@ -1219,7 +1219,7 @@
>  >>  
>  >>  # unpack sparse.
>  >>  if [ ! -d sparse-%{sparsever} ] ; then
>  >> -%setup -T -D -a 3 -q
>  >> +%setup -D -T -q -a3
>  >>  fi
>  > 
>  > This looks nice and to the point.
>  > 
>  > However, it would be great if someone just added the sparse package
>  > to Fedora and the we'd have BuildRequires instead of monkeying with
>  > it on every build. It already takes several hours on my 3GHz Pentium D.
>  
>  Pete,
>  
>  I think Dave already mentioned that it *is* planned to add this to 
>  Fedora but he's just waiting on the merge status, I think? 
Right. iirc, Matt Domsch has it packaged for extras already.
But core packages right now can't depend on extras packages to build.
Once the core/extras merge is complete, all this stuff goes
away, and just becomes another BuildRequires:

	Dave

-- 
http://www.codemonkey.org.uk

[Jon Masters]

Dave Jones wrote:
>  On Thu, Mar 29, 2007 at 01:37:13PM -0400, Jon Masters wrote:
>   > Pete Zaitcev wrote:
>   > > On Thu, 29 Mar 2007 11:29:21 -0400, Prarit Bhargava <prarit(a)redhat.com&gt;
> wrote:
>   > > 
>   > >> +++ kernel-2.6.spec	2007-03-29 06:04:16.000000000 -0400
>   > >> @@ -1219,7 +1219,7 @@
>   > >>  
>   > >>  # unpack sparse.
>   > >>  if [ ! -d sparse-%{sparsever} ] ; then
>   > >> -%setup -T -D -a 3 -q
>   > >> +%setup -D -T -q -a3
>   > >>  fi
>   > > 
>   > > This looks nice and to the point.
>   > > 
>   > > However, it would be great if someone just added the sparse package
>   > > to Fedora and the we'd have BuildRequires instead of monkeying with
>   > > it on every build. It already takes several hours on my 3GHz Pentium D.
>   > 
>   > Pete,
>   > 
>   > I think Dave already mentioned that it *is* planned to add this to 
>   > Fedora but he's just waiting on the merge status, I think?
>  
>  Right. iirc, Matt Domsch has it packaged for extras already.
>  But core packages right now can't depend on extras packages to build.
>  Once the core/extras merge is complete, all this stuff goes
>  away, and just becomes another BuildRequires: 
And on that blissful day...we're drinking pints! :-)

Jon.

[Josh Boyer]

On Thu, 2007-03-29 at 13:46 -0400, Jon Masters wrote:
>  Dave Jones wrote:
>  > On Thu, Mar 29, 2007 at 01:37:13PM -0400, Jon Masters wrote:
>  >  > Pete Zaitcev wrote:
>  >  > > On Thu, 29 Mar 2007 11:29:21 -0400, Prarit Bhargava
> <prarit(a)redhat.com&gt; wrote:
>  >  > > 
>  >  > >> +++ kernel-2.6.spec	2007-03-29 06:04:16.000000000 -0400
>  >  > >> @@ -1219,7 +1219,7 @@
>  >  > >>  
>  >  > >>  # unpack sparse.
>  >  > >>  if [ ! -d sparse-%{sparsever} ] ; then
>  >  > >> -%setup -T -D -a 3 -q
>  >  > >> +%setup -D -T -q -a3
>  >  > >>  fi
>  >  > > 
>  >  > > This looks nice and to the point.
>  >  > > 
>  >  > > However, it would be great if someone just added the sparse package
>  >  > > to Fedora and the we'd have BuildRequires instead of monkeying with
>  >  > > it on every build. It already takes several hours on my 3GHz Pentium D.
>  >  > 
>  >  > Pete,
>  >  > 
>  >  > I think Dave already mentioned that it *is* planned to add this to 
>  >  > Fedora but he's just waiting on the merge status, I think?
>  > 
>  > Right. iirc, Matt Domsch has it packaged for extras already.
>  > But core packages right now can't depend on extras packages to build.
>  > Once the core/extras merge is complete, all this stuff goes
>  > away, and just becomes another BuildRequires:
>  
>  And on that blissful day...we're drinking pints! :-) 
Which kind?  I vote for GB pints.  They're bigger then our piddly 16oz
US pints.

josh