From: Scott Weaver scweaver@redhat.com
kernel.spec: add llvm-devel build requirement
The bpftool and the llvm system feature check requires the llvm-devel package. The bpftool package is only created if selftests is defined and when selftests is enabled, then samples/bpf will be built which will use the llvm feature check. Therefore the llvm-devel package is added as a build requirement of selftests to keep it consistent with the llvm package already specified there.
This change came in eb9d1acf634ba ('bpftool: Add LLVM as default library for disassembling JIT-ed programs').
Signed-off-by: Scott Weaver scweaver@redhat.com
diff --git a/redhat/kernel.spec.template b/redhat/kernel.spec.template index blahblah..blahblah 100755 --- a/redhat/kernel.spec.template +++ b/redhat/kernel.spec.template @@ -635,7 +635,7 @@ BuildRequires: python3-docutils BuildRequires: zlib-devel binutils-devel %endif %if %{with_selftests} -BuildRequires: clang llvm fuse-devel +BuildRequires: clang llvm llvm-devel fuse-devel %ifnarch %{arm} BuildRequires: numactl-devel %endif
-- https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2264
From: Scott Weaver on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2264#note_1252396...
After looking again, I see that my mistake was in how I described why the package should be associated with selftests. Because samples/bpf will be built when selftests is enabled and it will use the llvm system feature check the package should still be associated with selftests' build requirement. I've cleaned up my commit message.
kernel@lists.fedoraproject.org