surface pro 3 custom kernel

[Joao Cortes]

Hi, 
I am following the instructions found in
1. https://docs.pagure.org/docs-fedora/building-custom-kernel.html
2. https://fedoraproject.org/wiki/Building_a_custom_kernel.

I am trying to get fedora 29 support for microsoft surface pro 3 (including 
dock support).
I am patching the 4.18.18-fc29 kernel, using the patches found in
 https://github.com/jakeday/linux-surface, branch 4.18.20-4.

This is what I have done,
`
git clone https://github.com/jakeday/linux-surface
cd linux-surface
git checkout 4.18.20-4
cd ../
fedpkg clone -a kernel
cd kernel
fedpkg switch-branch f29
#going back to 4.18.18,
git reset  --hard 87f9453dd6777020e4968779d61437a6f20b3614
for i in ../linux-surface/patches/4.18/*; do ./scripts/newpatch.sh $i; done
cp ../linux-surface/patches/4.18/* .
`

After running `fedpkg prep` (Is this a good way to test?),
``
Applying: hid
Applying: sdcard_reader
Applying: 
fatal: empty ident name (for <>) not allowed
error: Bad exit status from /var/tmp/rpm-tmp.ul7jtS (%prep)
``
Removing two of jakeday's patches (0008-wifi.patch, 0009-surface3_power.patch)
solves the issue. 
    1. This error indicates there is something wrong with the patch files? It is issued by
git

Running again `fedpkg prep`, 
`
Found unset config items, please set them to an appropriate value
CONFIG_INTEL_IPTS=n
CONFIG_SURFACE_ACPI=n
`

I added both options to kernel-local file, but the error persists.
It seems the file is not being used.
   2. Is it possible to debug the total list of config options, including
those added in kernel-local?

Thanks
João Cortes

[Peter Robinson]

On Fri, Jan 18, 2019 at 1:05 PM Joao Cortes <joaooneillcortes(a)outlook.pt&gt; wrote:
>  Hi,
>  I am following the instructions found in
>  1. https://docs.pagure.org/docs-fedora/building-custom-kernel.html
>  2. https://fedoraproject.org/wiki/Building_a_custom_kernel.
>
>  I am trying to get fedora 29 support for microsoft surface pro 3 (including
>  dock support).
>  I am patching the 4.18.18-fc29 kernel, using the patches found in
>   https://github.com/jakeday/linux-surface, branch 4.18.20-4.
>
>  This is what I have done,
>  `
>  git clone https://github.com/jakeday/linux-surface
>  cd linux-surface
>  git checkout 4.18.20-4
>  cd ../
>  fedpkg clone -a kernel
>  cd kernel
>  fedpkg switch-branch f29
>  #going back to 4.18.18,
>  git reset  --hard 87f9453dd6777020e4968779d61437a6f20b3614
>  for i in ../linux-surface/patches/4.18/*; do ./scripts/newpatch.sh $i; done
>  cp ../linux-surface/patches/4.18/* .
>  `
>
>  After running `fedpkg prep` (Is this a good way to test?),
>  ``
>  Applying: hid
>  Applying: sdcard_reader
>  Applying:
>  fatal: empty ident name (for <>) not allowed
>  error: Bad exit status from /var/tmp/rpm-tmp.ul7jtS (%prep)
>  ``
>  Removing two of jakeday's patches (0008-wifi.patch, 0009-surface3_power.patch)
>  solves the issue.
>      1. This error indicates there is something wrong with the patch files? It is issued
> by git 
It indicates there's issues with the patches applying cleanly using
"git am" against the Fedora kernel.

>  Running again `fedpkg prep`,
>  `
>  Found unset config items, please set them to an appropriate value
>  CONFIG_INTEL_IPTS=n
>  CONFIG_SURFACE_ACPI=n
>  `
>
>  I added both options to kernel-local file, but the error persists.
>  It seems the file is not being used.
>     2. Is it possible to debug the total list of config options, including
>  those added in kernel-local? 
Did you run ./build_configs.sh once you added them to regenerate the
configs? Once you've run that if you do a "git diff" you should see
the changes in the kernel-*.config files

[Joao Cortes]

Thank you for the help.

The patch files were not generated with git format-patch, therefore
git can't find some of the metadata. Hence the error 1.

I did run the ./build_configs.sh script, but the only file changed after 
editing kernel-local was kernel-local itself:
`
./build_configs.sh 
`
``
Building ../kernel_surface/kernel/kernel-x86_64.config ... done
Building ../kernel/kernel-x86_64-debug.config ... done
Building ./kernel/kernel-i686.config ... done
Building ./kernel_surface/kernel/kernel-i686-debug.config ... done
Building ./kernel/kernel-i686-PAE.config ... done
Building ./kernel/kernel-i686-PAEdebug.config ... done
Building ./kernel/kernel-ppc64le.config ... done
Building ./kernel/kernel-ppc64le-debug.config ... done
Building ./kernel/kernel-s390x.config ... done
Building ./kernel/kernel-s390x-debug.config ... done
Building ./kernel/kernel-aarch64.config ... done
Building ./kernel-aarch64-debug.config ... done
Building ./kernel/kernel-armv7hl.config ... done
Building ./kernel/kernel-armv7hl-debug.config ... done
Building ./kernel/kernel-armv7hl-lpae.config ... done
Building ./kernel/kernel-armv7hl-lpae-debug.config ... done
``

`
git diff kernel-*
`
``
diff --git a/kernel-local b/kernel-local
index 8c32be5be..fd1c56763 100644
--- a/kernel-local
+++ b/kernel-local
@@ -1,2 +1,5 @@
 # This file is intentionally left empty in the stock kernel. Its a nicety
 # added for those wanting to do custom rebuilds with altered config opts.
+CONFIG_INTEL_IPTS=n
+CONFIG_SURFACE_ACPI=n
``


From: Peter Robinson <pbrobinson(a)gmail.com&gt;
Sent: 19 January 2019 00:18
To: Joao Cortes
Cc: kernel(a)lists.fedoraproject.org
Subject: Re: surface pro 3 custom kernel
 
On Fri, Jan 18, 2019 at 1:05 PM Joao Cortes <joaooneillcortes(a)outlook.pt&gt; wrote:
>  Hi,
>  I am following the instructions found in
>  1. https://docs.pagure.org/docs-fedora/building-custom-kernel.html
>  2. https://fedoraproject.org/wiki/Building_a_custom_kernel.
>
>  I am trying to get fedora 29 support for microsoft surface pro 3 (including
>  dock support).
>  I am patching the 4.18.18-fc29 kernel, using the patches found in
>   https://github.com/jakeday/linux-surface, branch 4.18.20-4.
>
>  This is what I have done,
>  `
>  git clone https://github.com/jakeday/linux-surface
>  cd linux-surface
>  git checkout 4.18.20-4
>  cd ../
>  fedpkg clone -a kernel
>  cd kernel
>  fedpkg switch-branch f29
>  #going back to 4.18.18,
>  git reset  --hard 87f9453dd6777020e4968779d61437a6f20b3614
>  for i in ../linux-surface/patches/4.18/*; do ./scripts/newpatch.sh $i; done
>  cp ../linux-surface/patches/4.18/* .
>  ` 
>  Running again `fedpkg prep`,
>  `
>  Found unset config items, please set them to an appropriate value
>  CONFIG_INTEL_IPTS=n
>  CONFIG_SURFACE_ACPI=n
>  `
>
>  I added both options to kernel-local file, but the error persists.
>  It seems the file is not being used.
>     2. Is it possible to debug the total list of config options, including
>  those added in kernel-local? 
Did you run ./build_configs.sh once you added them to regenerate the
configs? Once you've run that if you do a "git diff" you should see
the changes in the kernel-*.config files