Re: [PATCH] kernel-tools.spec: Adding libbpf package

[Jiri Olsa]

On Tue, Apr 02, 2019 at 02:25:26PM +0200, Jesper Dangaard Brouer wrote:
>  On Tue, 2 Apr 2019 12:35:10 +0200
>  Jiri Olsa <jolsa(a)redhat.com&gt; wrote:
>  
>  > We need libbpf in a separate package, starting with basic
>  > files, some more might come later if there's a need.
>  [...]
>  
>  > ---
>  > Packaging libbpf library, resulting in 3 packages:
>  >   libbpf
>  >   libbpf-devel
>  >   libbpf-debuginfo
>  > 
>  [...]
>  > $ rpm -qpl libbpf-devel-5.1.0-0.rc3.git0.1.fc31.x86_64.rpm
>  > /usr/include/bpf/bpf.h
>  > /usr/include/bpf/btf.h
>  > /usr/include/bpf/libbpf.h
>  
>  I'm using libbpf as a git-submodule, for my XDP-tutorial examples.
>   https://github.com/xdp-project/xdp-tutorial/
>  
>  And it seems to match the "installed" include files this proj depend on:
>  
>   $ find libbpf/src/root/usr/include/ -type f 
>   libbpf/src/root/usr/include/bpf/bpf.h
>   libbpf/src/root/usr/include/bpf/libbpf.h
>   libbpf/src/root/usr/include/bpf/btf.h
>  
>  As you mention some more might come later, like xsk.h for AF_XDP.
>  
>  
>  For my XDP-tutorial examples, I did end-up with some extra headers
>  files that I copied from the kernel tree, and even modified a bit, for
>  getting compiling working.  BUT I'm not sure they belong in in the
>  libbpf-devel.
>  
>  https://github.com/xdp-project/xdp-tutorial/tree/master/headers
>  
>   $ ls -1 headers/
>   bpf_endian.h
>   bpf_helpers.h
>   bpf_util.h
>   jhash.h
>   perf-sys.h 
ok, perhaps we should put all the needed helpers under libbpf
tree in the kernel sources first, and then we can package them

I dont like the idea of moving headers from distinct places
in kernel into libbpf include directory

jirka