From: Thorsten Leemhuis fedora@leemhuis.info
set a more reasonable default for number of jobs
Instead of just one use four jobs by default, which is a more reasonable default these days. The worst that can^w should happen is some performance drop due to increased concurrency in setups with less than four CPU cores.
Signed-off-by: Thorsten Leemhuis fedora@leemhuis.info
diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -99,7 +99,7 @@ endif ifndef RHJOBS RHJOBS=$(shell j=$$(echo $(MAKEFLAGS) | grep -Eo "(^|[ ])-j[0-9]*" | xargs ); \ if [ -z "$${j}" ]; then \ - echo "1"; \ + echo "4"; \ else \ j=$$(echo "$${j}" | tr -d "-j"); \ [ -z "$${j}" ] && nproc || echo $${j}; \
-- https://gitlab.com/cki-project/kernel-ark/-/merge_requests/3589
From: Eder Zulian on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/3589#note_2338818...
Hi everyone, the patch looks good to me. But I saw that 'make dist-self-test' will fail because it checks against the previous default value 'RHELJOBS=1'. I think that at some point we need to run a 'make dist-self-test-data' to update the contents of 'redhat/selftest/data/*'. I am not sure about when that should happen. What do you think? Thank you. Eder
From: Eder Zulian on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/3589#note_2338818...
Hi everyone, the patch looks good to me. But I saw that 'make dist-self-test' will fail because it checks against the previous default value 'RHJOBS=1'. I think that at some point we need to run a 'make dist-self-test-data' to update the contents of 'redhat/selftest/data/*'. I am not sure about when that should happen. What do you think? Thank you. Eder
From: Jan Stancek on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/3589#note_2338821...
@ptalbert Would you be willing to regenerate test data during merge (and squash it with this change)?
kernel@lists.fedoraproject.org
-
Eder Zulian (via Email Bridge) -
Jan Stancek (via Email Bridge)
-
Thorsten Leemhuis (via Email Bridge)