From: CKI Gitlab on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1220 NOTE: Truncated patchset due to missing public @redhat.com email address on your GitLab profile at https://gitlab.com/-/profile. Once that is fixed, close and reopen the merge request to retrigger sending the emails.
Hi,
As part of the ongoing rebase effort, the following configuration options need to be reviewed.
As a reminder, the ARK configuration flow involves moving unreviewed configuration options from the pending directory to the ark directory. In the diff below, options are removed from the pending directory and added to the ark hierarchy. The final options that need to be ACKed are the files that are being added to the ark hierarchy.
If the value for a file that is added should be changed, please reply with a better option.
CONFIG_SND_SOC_INTEL_SOF_CS42L42_MACH:
This adds support for ASoC machine driver for SOF platforms with cs42l42 codec. Say Y if you have such a device. If unsure select "N".
Symbol: SND_SOC_INTEL_SOF_CS42L42_MACH [=n] Type : tristate Defined at sound/soc/intel/boards/Kconfig:483 Prompt: SOF with cs42l42 codec in I2S Mode Depends on: SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && SND_SOC_INTEL_MACH [=y] && (SND_SOC_SOF_HDA_LINK [=y] || SND_SOC_SOF_BAYTRAIL [=m]) && I2C [=y] && ACPI [=y] && SND_HDA_CODEC_HDMI [=m] && SND_SOC_SOF_HDA_AUDIO_CODEC [=y] && (MFD_INTEL_LPSS [=y] || COMPILE_TEST [=n]) Location: -> Device Drivers -> Sound card support (SOUND [=m]) -> Advanced Linux Sound Architecture (SND [=m]) -> ALSA for SoC audio support (SND_SOC [=m]) -> Intel Machine drivers (SND_SOC_INTEL_MACH [=y]) Selects: SND_SOC_CS42L42 [=n] && SND_SOC_MAX98357A [=m] && SND_SOC_DMIC [=m] && SND_SOC_HDAC_HDMI [=m] && SND_SOC_INTEL_HDA_DSP_COMMON [=m] && SND_SOC_INTEL_SOF_MAXIM_COMMON [=m]
---
CONFIG_SND_SOC_TFA989X:
Enable support for NXP (now Goodix) TFA989X (TFA1 family) speaker amplifiers, e.g. TFA9895. Note that the driver currently bypasses the built-in "CoolFlux DSP" and does not support (hardware) volume control.
Symbol: SND_SOC_TFA989X [=n] Type : tristate Defined at sound/soc/codecs/Kconfig:1420 Prompt: NXP/Goodix TFA989X (TFA1) amplifiers Depends on: SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && I2C [=y] Location: -> Device Drivers -> Sound card support (SOUND [=m]) -> Advanced Linux Sound Architecture (SND [=m]) -> ALSA for SoC audio support (SND_SOC [=m]) -> CODEC drivers Selects: REGMAP_I2C [=m] Implied by [n]: - SND_SOC_ALL_CODECS [=n] && SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && COMPILE_TEST [=n]
---
Cc: Jaroslav Kysela jkysela@redhat.com Signed-off-by: Fedora Kernel Team kernel-team@fedoraproject.org
--- redhat/configs/common/generic/CONFIG_SND_SOC_INTEL_SOF_CS42L42_MACH | 1 + redhat/configs/common/generic/CONFIG_SND_SOC_TFA989X | 1 + redhat/configs/pending-common/generic/CONFIG_SND_SOC_INTEL_SOF_CS42L42_MACH | 23 --------- redhat/configs/pending-common/generic/CONFIG_SND_SOC_TFA989X | 25 ---------- 4 files changed, 2 insertions(+), 48 deletions(-)
From: Patrick Talbert on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1220#note_6212771...
Thank you Jaroslav. I've updated the MR. As always, all the commits in this MR will be squashed upon merge.
Patrick
From: Jaroslav Kysela on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1220#note_6220030...
I apologize for the missing info. The Intel SOF configs are x86_64 specific.
From: Patrick Talbert on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1220#note_6239639...
Done.
From: Patrick Talbert on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1220#note_6410078...
@jkysela are we good here now?
From: Jaroslav Kysela on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1220#note_6420281...
CONFIG_SND_SOC_TFA989X should be kept in generic tree, only CONFIG_SND_SOC_INTEL_SOF_CS42L42_MACH is x86_64 specific. Thank you.
From: Patrick Talbert on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1220#note_6438549...
Done.
From: Patrick Talbert on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1220#note_6438986...
The problem now is that CONFIG_SND_SOC_INTEL_SOF_CS42L42_MACH selects all of the following:
SND_SOC_CS42L42 SND_SOC_MAX98357A SND_SOC_DMIC SND_SOC_HDAC_HDMI SND_SOC_INTEL_HDA_DSP_COMMON SND_SOC_INTEL_SOF_MAXIM_COMMON
This is a problem because redhat/configs/ark/generic/CONFIG_SND_SOC_CS42L42 explicitly disables that option and so there is a mismatch.
The simple solution is to remove the redhat/configs/ark/generic/CONFIG_SND_SOC_CS42L42 file so I've pushed a new version.
From: Jaroslav Kysela on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1220#note_6442264...
Thank you Patrick. I already realized that the ARK ALSA / SoundWire configs are really out of sync against RHEL 8.5 (missing SoundWire drivers and many Intel SOF driver related options).
I tried to review all options one-by-one and the result is here: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1294
I appreciate any comments and I will try to fix build errors when CKI fails.
From: Jaroslav Kysela on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1220#note_6529421...
I think that this should be closed now - resolved in https://gitlab.com/cki- project/kernel-ark/-/merge_requests/1294 .
From: Patrick Talbert on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1220#note_6529662...
Absolutely.
kernel@lists.fedoraproject.org