From: Fedora Kernel Team kernel-team@fedoraproject.org
[redhat] New configs in mm/Kconfig
Hi,
As part of the ongoing rebase effort, the following configuration options need to be reviewed.
As a reminder, the ARK configuration flow involves moving unreviewed configuration options from the pending directory to the ark directory. In the diff below, options are removed from the pending directory and added to the ark hierarchy. The final options that need to be ACKed are the files that are being added to the ark hierarchy.
If the value for a file that is added should be changed, please reply with a better option.
Symbol: PAGE_BLOCK_ORDER [=10] Type : integer Range : [1 10] Defined at mm/Kconfig:1008 Prompt: Page Block Order Location: -> Memory Management options -> Page Block Order (PAGE_BLOCK_ORDER [=10])
Commit: e13e7922d034 (mm: add CONFIG_PAGE_BLOCK_ORDER to select page block order)
---
Signed-off-by: Fedora Kernel Team kernel-team@fedoraproject.org
diff --git a/redhat/configs/pending-rhel/generic/CONFIG_PAGE_BLOCK_ORDER b/redhat/configs/pending-rhel/generic/CONFIG_PAGE_BLOCK_ORDER deleted file mode 100644 index blahblah..blahblah 0 --- a/redhat/configs/pending-rhel/generic/CONFIG_PAGE_BLOCK_ORDER +++ /dev/null @@ -1,13 +0,0 @@ -# Symbol: PAGE_BLOCK_ORDER [=10] -# Type : integer -# Range : [1 10] -# Defined at mm/Kconfig:1008 -# Prompt: Page Block Order -# Location: -# -> Memory Management options -# -> Page Block Order (PAGE_BLOCK_ORDER [=10]) -# -# -# -# Commit: e13e7922d034 (mm: add CONFIG_PAGE_BLOCK_ORDER to select page block order) -CONFIG_PAGE_BLOCK_ORDER=10 diff --git a/redhat/configs/rhel/generic/CONFIG_PAGE_BLOCK_ORDER b/redhat/configs/rhel/generic/CONFIG_PAGE_BLOCK_ORDER new file mode 100644 index blahblah..blahblah 100644 --- /dev/null +++ b/redhat/configs/rhel/generic/CONFIG_PAGE_BLOCK_ORDER @@ -0,0 +1 @@ +CONFIG_PAGE_BLOCK_ORDER=10
-- https://gitlab.com/cki-project/kernel-ark/-/merge_requests/3928
From: David Hildenbrand on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/3928#note_2541188...
Hmm, but setting it to 10 for all archs will also mean that we will set it to 10 for the 16k and 64k kernel ... and we don't even want it at 10 as default on x86-64 either. Let me dig upstream ....
From: Waiman Long on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/3928#note_2541195...
For RHEL, PPC and arm64 have CONFIG_ARCH_FORCE_MAX_ORDER set. So this config will only affect x86_64 and s390.
From: David Hildenbrand on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/3928#note_2541205...
CONFIG_ARCH_FORCE_MAX_ORDER only defines the default and the ceiling:
+ range 1 ARCH_FORCE_MAX_ORDER if ARCH_FORCE_MAX_ORDER != 0 + default ARCH_FORCE_MAX_ORDER if ARCH_FORCE_MAX_ORDER != 0
So setting this config across all archs should affect them, as well?
From: Waiman Long on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/3928#note_2541268...
Correction, ARCH_FORCE_MAX_ORDER, if set, controls MAX_PAGE_ORDER, but PAGE_BLOCK_ORDER is a new setting that will affect all arches. Perhaps, we could unset it for now to keep the old behavior if we are not sure.
From: Patrick Talbert on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/3928#note_2560483...
@llong1 we can't really leave it unset; our build scripts will complain about an unset configuration item.
Right now due to the file in `redhat/configs/pending- rhel/generic/CONFIG_PAGE_BLOCK_ORDER` it is building with `CONFIG_PAGE_BLOCK_ORDER=10`. We can keep that or pick another value.
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/3928#note_2575563...
Actually, the scripts have betrayed us a bit here. 10 is the default for some arches, but it is not the default for all arches, and it is not even valid for PPC. Let me fix up this MR with the correct defaults per aches that we support and see if that looks better.
kernel@lists.fedoraproject.org
-
CKI ARK Bot (via Email Bridge) -
David Hildenbrand (via Email Bridge)
-
Justin M. Forbes (via Email Bridge)
-
Patrick Talbert (via Email Bridge)
-
Waiman Long (via Email Bridge)